[GitHub] incubator-trafodion pull request: [TRAFDOION-1666]script to update...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/223


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: add -p available option to insta...

[nonstop-qfchen]

GitHub user nonstop-qfchen opened a pull request:

https://github.com/apache/incubator-trafodion/pull/232

add -p available option to install_local_hadoop script

With this option, the port range will be chosen from those available at the 
time of running the install script. 

Hopefully, it reduces the chance of port conflict. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nonstop-qfchen/incubator-trafodion 
PICC_Bugs_2dot0

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #232


commit b72f727e2d20b61d30de59899f9808a2c0d6d12f
Author: narendragoyal 
Date:   2015-10-31T07:44:45Z

Merge pull request #235 from narendragoyal/x_DC2

- service monitor related.

commit e8b112bc55f79ac69727322812d461d8b1997ee7
Author: Narendra Goyal 
Date:   2015-10-31T07:47:42Z

Merge branch 'AdvEnt2.0' of github.com:esgyn/traf-plus into x_DC2

commit 8903af78dd090ee79cd6cf07db0ce5d963e1ca6f
Author: Sean Broeder 
Date:   2015-10-31T15:43:20Z

Control point changes for multi-DC

commit badf34fdfd06951c5bbaf32c3bbef0116ca76eda
Author: Sean Broeder 
Date:   2015-10-31T17:11:12Z

XDC changes

commit 1f19953c9e0e44b46a6e866d6c50c4985ad64d4e
Author: Sean Broeder 
Date:   2015-10-31T18:26:59Z

Merge pull request #241 from sbroeder/x_DC

X dc

commit 85b6648807cb6577961b09e478811fb349a6fbe5
Author: Narendra Goyal 
Date:   2015-10-31T18:49:00Z

Merge branch 'AdvEnt2.0' of github.com:esgyn/traf-plus into x_DC2

commit 88a5605808f0a37b64671c15129e6c6879ea8f0f
Author: Sean Broeder 
Date:   2015-10-31T19:54:53Z

Correction for getting/setting the key on Tlog records

commit 0275520f66b87631ef3150929b0042c362a5dc64
Author: Sean Broeder 
Date:   2015-10-31T21:03:31Z

Merge pull request #242 from sbroeder/x_DC

Correction for getting/setting the key on Tlog records

commit fd1fb531d5dc424e938378440657041bc91fcec7
Author: Shang-Sheng Tung 
Date:   2015-11-01T02:20:07Z

Check in code to handle recovery for some x_DC partition case.

commit 5519f5998dc1cb7627d88fa9764dfb950d2b0408
Author: shangshengtung 
Date:   2015-11-01T05:37:56Z

Merge pull request #243 from shangshengtung/x_DC

Check in code to handle recovery for some x_DC partition case.

commit 6351501ba13e98b6ed11b7d1b705d04e4f4f0e7d
Author: Shang-Sheng Tung 
Date:   2015-11-01T07:55:42Z

Check in fix for peer check in network partition case.

commit d4b12b5abd74f4a3ebcfe023e838ea797986f25d
Author: Narendra Goyal 
Date:   2015-11-01T16:09:31Z

fix a bug in ilh_trafinit

commit 11de1714736ddb97b7874a3497742a4f4311f90b
Author: Narendra Goyal 
Date:   2015-11-01T16:09:40Z

Merge branch 'AdvEnt2.0' of github.com:esgyn/traf-plus into x_DC2

commit aa9e1719e1875bcb3c2771fb0d880c451c9eb08e
Author: narendragoyal 
Date:   2015-11-01T17:30:03Z

Merge pull request #245 from narendragoyal/x_DC2

X dc2

commit 29f89bbe0f21102e9ff03bb237af78c1e994bbe6
Author: shangshengtung 
Date:   2015-11-01T17:37:19Z

Merge pull request #244 from shangshengtung/x_DC

Check in fix for peer check in network partition case.

commit 3eb312bebdb0e5c0d60bd6a62d70e6753a374010
Author: Suresh Subbiah 
Date:   2015-11-02T02:03:53Z

Merge pull request #239 from sureshsubbiah/br2

Backup-Restore performance improvements

commit 38234227f8a507829682bbc67c8fe7cda5f11774
Author: William/Taian, Wei 
Date:   2015-11-02T02:16:24Z

Merge pull request #2 from esgyn/AdvEnt2.0

Update from Origin

commit 1eb670298affe371512c4537dddf966c6847a01d
Author: Venkat Muthuswamy 
Date:   2015-11-02T03:21:27Z

Enable/Disable Enterprise features

commit b1c78176991f1e2bbf01761e1ca5f64371b014d0
Author: Venkat Muthuswamy 
Date:   2015-11-02T04:47:10Z

Merge pull request #246 from venkat1m/dbmgr-fixes-1027

Enable/Disable Enterprise features

commit eefbf25c61f4ccb79c062bd013ded2ce32d04cdd
Author: William/Taian, Wei 
Date:   2015-11-02T04:54:23Z

Merge pull request #3 from esgyn/AdvEnt2.0

Update from Origin

commit 8c700610ce909be003b4c31ef182d2a0476a4fda
Author: Venkat Muthuswamy 
Date:   2015-11-02T07:19:58Z

Parse RMS stats as 

[GitHub] incubator-trafodion pull request: Fix for JIRA 1712. Use of option...

[sandhyasun]

GitHub user sandhyasun opened a pull request:

https://github.com/apache/incubator-trafodion/pull/233

Fix for JIRA 1712. Use of option -p in hadoop fs -mkdir



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sandhyasun/incubator-trafodion misc_fix_traf

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #233


commit 40b0d39730dd2aadf9ae108ba68f5534a5e53113
Author: Sandhya Sundaresan 
Date:   2015-12-17T18:14:46Z

Fix for JIRA 1712. Use of option -p in hadoop fs -mkdir




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: add -p available option to insta...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: A new option "-p available" to i...

[nonstop-qfchen]

GitHub user nonstop-qfchen opened a pull request:

https://github.com/apache/incubator-trafodion/pull/234

A new option "-p available" to install_local_hadoop. 

With this option, the port range is chosen randomly from the list returned 
reported by findPort.py script. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nonstop-qfchen/incubator-trafodion 
availablePort

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #234


commit be26ce404319fc9f70623f6217517886aebfd496
Author: Qifan Chen 
Date:   2015-12-17T20:24:17Z

add the "-p available" option to install local haddop script

commit 2d2f0013043f587170d5667279d3bb5c20b51158
Author: Qifan Chen 
Date:   2015-12-17T20:30:39Z

make sure findPort.py is pushed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1668]initialize spj f...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/203#discussion_r47968093
  
--- Diff: core/conn/spj_mgmt/Makefile ---
@@ -0,0 +1,37 @@
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+LIBDIR := lib
+JAVAC := $(JAVA_HOME)/bin/javac
+INSTALL_LIBDIR := ${MY_SQROOT}/export/lib
+INSTALL_SCRIPTSDIR := ${MY_SQROOT}/sql/scripts
+CP :=/bin/cp -f
+INSTALL_INCLUDEDIR := ${MY_SQROOT}/export/include
--- End diff --

Do we need these 2 variables LIBDIR and INSTALL_INCLUDEDIR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1668]initialize spj f...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/203#discussion_r47974185
  
--- Diff: 
core/conn/spj_mgmt/src/main/java/org/trafodion/mgmt/JarFileMgmt.java ---
@@ -0,0 +1,434 @@
+/**
+* @@@ START COPYRIGHT @@@
+*
+* Licensed to the Apache Software Foundation (ASF) under one
+* or more contributor license agreements.  See the NOTICE file
+* distributed with this work for additional information
+* regarding copyright ownership.  The ASF licenses this file
+* to you under the Apache License, Version 2.0 (the
+* "License"); you may not use this file except in compliance
+* with the License.  You may obtain a copy of the License at
+*
+*  http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing,
+* software distributed under the License is distributed on an
+* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+* KIND, either express or implied.  See the License for the
+* specific language governing permissions and limitations
+* under the License.
+*
+* @@@ END COPYRIGHT @@@
+ */
+package org.trafodion.mgmt;
--- End diff --

can we call the package name same as the directory name 
org.trafodion.spjmgmt.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [[TRAFODION 1694]] [[ TRAFODION ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/230


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1618] Fix row estimat...

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/229#discussion_r47987097
  
--- Diff: core/sql/src/main/java/org/trafodion/sql/HBaseClient.java ---
@@ -1088,36 +1139,65 @@ public boolean estimateRowCount(String tblName, int 
partialRowSize,
   //printQualifiers(reader, 100);
   if (ROWS_TO_SAMPLE > 0 &&
   totalEntries == reader.getEntries()) {  // first file only
-// Trafodion column qualifiers are ordinal numbers, which
-// makes it easy to count missing (null) values. We also count
-// the non-Put KVs (typically delete-row markers) to estimate
-// their frequency in the full file set.
+
+// Trafodion column qualifiers are ordinal numbers, but are 
represented
+// as varying length unsigned little-endian integers in 
lexicographical
+// order. So, for example, in a table with 260 columns, the 
column
+// qualifiers (if present) will be read in this order: 
+// 1 (x'01'), 257 (x'0101'), 2 (x'02'), 258 (x'0201'), 3 
(x'03'),
+// 259 (x'0301'), 4 (x'04'), 260 (x'0401'), 5 (x'05'), 6 
(x'06'), 
+// 7 (x'07'), ...
+// We have crossed the boundary to the next row if and only if 
the
--- End diff --

I guess the same problem (if it is a problem) exists in the old code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1618] Fix row estimat...

[sureshsubbiah]

Github user sureshsubbiah commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/229#discussion_r47987640
  
--- Diff: core/sql/src/main/java/org/trafodion/sql/HBaseClient.java ---
@@ -1088,36 +1139,65 @@ public boolean estimateRowCount(String tblName, int 
partialRowSize,
   //printQualifiers(reader, 100);
   if (ROWS_TO_SAMPLE > 0 &&
   totalEntries == reader.getEntries()) {  // first file only
-// Trafodion column qualifiers are ordinal numbers, which
-// makes it easy to count missing (null) values. We also count
-// the non-Put KVs (typically delete-row markers) to estimate
-// their frequency in the full file set.
+
+// Trafodion column qualifiers are ordinal numbers, but are 
represented
+// as varying length unsigned little-endian integers in 
lexicographical
+// order. So, for example, in a table with 260 columns, the 
column
+// qualifiers (if present) will be read in this order: 
+// 1 (x'01'), 257 (x'0101'), 2 (x'02'), 258 (x'0201'), 3 
(x'03'),
+// 259 (x'0301'), 4 (x'04'), 260 (x'0401'), 5 (x'05'), 6 
(x'06'), 
+// 7 (x'07'), ...
+// We have crossed the boundary to the next row if and only if 
the
+// next qualifier read is less than or equal to the previous, 
+// compared unsigned, lexicographically.
--- End diff --

Some simplication is possible for aligned format though it is not clear if 
additional complexitu in code is warranted. With aligned format we know that 
each row will have exactly one column and I suppose null/default values will 
always be included. So the number of KeyValues we get from the header is the 
number of rows in the table. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1618] Fix row estimat...

[sureshsubbiah]

Github user sureshsubbiah commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/229#discussion_r47987524
  
--- Diff: core/sql/src/main/java/org/trafodion/sql/HBaseClient.java ---
@@ -1088,36 +1139,65 @@ public boolean estimateRowCount(String tblName, int 
partialRowSize,
   //printQualifiers(reader, 100);
   if (ROWS_TO_SAMPLE > 0 &&
   totalEntries == reader.getEntries()) {  // first file only
-// Trafodion column qualifiers are ordinal numbers, which
-// makes it easy to count missing (null) values. We also count
-// the non-Put KVs (typically delete-row markers) to estimate
-// their frequency in the full file set.
+
+// Trafodion column qualifiers are ordinal numbers, but are 
represented
+// as varying length unsigned little-endian integers in 
lexicographical
+// order. So, for example, in a table with 260 columns, the 
column
+// qualifiers (if present) will be read in this order: 
+// 1 (x'01'), 257 (x'0101'), 2 (x'02'), 258 (x'0201'), 3 
(x'03'),
+// 259 (x'0301'), 4 (x'04'), 260 (x'0401'), 5 (x'05'), 6 
(x'06'), 
+// 7 (x'07'), ...
+// We have crossed the boundary to the next row if and only if 
the
+// next qualifier read is less than or equal to the previous, 
+// compared unsigned, lexicographically.
+
--- End diff --

Current code is good, though I am confused as to why we do not try 
something simpler like
comparing the Key in consecutive KeyValue objects till it changes? There is 
this method on KeyValue that will return the key as a string 
https://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValue.html#getKeyString()
Maybe we just compare strings then?
Is the idea that keys can be longer strings and are more expensive to 
compare?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...

[kevinxu021]

Github user kevinxu021 commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/231#discussion_r47984062
  
--- Diff: core/sqf/sql/scripts/cleanlogs ---
@@ -0,0 +1,92 @@
+#!/bin/bash
+#
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+# This script cleans up the log files of various components
+if [ -e $SQ_PDSH ]; then
+   L_PDSH="/usr/bin/pdsh $MY_NODES "
+else
+   L_PDSH=
+fi
+
+function usage() {
+   prog=`basename $0` 
+   echo ""
+   echo "$prog { all | dcs | rest | core }"
+   echo "all  --- Remove files from core, dcs and rest logs folder"
+   echo "dcs  --- Remove files from $DCS_INSTALL_DIR/logs folder"
+   echo "rest --- Remove files from $REST_INSTALL_DIR/logs folder"
+   echo "core --- Remove log files residing in $MY_SQROOT/logs folder"
--- End diff --

dcs and rest are component name. Could you please list out what kinds of 
logs included in core? For DEV, it's very good, but for production it's 
dangerous that it may lost lots of important info. A little confused that the 
logs has rotation rules why to clear them?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...

[kevinxu021]

Github user kevinxu021 commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/231#discussion_r47983358
  
--- Diff: RAT_README.txt ---
@@ -60,6 +60,7 @@ $MY_SQROOT/../sql/bin/SqlciErrors.txt
 
 dcs/conf/servers 
 dcs/conf/backup-masters 
+dcs/conf/master
  :  Apache Trafodion DCS default configuration file
  -> configuration file do not handle comments
 
--- End diff --

Please describe those files separately. it's not very clear. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/231#discussion_r47984503
  
--- Diff: core/sqf/sql/scripts/cleanlogs ---
@@ -0,0 +1,92 @@
+#!/bin/bash
+#
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+# This script cleans up the log files of various components
+if [ -e $SQ_PDSH ]; then
+   L_PDSH="/usr/bin/pdsh $MY_NODES "
+else
+   L_PDSH=
+fi
+
+function usage() {
+   prog=`basename $0` 
+   echo ""
+   echo "$prog { all | dcs | rest | core }"
+   echo "all  --- Remove files from core, dcs and rest logs folder"
+   echo "dcs  --- Remove files from $DCS_INSTALL_DIR/logs folder"
+   echo "rest --- Remove files from $REST_INSTALL_DIR/logs folder"
+   echo "core --- Remove log files residing in $MY_SQROOT/logs folder"
--- End diff --

cleanlogs script is only a helpful utility. This cleanlogs script is not 
invoked by any other script and used only on demand on need basis.  The logs 
for core are all the log files that reside in MY_SQROOT/logs folder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/231#discussion_r47984639
  
--- Diff: RAT_README.txt ---
@@ -60,6 +60,7 @@ $MY_SQROOT/../sql/bin/SqlciErrors.txt
 
 dcs/conf/servers 
 dcs/conf/backup-masters 
+dcs/conf/master
  :  Apache Trafodion DCS default configuration file
  -> configuration file do not handle comments
 
--- End diff --

dcs/conf/master is another configuration file which contains the hostname.. 
It is  just like backup-masters file and as described in the comments it  does 
not handle comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...

[kevinxu021]

Github user kevinxu021 commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/231#discussion_r47985038
  
--- Diff: core/sqf/sql/scripts/cleanlogs ---
@@ -0,0 +1,92 @@
+#!/bin/bash
+#
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+# This script cleans up the log files of various components
+if [ -e $SQ_PDSH ]; then
+   L_PDSH="/usr/bin/pdsh $MY_NODES "
+else
+   L_PDSH=
+fi
+
+function usage() {
+   prog=`basename $0` 
+   echo ""
+   echo "$prog { all | dcs | rest | core }"
+   echo "all  --- Remove files from core, dcs and rest logs folder"
+   echo "dcs  --- Remove files from $DCS_INSTALL_DIR/logs folder"
+   echo "rest --- Remove files from $REST_INSTALL_DIR/logs folder"
+   echo "core --- Remove log files residing in $MY_SQROOT/logs folder"
--- End diff --

it's might be helpful that save them before remove, or give users some tips 
and tell them the logs will be removed. if they insist on, go ahead to remove 
them. yes, it's a utility, but some users might use it, right? we know what 
they are in MY_SQROOT/logs folder, but the users may not, so those info should 
be included. otherwise, users may make mistakes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: A new option "-p available" to i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/234


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---