[GitHub] incubator-trafodion pull request: [TRAFODION-1618] Fix row estimat...

2015-12-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...

2015-12-18 Thread hegdean
Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/231#discussion_r48059956
  
--- Diff: RAT_README.txt ---
@@ -60,6 +60,7 @@ $MY_SQROOT/../sql/bin/SqlciErrors.txt
 
 dcs/conf/servers 
 dcs/conf/backup-masters 
+dcs/conf/master
  :  Apache Trafodion DCS default configuration file
  -> configuration file do not handle comments
 
--- End diff --

This is not documentation but a short description for each component  for 
list of files that excludes the copyright information as mentioned in the 
initial section of the this file. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...

2015-12-18 Thread hegdean
Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/231#discussion_r48060646
  
--- Diff: install/installer/setup_ssh_key ---
@@ -0,0 +1,27 @@
+#!/bin/bash
--- End diff --

This is is similar to our backup-masters file which is also empty and does 
no harm but it helps users to know that they can modify this file if they 
require DcsMaster to start on a specific node. Dcs documentation will be 
updated in the subsequent PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Please review changes to Apache Trafodion project status page

2015-12-18 Thread Suresh Subbiah
Thank you all for the review and for your help in getting the changes
published (being patient with my umpteen mistakes).
The changes should be visible now.

Thanks
Suresh


On Tue, Dec 15, 2015 at 2:06 PM, Roberta Marton 
wrote:

> Suresh, since you are updating the website, could you add the Website
> announcement after Selva committership?
>
>   
> 2015-11-13: Welcome Hans Zeller as new committer and PPMC
> member.
>   
>   
> 2015-11-13: Welcome Selvaganesan Govindarajan as new committer
> and PPMC member.
>   
>   
> 2015-12-08: Our Apache Incubator website has been redesigned;
> come check it out and give us feedback.
>   
>
> Site looks good, thanks for doing this.
>
>Roberta
>
> -Original Message-
> From: Hans Zeller [mailto:hans.zel...@esgyn.com]
> Sent: Tuesday, December 15, 2015 11:50 AM
> To: codereview@trafodion.incubator.apache.org
> Subject: Re: Please review changes to Apache Trafodion project status page
>
> Looks good to me.
>
> Thanks,
>
> Hans
>
> On Tue, Dec 15, 2015 at 11:41 AM, Suresh Subbiah <
> suresh.subbia...@gmail.com
> > wrote:
>
> > Hi ,
> >
> > Can you please review these changes to the Apache Trafodion project
> > status page?
> > http://incubator.apache.org/projects/trafodion.html
> >
> > Old (trafodion.old.xml) and new (trafodion.xml) files are attached. We
> > do not have a public staging area to share diffs.
> >
> > Thank you Roberta for providing these changes and for guiding me
> > through every step.
> >
> > Thanks
> > Suresh
> >
> >
>