[GitHub] incubator-trafodion pull request: Fixed up expected results file f...

[robertamarton]

GitHub user robertamarton opened a pull request:

https://github.com/apache/incubator-trafodion/pull/277

Fixed up expected results file for privs2/EXPECTED135



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertamarton/incubator-trafodion priv-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #277


commit 678195be7407acf5c504c942c8dbf0a9902540f2
Author: Roberta Marton 
Date:   2016-01-21T17:10:37Z

Fixed up expected file for privs2 test135




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: No change -- testing only

[svarnau]

GitHub user svarnau opened a pull request:

https://github.com/apache/incubator-trafodion/pull/278

No change -- testing only



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/incubator-trafodion tj

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #278


commit 0e54e4c97e9034e771e38de6b5bc0103b609f4b0
Author: Steve Varnau 
Date:   2016-01-21T18:28:13Z

No change -- testing only




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50443958
  
--- Diff: install/installer/dcs_installer ---
@@ -196,8 +194,6 @@ echo $DCS_PRIMARY_MASTER_NODE > $DCS_DIR/conf/master
 
 
 if [[ "$ENABLE_HA" == "true" ]]; then
-
-   ##Configure dcs-site.xml file
--- End diff --

can you put back the comments in this file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50444726
  
--- Diff: install/installer/traf_add_sudoAccess ---
@@ -23,12 +23,12 @@
 TRAF_CONFIG=/etc/trafodion/trafodion_config
 source $TRAF_CONFIG
 
-if [ $node_count -eq 1 ]; then
+if [ $all_node_count -eq 1 ]; then
 TRAF_PDSH=""
 TRAF_PDCP=""
 else
-TRAF_PDSH="pdsh -R exec $MY_NODES $PDSH_SSH_CMD"
-TRAF_PDCP="pdcp -R ssh $MY_NODES"
+TRAF_PDSH="pdsh -R exec $ALL_NODES $PDSH_SSH_CMD"
+TRAF_PDCP="pdcp -R ssh $ALL_NODES"
 fi
--- End diff --

Can generalize the TRAF_PDSH and TRAF_PDCP environment variables in the 
config file that is sourced in.  Then these conditional checks for setting them 
can be removed from each script


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50451782
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
+read answer
+ 
+if [ -z $answer ]; then
+  echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
+else
+  if [[ "${answer}" =~ ^[Yy]$ ]]; then
+ echo "export MANAGE_ENABLED=\"Y\"" >> $LOCAL_TRAF_CONFIG
+ #List of Management Nodes
+ echo -n "Enter list management nodes (blank separated), default 
[$MANAGE_NODES]: "
+ read answer
+ if [[ -z "$answer" ]]; then
+if [ -z "$MANAGE_NODES" ]; then
+   echo "***ERROR: Must enter list of management nodes."
+   exit -1
+fi
+ else
+MANAGE_NODES="$answer"
--- End diff --

Should be MANAGEMENT_NODES instead of MANAGE_NODES. Should fix all files 
where this is referenced


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: No change -- testing only

[svarnau]

GitHub user svarnau reopened a pull request:

https://github.com/apache/incubator-trafodion/pull/278

No change -- testing only



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/incubator-trafodion tj

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #278


commit 0e54e4c97e9034e771e38de6b5bc0103b609f4b0
Author: Steve Varnau 
Date:   2016-01-21T18:28:13Z

No change -- testing only




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: No change -- testing only

[svarnau]

Github user svarnau closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/278


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50466634
  
--- Diff: install/installer/traf_sqgen ---
@@ -0,0 +1,96 @@
+#!/bin/bash
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+export TRAF_CONFIG=/etc/trafodion/trafodion_config
+
+source $TRAF_CONFIG
+
+STARTING_NODE=$(hostname)
+
+#==
+echo "***INFO: starting sqgen" | tee -a $INSTALL_LOG
+cd $SQ_ROOT/sql/scripts
+$SQ_ROOT/sql/scripts/sqgen
+SQGEN_RC=$?
+if [ "$SQGEN_RC" != "0" ]; then
+echo "***ERROR: sqgen failed with RC=$SQGEN_RC. Check install log file 
for details." | tee -a $INSTALL_LOG
+exit -1;
+fi
+#==
+
+if [ "$node_count" -ne "1" ]; then
--- End diff --

Should this now be all_node_count instead of node_count?

 It would have been better if node_count was assigned all_node_count  and 
MY_NODES was assigned ALL_NODES. That way changes could be kept to  minimal


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50466851
  
--- Diff: install/installer/traf_sqgen ---
@@ -0,0 +1,96 @@
+#!/bin/bash
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+export TRAF_CONFIG=/etc/trafodion/trafodion_config
+
+source $TRAF_CONFIG
+
+STARTING_NODE=$(hostname)
+
+#==
+echo "***INFO: starting sqgen" | tee -a $INSTALL_LOG
+cd $SQ_ROOT/sql/scripts
+$SQ_ROOT/sql/scripts/sqgen
+SQGEN_RC=$?
+if [ "$SQGEN_RC" != "0" ]; then
+echo "***ERROR: sqgen failed with RC=$SQGEN_RC. Check install log file 
for details." | tee -a $INSTALL_LOG
+exit -1;
+fi
+#==
+
+if [ "$node_count" -ne "1" ]; then
+echo "***INFO: copying $HOME/sqcert directory to all nodes" | tee -a 
$INSTALL_LOG
+$PDCP $ALL_NODES -x $HOSTNAME -r $HOME/sqcert $HOME
+fi
+
+#==
+
+if [ "$all_node_count" -ne "1" ]; then
--- End diff --

Is this check required ? can the pdcp step be incorporated in the previous 
conditional check itself?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Fixed up expected results file f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/277


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1648 Region Split/Move...

[trinakrug]

GitHub user trinakrug opened a pull request:

https://github.com/apache/incubator-trafodion/pull/279

TRAFODION-1648 Region Split/Move work

Rework of Region Split/Move code.  Enhanced error handling and ability to 
split/move with active transactions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/trinakrug/incubator-trafodion tktraf_fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #279


commit 2b46c9c008d00bab539ecbf7f52cf32c173bf561
Author: Trina Krug 
Date:   2016-01-21T21:46:34Z

TRAFODION-1648




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1662] Predicate push ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/255


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1774]use hashCode ins...

[xwq]

GitHub user xwq opened a pull request:

https://github.com/apache/incubator-trafodion/pull/280

[TRAFODION-1774]use hashCode instead of random

[TRAFODION-1774][MT-DCS]use hashCode() instead of random to make the
stmtHandle is unique

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xwq/incubator-trafodion master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #280


commit db4100d6a0d30871ccc2af185c76e6332cc86ca5
Author: Weiqing Xu 
Date:   2016-01-22T06:33:01Z

[TRAFODION-1774]use hashCode instead of random

[TRAFODION-1774][MT-DCS]use hashCode() instead of random to make the
stmtHandle is unique




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50451279
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
+read answer
+ 
+if [ -z $answer ]; then
+  echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
+else
+  if [[ "${answer}" =~ ^[Yy]$ ]]; then
+ echo "export MANAGE_ENABLED=\"Y\"" >> $LOCAL_TRAF_CONFIG
+ #List of Management Nodes
+ echo -n "Enter list management nodes (blank separated), default 
[$MANAGE_NODES]: "
+ read answer
+ if [[ -z "$answer" ]]; then
+if [ -z "$MANAGE_NODES" ]; then
+   echo "***ERROR: Must enter list of management nodes."
--- End diff --

Can we update the message as "Management nodes must be specified."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50449380
  
--- Diff: install/installer/traf_config_setup ---
@@ -211,7 +215,7 @@ fi
 #==
 # List of Nodes
 
-echo -n "Enter list of nodes (blank separated), default [$NODE_LIST]: "
+echo -n "Enter list of Trafodion nodes (blank separated), default 
[$NODE_LIST]: "
--- End diff --

Do we want to call this Trafodion nodes or data nodes: ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50449749
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
--- End diff --

Should this question be "Do you have a set of management nodes (Y/N), 
default is N:"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50451389
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
+read answer
+ 
+if [ -z $answer ]; then
+  echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
+else
+  if [[ "${answer}" =~ ^[Yy]$ ]]; then
+ echo "export MANAGE_ENABLED=\"Y\"" >> $LOCAL_TRAF_CONFIG
+ #List of Management Nodes
+ echo -n "Enter list management nodes (blank separated), default 
[$MANAGE_NODES]: "
+ read answer
+ if [[ -z "$answer" ]]; then
+if [ -z "$MANAGE_NODES" ]; then
+   echo "***ERROR: Must enter list of management nodes."
+   exit -1
+fi
+ else
+MANAGE_NODES="$answer"
+ fi
+
+ echo "export MANAGE_NODES=\"$MANAGE_NODES\"" >> $LOCAL_TRAF_CONFIG
+  else
+ echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
--- End diff --

can be removed if default value is initialized


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50452962
  
--- Diff: install/installer/traf_config_setup ---
@@ -544,9 +574,9 @@ fi
 echo "export ENABLE_HA=\"$ENABLE_HA\"" >> $LOCAL_TRAF_CONFIG
 
 #==
-#Get the floating IP address, interface name and the list of backup nodes 
to be used 
--- End diff --

can you put back this comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50453726
  
--- Diff: install/installer/traf_getHadoopNodes ---
@@ -31,20 +29,22 @@ echo "***INFO: Getting list of all $HADOOP_TYPE nodes"
 
 curlRC=0
 if [[ $HADOOP_TYPE == "cloudera" ]]; then
-   curl -su $ADMIN:$PASSWORD http://$URL/api/v6/cm/deployment > tempFile
+   curl -k -su $ADMIN:$PASSWORD $URL/api/v10/hosts > tempFile
curlRC=$?
--- End diff --

Looks like curlRC is not being used here, can be removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---