[GitHub] incubator-trafodion pull request #557: Fixes for TRAFODION-2068

2016-06-22 Thread robertamarton 
GitHub user robertamarton opened a pull request:

https://github.com/apache/incubator-trafodion/pull/557

Fixes for TRAFODION-2068

TRAFODION-2068: Missing DISCLAIMER files for release package

Added DISCLAIMER file to servers package.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertamarton/incubator-trafodion testrc2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #557


commit 649561964565e1d6896d2e584754b1c757a0fd01
Author: Roberta Marton 
Date:   2016-06-22T23:00:41Z

Fixes for TRAFODION-2068

TRAFODION-2068: Missing DISCLAIMER files for release package

Added DISCLAIMER file to servers package.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #556: [TRAFODION-2069] Fixed sqcheck to use...

2016-06-22 Thread DaveBirdsall 
Github user DaveBirdsall commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/556#discussion_r68146251
  
--- Diff: core/sqf/sql/scripts/sqcheck ---
@@ -33,7 +33,7 @@ function Usage {
 echo 
 echo "Usage: $0 [ -c  | -i  | -d  | -h | -f | -q | -v | -r 
| -j ]"
 echo 
-echo "-i   Number of times the check for SQ processes be done 
(Default $max_checks)"
+echo "-i   Number of times the check for Trafodion processes be 
done (Default $max_checks)"
--- End diff --

Do we want to say, "Number of times the check for Trafodion processes 
**will** be done (Default $max_checks)"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #555: JIRA TRAFODION-2084 Handling of inval...

2016-06-22 Thread DaveBirdsall 
Github user DaveBirdsall commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/555#discussion_r68133142
  
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -4825,7 +4826,21 @@ Int32 NADefaults::validateFloat(const char *value, 
float ,
 {
   Int32 n = -1;// NT's scanf("%n") is not quite correct; hence this 
code-around
   sscanf(value, "%g%n", , );
-  if (n > 0 && value[n] == '\0') return TRUE;  // a valid float
+  if (n > 0 && value[n] == '\0') 
+{
+  switch (attrEnum)
+{
+case HIVE_INSERT_ERROR_MODE:
--- End diff --

Not sure why this is needed. Why not follow the model, say, of 
validateUIntFrom0To5? (that is, add your own validateUIntFrom0To3)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #556: [TRAFODION-2069] Fixed sqcheck to use...

2016-06-22 Thread zcorrea 
GitHub user zcorrea opened a pull request:

https://github.com/apache/incubator-trafodion/pull/556

[TRAFODION-2069] Fixed sqcheck to use TRAF_EXCLUDE_LIST when calculat…

…ing counts

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zcorrea/incubator-trafodion TRAFODION-2069

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #556


commit d13776b029da6c78401f70aa2709b283029683c1
Author: Zalo Correa 
Date:   2016-06-22T19:08:38Z

[TRAFODION-2069] Fixed sqcheck to use TRAF_EXCLUDE_LIST when calculating 
counts




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #555: JIRA TRAFODION-2084 Handling of inval...

2016-06-22 Thread anoopsharma00 
GitHub user anoopsharma00 opened a pull request:

https://github.com/apache/incubator-trafodion/pull/555

JIRA TRAFODION-2084 Handling of invalid data inserts into hive tables

cqd hive_insert_error_mode '' has been added to control
insert behavior.
  if 0, datatype error check is not done during inserts into hive tables.
 Invalid values may get inserted.
 This is the behavior prior to this JIRA fix.
  if 1, error check done, row is not inserted if conversion error.
 Insertion stops. This is new default behavior.
  if 2, error check done, row is not inserted if conversion error.
 Insertion continues with next row
  if 3, null inserted if conversion error.
 Insertion processing continues. This is hive behavior.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anoopsharma00/incubator-trafodion 
ansharma_hiveinserr_br

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #555


commit 392c60889cb437e08e3718a3fc54c244cbfb123b
Author: Anoop Sharma 
Date:   2016-06-22T20:19:59Z

JIRA TRAFODION-2084 Handling of invalid data inserts into hive tables

cqd hive_insert_error_mode '' has been added to control
insert behavior.
  if 0, datatype error check is not done during inserts into hive tables.
 Invalid values may get inserted.
 This is the behavior prior to this JIRA fix.
  if 1, error check done, row is not inserted if conversion error.
 Insertion stops. This is new default behavior.
  if 2, error check done, row is not inserted if conversion error.
 Insertion continues with next row
  if 3, null inserted if conversion error.
 Insertion processing continues. This is hive behavior.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #546: TRAFODION [109] Instrument Trafodion ...

2016-06-22 Thread robertamarton 
Github user robertamarton commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/546#discussion_r68089548
  
--- Diff: install/installer/traf_secure_setup ---
@@ -0,0 +1,342 @@
+#!/bin/bash
+
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+# KDC attributes
+MAX_LIFETIME="24hours"
+RENEW_LIFETIME="7days"
+
+# LDAP attributes
+LDAP_AUTH_FILE="traf_authentication_config_${HOSTNAME}"
+
+HOST_NAME=`hostname -f`
+
+# These differ depending on the distribution
+if [[ $HADOOP_TYPE == "cloudera" ]]; then
+  TRAF_KEYTAB_DIR='/etc/trafodion'
+  TRAF_KEYTAB="trafodion.keytab"
+  HBASE_KEYTAB=`sudo find /var/run/cloudera-scm-agent/process/ -name 
hbase.keytab | grep 'hbase-MASTER' | head -n 1`
+  HDFS_KEYTAB=`sudo find /var/run/cloudera-scm-agent/process/ -name 
hdfs.keytab | grep 'hdfs-NAMENODE/' | head -n 1`
+else
+  TRAF_KEYTAB_DIR='/etc/security/keytabs'
+  TRAF_KEYTAB="trafodion.service.keytab"
+  HBASE_KEYTAB='/etc/security/keytabs/hbase.service.keytab'
+  HDFS_KEYTAB='/etc/security/keytabs/hdfs.headless.keytab'
+fi
+
+#==
+#  Setup Trafodion environment for secure Hadoop
+#==
+
+LOCAL_WORKDIR="$( cd "$( dirname "$0" )" && pwd )"
+
+TRAF_CONFIG="/etc/trafodion/trafodion_config"
+LOCAL_SECURE_CONFIG="$LOCAL_WORKDIR/trafodion_secure_config"
+rm $LOCAL_SECURE_CONFIG  2>/dev/null
+
+
+#==
+# Kerberos enabled
+
+echo "***INFO: Starting Trafodion security configuration setup"
+
+# Check to see if kerberos is enabled in Hadoop
+cat /etc/hadoop/conf/core-site.xml | while read a; do
--- End diff --

Most definitely, was not aware of this environment variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #546: TRAFODION [109] Instrument Trafodion ...

2016-06-22 Thread hegdean 
Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/546#discussion_r68082081
  
--- Diff: install/installer/traf_secure_setup ---
@@ -0,0 +1,342 @@
+#!/bin/bash
+
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+# KDC attributes
+MAX_LIFETIME="24hours"
+RENEW_LIFETIME="7days"
+
+# LDAP attributes
+LDAP_AUTH_FILE="traf_authentication_config_${HOSTNAME}"
+
+HOST_NAME=`hostname -f`
+
+# These differ depending on the distribution
+if [[ $HADOOP_TYPE == "cloudera" ]]; then
+  TRAF_KEYTAB_DIR='/etc/trafodion'
+  TRAF_KEYTAB="trafodion.keytab"
+  HBASE_KEYTAB=`sudo find /var/run/cloudera-scm-agent/process/ -name 
hbase.keytab | grep 'hbase-MASTER' | head -n 1`
+  HDFS_KEYTAB=`sudo find /var/run/cloudera-scm-agent/process/ -name 
hdfs.keytab | grep 'hdfs-NAMENODE/' | head -n 1`
+else
+  TRAF_KEYTAB_DIR='/etc/security/keytabs'
+  TRAF_KEYTAB="trafodion.service.keytab"
+  HBASE_KEYTAB='/etc/security/keytabs/hbase.service.keytab'
+  HDFS_KEYTAB='/etc/security/keytabs/hdfs.headless.keytab'
+fi
+
+#==
+#  Setup Trafodion environment for secure Hadoop
+#==
+
+LOCAL_WORKDIR="$( cd "$( dirname "$0" )" && pwd )"
+
+TRAF_CONFIG="/etc/trafodion/trafodion_config"
+LOCAL_SECURE_CONFIG="$LOCAL_WORKDIR/trafodion_secure_config"
+rm $LOCAL_SECURE_CONFIG  2>/dev/null
+
+
+#==
+# Kerberos enabled
+
+echo "***INFO: Starting Trafodion security configuration setup"
+
+# Check to see if kerberos is enabled in Hadoop
+cat /etc/hadoop/conf/core-site.xml | while read a; do
--- End diff --

Use HADOOP_CNF_DIR environment variable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #503: TRAFODION-2016

2016-06-22 Thread mashengchen 
Github user mashengchen closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/503


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---