[GitHub] incubator-trafodion pull request #765: [TRAFODION-1758]: A user has dbroot r...
GitHub user robertamarton opened a pull request: https://github.com/apache/incubator-trafodion/pull/765 [TRAFODION-1758]: A user has dbroot role can't grant component privilege Privilege checks were not handling role checks correctly. PrivMgrComponentPrivileges::hasWGO is now checking privileges against roles. privs1/TEST137 was updated to test role privileges priv1/TEST120 was added to test query invalidation with roles (forgot to add it for a previous check in) You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertamarton/incubator-trafodion trafodion-1758 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafodion/pull/765.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #765 commit 1c93857502acd9ef9e14154df6a6e397284acc81 Author: Roberta MartonDate: 2016-10-17T20:30:59Z [TRAFODION-1758]: A user has dbroot role can't grant component privilege Privilege checks were not handling role checks correctly. PrivMgrComponentPrivileges::hasWGO is now checking privileges against roles. privs1/TEST137 was updated to test role privileges priv1/TEST120 was added to test query invalidation with roles (forgot to add it for a previous check in) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafodion pull request #763: [TRAFODION-1893]ODBC:Remove vcredist ...
Github user hegdean commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/763#discussion_r83725920 --- Diff: win-odbc64/Install/win64_installer/installer.iss --- @@ -152,6 +141,40 @@ begin Result := (GetUninstallString() <> ''); end; +procedure CurStepChanged(CurStep: TSetupStep); +var + bRedistNeedsInstall: Boolean; + sDefaultBrowserName: String; + sDefaultBrowserReg: String; + sDefaultBrowserValue: String; + iQuotePos: Integer; + lLength: Longint; + iRetCode: Integer; +begin + if CurStep=ssPostInstall then + begin +bRedistNeedsInstall := VCRedistNeedsInstall(); +if bRedistNeedsInstall=True then +begin + MsgBox('Install of Visual C++ Redistributable Packages for Visual Studio 2013 is not dectected.'+ #13#10#13#10 + 'Please download vcredist_x64.exe from Microsoft Download Centre and install it.', mbInformation, MB_OK); --- End diff -- Can we change the message to be as follows: Run-time dependency needed by the driver is not found. Proceeding to download and install run-time dependency from Microsoft. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---