[GitHub] incubator-trafodion pull request #1272: [TRAFODION-2773] When the timeout is...

2017-10-23 Thread SuJinpei 
Github user SuJinpei commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1272#discussion_r146433587
  
--- Diff: core/conn/odb/src/odb.c ---
@@ -4156,18 +4156,17 @@ static void sigcatch(int sig)
 exit ( EX_SIGNAL );
 #else 
 if ( tn == 1 ) { /* single threaded */
-tclean( 0 );
 gclean();
-exit( EX_SIGNAL );
 } else {
 for ( i = 0 ; i < tn ; i++ ) {
-if ( !pthread_kill(thid[i], 0) ) {  /* If this thread is 
alive... */
+if ( pthread_kill(thid[i], 0) ) {  /* If this thread is 
alive... */
--- End diff --

Yes, I misunderstood it.


---

[GitHub] incubator-trafodion pull request #1273: [TRAFODION-2780] The mxosrvr dumps c...

2017-10-23 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/1273


---

[GitHub] incubator-trafodion pull request #1273: [TRAFODION-2780] The mxosrvr dumps c...

2017-10-23 Thread selvaganesang 
Github user selvaganesang commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1273#discussion_r146354070
  
--- Diff: core/conn/odbc/src/odbc/nsksrvr/SrvrConnect.cpp ---
@@ -1190,10 +1176,6 @@ ImplInit (
srvrGlobal->receiveThrId = getpid();
timer_register();
 
--- End diff --

Thanks for catching this inadvertent deletion of timer initialization call.


---

[GitHub] incubator-trafodion pull request #1274: Miscellaneous authorization changes:

2017-10-23 Thread robertamarton 
GitHub user robertamarton opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1274

Miscellaneous authorization changes:

- Unregister user does not remove component privileges
- Reuse unused entries from the authID ranges
- Add "changeuser" command to update user credentials in place instead of
  requiring a new sqlci session to be started.  Changed privs1/TEST132 to 
use
  this change and cut about 5 minutes off the test time.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertamarton/incubator-trafodion fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1274


commit 079ea00a1710c9ca8474db06a44309e21c5a0361
Author: Roberta Marton 
Date:   2017-10-23T16:13:00Z

Miscellaneous authorization changes:

- Unregister user does not remove component privileges
- Reuse unused entries from the authID ranges
- Add "changeuser" command to update user credentials in place instead of
  requiring a new sqlci session to be started.  Changed privs1/TEST132 to 
use
  this change and cut about 5 minutes off the test time.




---

[GitHub] incubator-trafodion pull request #1272: [TRAFODION-2773] When the timeout is...

2017-10-23 Thread selvaganesang 
Github user selvaganesang commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1272#discussion_r146286486
  
--- Diff: core/conn/odb/src/odb.c ---
@@ -4156,18 +4156,17 @@ static void sigcatch(int sig)
 exit ( EX_SIGNAL );
 #else 
 if ( tn == 1 ) { /* single threaded */
-tclean( 0 );
 gclean();
-exit( EX_SIGNAL );
 } else {
 for ( i = 0 ; i < tn ; i++ ) {
-if ( !pthread_kill(thid[i], 0) ) {  /* If this thread is 
alive... */
+if ( pthread_kill(thid[i], 0) ) {  /* If this thread is 
alive... */
--- End diff --

pthread_kill returns 0 when the thread exists. So, earlier code ( ! 
pthread_kill ...) is a valid one


---

[GitHub] incubator-trafodion pull request #1264: [TRAFODION-2772] - retrieve a value ...

2017-10-23 Thread selvaganesang 
Github user selvaganesang commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1264#discussion_r146280638
  
--- Diff: core/sql/exp/exp_function.cpp ---
@@ -6503,8 +6503,19 @@ ex_expr::exp_return_type 
ex_function_json_object_field_text::eval(char *op_data[
 Int32 prec2 = ((SimpleType *)getOperand(2))->getPrecision();
 len2 = Attributes::trimFillerSpaces( op_data[2], prec2, len2, cs );
 }
+
 char *rltStr = NULL;
-JsonReturnType ret = json_extract_path_text(, op_data[1], 1, 
op_data[2]);
+char *jsonStr = new(heap) char[len1+1];
+char *jsonAttr = new(heap) char[len2+1];
+if (jsonStr == NULL || jsonAttr == NULL)
+{
+return ex_expr::EXPR_ERROR;
+}
+memset(jsonStr, 0, len1+1);
+memset(jsonAttr, 0, len2+1);
--- End diff --

Consider setting the null character after strncpy instead


---