[GitHub] incubator-trafodion pull request #1345: [TRAFODION-2839] Change Incr UPDATE ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/1345


---

[GitHub] incubator-trafodion pull request #1351: [TRAFODION-2733] BMO quota changes

[selvaganesang]

GitHub user selvaganesang opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1351

[TRAFODION-2733] BMO quota changes

Fix for hive/TEST009 regression failure with commit 375eeeab7a

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/selvaganesang/incubator-trafodion 
trafodion-2733

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1351


commit d189467f396a2831e6fc0aef1a8799a7e7fa9f6d
Author: selvaganesang 
Date:   2017-12-15T18:35:57Z

[TRAFODION-2733] BMO quota changes

Fix for hive/TEST009 regression failure with commit 375eeeab7a




---

[GitHub] incubator-trafodion pull request #1350: [TRAFODION-2849] Add BLOB and CLOB f...

[liuyu000]

GitHub user liuyu000 opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1350

[TRAFODION-2849] Add BLOB and CLOB for *Trafodion SQL Reference Manual*



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liuyu000/incubator-trafodion SQLLOB

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1350


commit 3f09ff5ce425cc004009b44bb1e28f7a51663ce8
Author: liu.yu 
Date:   2017-12-15T10:28:15Z

Add BLOB and CLOB for *Trafodion SQL Reference Manual*

commit bb6864a78d3922e6d313ce03528d4be25f6e0d88
Author: liu.yu 
Date:   2017-12-15T10:34:20Z

Remove redundancies




---

[GitHub] incubator-trafodion pull request #1344: TRAFODION-2844 add strategy to dcsse...

[kevinxu021]

Github user kevinxu021 commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1344#discussion_r157153197
  
--- Diff: dcs/src/main/java/org/trafodion/dcs/Constants.java ---
@@ -201,6 +201,12 @@
 /** Default value for user program restart handler retry interval 
millis */
 public static final int 
DEFAULT_DCS_SERVER_USER_PROGRAM_RESTART_HANDLER_RETRY_INTERVAL_MILLIS = 5000;
 
+/** Configuration key for user program restart handler retry interval 
millis */
+public static final String 
DCS_SERVER_USER_PROGRAM_RESTART_HANDLER_RETRY_INTERVAL_MINUTES = 
"dcs.server.user.program.restart.handler.retry.interval.minutes";
--- End diff --

I would suggest to be 
"dcs.server.user.program.restart.handler.retry.timeout.minutes"
Add this new setting into dcs-default.xml


---

[GitHub] incubator-trafodion pull request #1344: TRAFODION-2844 add strategy to dcsse...

[kevinxu021]

Github user kevinxu021 commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1344#discussion_r157155029
  
--- Diff: dcs/src/main/java/org/trafodion/dcs/server/ServerManager.java ---
@@ -242,7 +246,7 @@ private void cleanupZk() {
 zkc.delete(registeredPath, -1);
 } catch (Exception e) {
 e.printStackTrace();
-LOG.debug(e);
+LOG.error(e);
--- End diff --

 LOG.error(e.getMessage(), e);


---

[GitHub] incubator-trafodion pull request #1344: TRAFODION-2844 add strategy to dcsse...

[kevinxu021]

Github user kevinxu021 commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1344#discussion_r157166199
  
--- Diff: dcs/src/main/java/org/trafodion/dcs/util/RetryCounter.java ---
@@ -20,54 +20,79 @@
  */
 package org.trafodion.dcs.util;
 
+import java.util.LinkedList;
+import java.util.Queue;
 import java.util.concurrent.TimeUnit;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
 public class RetryCounter {
-  private static final Log LOG = LogFactory.getLog(RetryCounter.class);
-  private final int maxRetries;
-  private int retriesRemaining;
-  private final int retryIntervalMillis;
-  private final TimeUnit timeUnit;
+private static final Log LOG = LogFactory.getLog(RetryCounter.class);
+private final int maxRetries;
+private int retriesRemaining;
+private int retryInterval;
+private Queue queue;
 
-  public RetryCounter(int maxRetries, 
-  int retryIntervalMillis, TimeUnit timeUnit) {
-this.maxRetries = maxRetries;
-this.retriesRemaining = maxRetries;
-this.retryIntervalMillis = retryIntervalMillis;
-this.timeUnit = timeUnit;
-  }
+public RetryCounter(int maxRetries, int retryInterval) {
--- End diff --

Not very reasonable to remove last parameter.


---

[GitHub] incubator-trafodion pull request #1344: TRAFODION-2844 add strategy to dcsse...

[kevinxu021]

Github user kevinxu021 commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1344#discussion_r157156557
  
--- Diff: dcs/src/main/java/org/trafodion/dcs/server/ServerManager.java ---
@@ -242,7 +246,7 @@ private void cleanupZk() {
 zkc.delete(registeredPath, -1);
 } catch (Exception e) {
--- End diff --

Make the changes for the exception type which should be real exception 
instead of a general exception.


---

[GitHub] incubator-trafodion pull request #1349: TRAFODION-2848 hadoop-2.5 incompatib...

[gpj1987]

GitHub user gpj1987 opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1349

TRAFODION-2848 hadoop-2.5 incompatible with hive-1.1+



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gpj1987/incubator-trafodion TRAFODION-2848

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1349


commit 5d1d5b8764a399658ed6eab1bfa1a0ac1b0c7dc3
Author: gpj1987 
Date:   2017-12-15T09:39:02Z

TRAFODION-2848




---

[GitHub] incubator-trafodion pull request #1348: TRAFODION-2847 optimize dcs log form...

[gpj1987]

GitHub user gpj1987 opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1348

TRAFODION-2847 optimize dcs log format

previous logs look like

2017-12-14 05:31:11,417, INFO, org.trafodion.dcs.util.VersionInfo, Node 
Number: , CPU: , PIN: , Process Name: , , ,Dcs 2.3.0
2017-12-14 05:31:11,417, INFO, org.trafodion.dcs.util.VersionInfo, Node 
Number: , CPU: , PIN: , Process Name: , , ,Revision 1efa9db
2017-12-14 05:31:11,417, INFO, org.trafodion.dcs.util.VersionInfo, Node 
Number: , CPU: , PIN: , Process Name: , , ,Compiled by traf on Thu Dec 14 
05:30:52 UTC 2017
2017-12-14 05:31:12,544, INFO, org.trafodion.dcs.master.DcsMaster, Node 
Number: , CPU: , PIN: , Process Name: , , ,Connected to ZooKeeper


now logs look like

2017-12-14 10:52:21,056, [Thread-2], INFO, 
org.trafodion.dcs.util.VersionInfo.logVersion(VersionInfo.java:107), , ,Dcs 
2.3.0
2017-12-14 10:52:21,059, [Thread-2], INFO, 
org.trafodion.dcs.util.VersionInfo.logVersion(VersionInfo.java:107), , 
,Revision 1efa9db
2017-12-14 10:52:21,059, [Thread-2], INFO, 
org.trafodion.dcs.util.VersionInfo.logVersion(VersionInfo.java:107), , 
,Compiled by traf on Thu Dec 14 09:46:05 UTC 2017
2017-12-14 10:52:22,172, [Thread-2], INFO, 
org.trafodion.dcs.master.DcsMaster.run(DcsMaster.java:141), , ,Connected to 
ZooKeeper


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gpj1987/incubator-trafodion TRAFODION-2847

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1348






---