[GitHub] incubator-trafodion pull request: [TRAFODION-1647]Put unified copy...

2015-11-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/189


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-trafodion pull request: [TRAFODION-1647]Put unified copy...

2015-11-24 Thread hegdean
Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/189#discussion_r45822914
  
--- Diff: core/conn/trafci/build.xml ---
@@ -148,6 +148,8 @@
 


+   
+   
--- End diff --

The 2 new lines are redundant as the previous 2 lines (149 and 150) do the 
same thing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-trafodion pull request: [TRAFODION-1647]Put unified copy...

2015-11-24 Thread hegdean
Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/189#discussion_r45822943
  
--- Diff: core/conn/trafci/utils/trafci.sh ---
@@ -27,6 +27,8 @@
 #
 
 TRAFCI_CLASSPATH="##TRAFCI_CLASSPATH##"
+export TRAFODION_VER_PROD="##prodver##"
+export PRODUCT_COPYRIGHT_HEADER="##copyrighthdr##"
--- End diff --

How is ##prodver## being substituted?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---