[GitHub] incubator-trafodion pull request: [TRAFODION-1685]Fix catalog api ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1685]Fix catalog api ...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/236#discussion_r48210797
  
--- Diff: core/conn/jdbc_type2/native/SrvrSmd.cpp ---
@@ -357,6 +357,7 @@ void odbc_SQLSvc_GetSQLCatalogs_sme_(
}
 
SQLValue = (SQLValue_def *)outputValueList->_buffer;
+   /* //useless and doesn't be included in MXOS server
--- End diff --

Can we remove the code in comments?  Is there a reason why we need to keep 
it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1685]Fix catalog api ...

[kevinxu021]

GitHub user kevinxu021 opened a pull request:

https://github.com/apache/incubator-trafodion/pull/236

[TRAFODION-1685]Fix catalog api for getCatalog and getSchema



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kevinxu021/incubator-trafodion t21685

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #236


commit d5cd3383ac1e5d242adaf30c075f131583cadc45
Author: Kevin Xu 
Date:   2015-12-21T06:08:01Z

Fix catalog api for getCatalog and getSchema




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---