[GitHub] incubator-trafodion pull request: [TRAFODION-1982] Package server ...

[svarnau]

Github user svarnau commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/476#discussion_r62778733
  
--- Diff: core/conn/Makefile ---
@@ -25,16 +25,17 @@ include ../macros.gmk #top level
 
 RM  = /bin/rm
 ifeq ($(SQ_BUILD_TYPE),release)
-  CLIENT_TAR   ?= 
../../${DISTRIBUTION_DIR}/trafodion_clients-$(TRAFODION_VER).tgz
+  CLIENT_TAR   ?= 
../../${DISTRIBUTION_DIR}/apache-trafodion_clients-$(TRAFODION_VER)-incubating.tar.gz
--- End diff --

Unfortunately, that variable value is not the right value for a file name. 
I suppose we could add yet another variable, but that does not seem necessary 
for packaging name in 2-3 spots.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1982] Package server ...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/476#discussion_r62778376
  
--- Diff: core/conn/Makefile ---
@@ -25,16 +25,17 @@ include ../macros.gmk #top level
 
 RM  = /bin/rm
 ifeq ($(SQ_BUILD_TYPE),release)
-  CLIENT_TAR   ?= 
../../${DISTRIBUTION_DIR}/trafodion_clients-$(TRAFODION_VER).tgz
+  CLIENT_TAR   ?= 
../../${DISTRIBUTION_DIR}/apache-trafodion_clients-$(TRAFODION_VER)-incubating.tar.gz
 else
-  CLIENT_TAR   ?= 
../../${DISTRIBUTION_DIR}/trafodion_clients-$(TRAFODION_VER)-debug.tgz
+  CLIENT_TAR   ?= 
../../${DISTRIBUTION_DIR}/apache-trafodion_clients-$(TRAFODION_VER)-debug.tar.gz
--- End diff --

can we use TRAFODION_VER_PROD


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1982] Package server ...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/476#discussion_r62778320
  
--- Diff: core/conn/Makefile ---
@@ -25,16 +25,17 @@ include ../macros.gmk #top level
 
 RM  = /bin/rm
 ifeq ($(SQ_BUILD_TYPE),release)
-  CLIENT_TAR   ?= 
../../${DISTRIBUTION_DIR}/trafodion_clients-$(TRAFODION_VER).tgz
+  CLIENT_TAR   ?= 
../../${DISTRIBUTION_DIR}/apache-trafodion_clients-$(TRAFODION_VER)-incubating.tar.gz
--- End diff --

Instead of hard coding(apache_trafodion) can we use the environment 
variable TRAFODION_VER_PROD


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1982] Package server ...

[svarnau]

GitHub user svarnau opened a pull request:

https://github.com/apache/incubator-trafodion/pull/476

[TRAFODION-1982] Package server components into single tar

This pull request includes Amanda's changes [TRAFODION-1985] for installer 
to take a single tar, which also addresses the issue of looking for a 
build-version.txt file in the tar-of-tars.

This changes the historical tar-of-tars packaging from the days when DCS 
and REST where built separately from the core server component (even separate 
repos). This aligns with other Apache project packaging where there is a 
LICENSE, NOTICE file at the root of each tar-file deliverable. We need a single 
deliverable for server-side.

The build will also now name tar-files as the Apache artifacts are normally 
named.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/incubator-trafodion pkg1982

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #476


commit c8ef96457e45441f4853a187237b4149d9058bd5
Author: Steve Varnau 
Date:   2016-05-10T18:03:23Z

[TRAFODION-1982] Combine server components into single tar file

Now bundle DCS and REST components into server binary tar file.

The license & notice file info for REST and DCS are subsumed into
server license files.

Fix naming of server and client tar files to meet Apache artifact
naming practices.

commit 10adf4b56251543ac73705e3ecc61e1646e37ead
Author: Amanda Moran 
Date:   2016-05-10T22:49:36Z

Fixes for TRAFODION-1985

commit c861ea9e8f34a48056d74ee28a87791168af9c3f
Author: Steve Varnau 
Date:   2016-05-10T23:00:52Z

Merge remote branch 'amanda/TRAFODION-1985' into pkg1982




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---