[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/274


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r51331627
  
--- Diff: install/installer/traf_config_setup ---
@@ -528,7 +555,7 @@ echo "export 
DCS_PRIMARY_MASTER_NODE=\"$DCS_PRIMARY_MASTER_NODE\"" >> $LOCAL_TRA
 #==
 #Enable HA
 
-echo -n "Enable High Availability (Y/N), default is N: "
+echo -n "Enable High Avalability (Y/N), default is N: "
--- End diff --

Typo for Availability


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r51333079
  
--- Diff: install/installer/trafodion_install ---
@@ -718,7 +761,7 @@ if [[ "$LDAP_SECURITY" == "Y" ]]; then
   $TRAF_PDSH sudo chmod 750 $HOME_DIR/$TRAF_USER/$LDAP_AUTH_FILE
   if [[ $LDAP_LEVEL == "2" ]] || [[ $LDAP_LEVEL == "1" ]]; then
  echo "***INFO: Copying $LDAP_CERT to Trafodion home dir"
- $TRAF_PDCP $LDAP_CERT $HOME
+ $TRAF_PCP $LDAP_CERT $HOME
--- End diff --

This should be TRAF_PDCP


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r51036587
  
--- Diff: install/installer/traf_config_setup ---
@@ -211,7 +215,7 @@ fi
 #==
 # List of Nodes
 
-echo -n "Enter list of nodes (blank separated), default [$NODE_LIST]: "
+echo -n "Enter list of Trafodion nodes (blank separated), default 
[$NODE_LIST]: "
--- End diff --

Changed in next check in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r51036637
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
--- End diff --

Changed in next check in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r51039567
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
+read answer
+ 
+if [ -z $answer ]; then
+  echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
+else
+  if [[ "${answer}" =~ ^[Yy]$ ]]; then
+ echo "export MANAGE_ENABLED=\"Y\"" >> $LOCAL_TRAF_CONFIG
+ #List of Management Nodes
+ echo -n "Enter list management nodes (blank separated), default 
[$MANAGE_NODES]: "
+ read answer
+ if [[ -z "$answer" ]]; then
+if [ -z "$MANAGE_NODES" ]; then
+   echo "***ERROR: Must enter list of management nodes."
+   exit -1
+fi
+ else
+MANAGE_NODES="$answer"
--- End diff --

Fixed everywhere. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r51039863
  
--- Diff: install/installer/traf_config_setup ---
@@ -678,7 +708,7 @@ if [[ $SCANNER_MODE == "N" ]]; then
   read answer4
   if [[ -z "$answer4" ]]; then
  if [ -z "$LDAP_LEVEL" ]; then
-echo "***ERROR: Must enter LDAP Encryption level."
+echo "***ERROR: Much enter LDAP Encryption level."
--- End diff --

Done for next check in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r51040041
  
--- Diff: install/installer/traf_getHadoopNodes ---
@@ -31,20 +29,22 @@ echo "***INFO: Getting list of all $HADOOP_TYPE nodes"
 
 curlRC=0
 if [[ $HADOOP_TYPE == "cloudera" ]]; then
-   curl -su $ADMIN:$PASSWORD http://$URL/api/v6/cm/deployment > tempFile
+   curl -k -su $ADMIN:$PASSWORD $URL/api/v10/hosts > tempFile
curlRC=$?
--- End diff --

It is being used a few lines down. 

if [ $curlRC != 0 ]; then
   echo "***ERROR: Unable to get list of hosts from $HADOOP_TYPE 
(RC=$curlRC)"
   echo "***ERROR: curl command failed."
   exit -1
fi



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r51039231
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
+read answer
+ 
+if [ -z $answer ]; then
+  echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
+else
+  if [[ "${answer}" =~ ^[Yy]$ ]]; then
+ echo "export MANAGE_ENABLED=\"Y\"" >> $LOCAL_TRAF_CONFIG
+ #List of Management Nodes
+ echo -n "Enter list management nodes (blank separated), default 
[$MANAGE_NODES]: "
+ read answer
+ if [[ -z "$answer" ]]; then
+if [ -z "$MANAGE_NODES" ]; then
+   echo "***ERROR: Must enter list of management nodes."
--- End diff --

Done for next check in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r51039497
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
+read answer
+ 
+if [ -z $answer ]; then
+  echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
+else
+  if [[ "${answer}" =~ ^[Yy]$ ]]; then
+ echo "export MANAGE_ENABLED=\"Y\"" >> $LOCAL_TRAF_CONFIG
+ #List of Management Nodes
+ echo -n "Enter list management nodes (blank separated), default 
[$MANAGE_NODES]: "
+ read answer
+ if [[ -z "$answer" ]]; then
+if [ -z "$MANAGE_NODES" ]; then
+   echo "***ERROR: Must enter list of management nodes."
+   exit -1
+fi
+ else
+MANAGE_NODES="$answer"
+ fi
+
+ echo "export MANAGE_NODES=\"$MANAGE_NODES\"" >> $LOCAL_TRAF_CONFIG
+  else
+ echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
--- End diff --

Done for next check in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50915415
  
--- Diff: install/installer/traf_sqgen ---
@@ -0,0 +1,96 @@
+#!/bin/bash
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+export TRAF_CONFIG=/etc/trafodion/trafodion_config
+
+source $TRAF_CONFIG
+
+STARTING_NODE=$(hostname)
+
+#==
+echo "***INFO: starting sqgen" | tee -a $INSTALL_LOG
+cd $SQ_ROOT/sql/scripts
+$SQ_ROOT/sql/scripts/sqgen
+SQGEN_RC=$?
+if [ "$SQGEN_RC" != "0" ]; then
+echo "***ERROR: sqgen failed with RC=$SQGEN_RC. Check install log file 
for details." | tee -a $INSTALL_LOG
+exit -1;
+fi
+#==
+
+if [ "$node_count" -ne "1" ]; then
+echo "***INFO: copying $HOME/sqcert directory to all nodes" | tee -a 
$INSTALL_LOG
+$PDCP $ALL_NODES -x $HOSTNAME -r $HOME/sqcert $HOME
+fi
+
+#==
+
+if [ "$all_node_count" -ne "1" ]; then
+   echo "***INFO: copying install to all nodes" | tee -a $INSTALL_LOG
+   $PDCP $ALL_NODES -x $HOSTNAME -r $SQ_ROOT $SQ_ROOT/..
+
+   if [ "$?" != "0" ]; then
+  echo "***ERROR: Unable to copy Trafodion install to all machines in 
this cluster.  Check install log files for details." | tee -a $INSTALL_LOG
+  exit -1;
+   fi
+fi
+
+#=
+#Copying traf_authentication_conf to scripts directory
+if [[ "$LDAP_SECURITY" == "Y" ]]; then
+   if [ "$all_node_count" -ne "1" ]; then
+  echo "***INFO: Copying $LDAP_AUTH_FILE to all nodes" | tee -a 
$INSTALL_LOG
+  $PDCP $ALL_NODES -r $HOME/$LDAP_AUTH_FILE 
$SQ_ROOT/sql/scripts/traf_authentication_config
+  if [ "$?" != "0" ]; then
+echo "***ERROR: Unable to copy $LDAP_AUTH_FILE to all machines in 
this cluster.  Check install log files for details." | tee -a $INSTALL_LOG
+ exit -1;
+  fi
+   else
+  echo "***INFO: Copying $LDAP_AUTH_FILE to scripts directory." | tee 
-a $INSTALL_LOG
+  cp -rf $HOME_DIR/$TRAF_USER/$LDAP_AUTH_FILE 
$SQ_ROOT/sql/scripts/traf_authentication_config
+   fi
+
+   #Check traf_authentication_config for errors
+   echo "***INFO: Checking LDAP Configuration file for errors."
+   ldapconfigcheck -file $SQ_ROOT/sql/scripts/traf_authentication_config
+   if [ "$?" != "0" ]; then
+  echo "***ERROR: traf_authentication_config not configured correctly."
+  echo "***ERROR: Install will continue WITHOUT simple security turned 
on."
+  echo "***ERROR: Please review wiki for manual steps to setup simple 
security."
+   else
+  if [[ $LDAP_LEVEL == "1" ]]; then
+ echo "TLS_CACERT $HOME/$LDAP_CERT_BASE" > 
$HOME_DIR/$TRAF_USER/.ldaprc
+ echo "TLS_REQCERT demand" >> $HOME_DIR/$TRAF_USER/.ldaprc
+  fi
+  echo "***INFO: Enabling security. Running traf_authentication_setup"
+  ssh $STARTING_NODE "cd $MY_SQROOT/sql/scripts; 
traf_authentication_setup --setup --file traf_authentication_config"
+
+  if [[ $? != "0" ]]; then
+ echo "***WARNING: Error during script traf_authentication_setup"
+ echo "***WARNING: Install will continue WITHOUT simple security 
turned on."
+ echo "***WARNING: Please review wiki for manual steps to setup 
simple security."
--- End diff --

Because security can be enabled after the installation, the install should 
continue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50915377
  
--- Diff: install/installer/traf_sqgen ---
@@ -0,0 +1,96 @@
+#!/bin/bash
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+export TRAF_CONFIG=/etc/trafodion/trafodion_config
+
+source $TRAF_CONFIG
+
+STARTING_NODE=$(hostname)
+
+#==
+echo "***INFO: starting sqgen" | tee -a $INSTALL_LOG
+cd $SQ_ROOT/sql/scripts
+$SQ_ROOT/sql/scripts/sqgen
+SQGEN_RC=$?
+if [ "$SQGEN_RC" != "0" ]; then
+echo "***ERROR: sqgen failed with RC=$SQGEN_RC. Check install log file 
for details." | tee -a $INSTALL_LOG
+exit -1;
+fi
+#==
+
+if [ "$node_count" -ne "1" ]; then
+echo "***INFO: copying $HOME/sqcert directory to all nodes" | tee -a 
$INSTALL_LOG
+$PDCP $ALL_NODES -x $HOSTNAME -r $HOME/sqcert $HOME
+fi
+
+#==
+
+if [ "$all_node_count" -ne "1" ]; then
+   echo "***INFO: copying install to all nodes" | tee -a $INSTALL_LOG
+   $PDCP $ALL_NODES -x $HOSTNAME -r $SQ_ROOT $SQ_ROOT/..
+
+   if [ "$?" != "0" ]; then
+  echo "***ERROR: Unable to copy Trafodion install to all machines in 
this cluster.  Check install log files for details." | tee -a $INSTALL_LOG
+  exit -1;
+   fi
+fi
+
+#=
+#Copying traf_authentication_conf to scripts directory
+if [[ "$LDAP_SECURITY" == "Y" ]]; then
+   if [ "$all_node_count" -ne "1" ]; then
+  echo "***INFO: Copying $LDAP_AUTH_FILE to all nodes" | tee -a 
$INSTALL_LOG
+  $PDCP $ALL_NODES -r $HOME/$LDAP_AUTH_FILE 
$SQ_ROOT/sql/scripts/traf_authentication_config
+  if [ "$?" != "0" ]; then
+echo "***ERROR: Unable to copy $LDAP_AUTH_FILE to all machines in 
this cluster.  Check install log files for details." | tee -a $INSTALL_LOG
+ exit -1;
+  fi
+   else
+  echo "***INFO: Copying $LDAP_AUTH_FILE to scripts directory." | tee 
-a $INSTALL_LOG
+  cp -rf $HOME_DIR/$TRAF_USER/$LDAP_AUTH_FILE 
$SQ_ROOT/sql/scripts/traf_authentication_config
+   fi
+
+   #Check traf_authentication_config for errors
+   echo "***INFO: Checking LDAP Configuration file for errors."
+   ldapconfigcheck -file $SQ_ROOT/sql/scripts/traf_authentication_config
+   if [ "$?" != "0" ]; then
+  echo "***ERROR: traf_authentication_config not configured correctly."
+  echo "***ERROR: Install will continue WITHOUT simple security turned 
on."
+  echo "***ERROR: Please review wiki for manual steps to setup simple 
security."
--- End diff --

Because security can be enabled after the installation, the install should 
continue. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50924204
  
--- Diff: install/installer/traf_sqgen ---
@@ -0,0 +1,96 @@
+#!/bin/bash
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+export TRAF_CONFIG=/etc/trafodion/trafodion_config
+
+source $TRAF_CONFIG
+
+STARTING_NODE=$(hostname)
+
+#==
+echo "***INFO: starting sqgen" | tee -a $INSTALL_LOG
+cd $SQ_ROOT/sql/scripts
+$SQ_ROOT/sql/scripts/sqgen
+SQGEN_RC=$?
+if [ "$SQGEN_RC" != "0" ]; then
+echo "***ERROR: sqgen failed with RC=$SQGEN_RC. Check install log file 
for details." | tee -a $INSTALL_LOG
+exit -1;
+fi
+#==
+
+if [ "$node_count" -ne "1" ]; then
+echo "***INFO: copying $HOME/sqcert directory to all nodes" | tee -a 
$INSTALL_LOG
+$PDCP $ALL_NODES -x $HOSTNAME -r $HOME/sqcert $HOME
+fi
+
+#==
+
+if [ "$all_node_count" -ne "1" ]; then
--- End diff --

No it can't. I tested it out. See comment above. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50443958
  
--- Diff: install/installer/dcs_installer ---
@@ -196,8 +194,6 @@ echo $DCS_PRIMARY_MASTER_NODE > $DCS_DIR/conf/master
 
 
 if [[ "$ENABLE_HA" == "true" ]]; then
-
-   ##Configure dcs-site.xml file
--- End diff --

can you put back the comments in this file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50444726
  
--- Diff: install/installer/traf_add_sudoAccess ---
@@ -23,12 +23,12 @@
 TRAF_CONFIG=/etc/trafodion/trafodion_config
 source $TRAF_CONFIG
 
-if [ $node_count -eq 1 ]; then
+if [ $all_node_count -eq 1 ]; then
 TRAF_PDSH=""
 TRAF_PDCP=""
 else
-TRAF_PDSH="pdsh -R exec $MY_NODES $PDSH_SSH_CMD"
-TRAF_PDCP="pdcp -R ssh $MY_NODES"
+TRAF_PDSH="pdsh -R exec $ALL_NODES $PDSH_SSH_CMD"
+TRAF_PDCP="pdcp -R ssh $ALL_NODES"
 fi
--- End diff --

Can generalize the TRAF_PDSH and TRAF_PDCP environment variables in the 
config file that is sourced in.  Then these conditional checks for setting them 
can be removed from each script


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50451782
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
+read answer
+ 
+if [ -z $answer ]; then
+  echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
+else
+  if [[ "${answer}" =~ ^[Yy]$ ]]; then
+ echo "export MANAGE_ENABLED=\"Y\"" >> $LOCAL_TRAF_CONFIG
+ #List of Management Nodes
+ echo -n "Enter list management nodes (blank separated), default 
[$MANAGE_NODES]: "
+ read answer
+ if [[ -z "$answer" ]]; then
+if [ -z "$MANAGE_NODES" ]; then
+   echo "***ERROR: Must enter list of management nodes."
+   exit -1
+fi
+ else
+MANAGE_NODES="$answer"
--- End diff --

Should be MANAGEMENT_NODES instead of MANAGE_NODES. Should fix all files 
where this is referenced


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50466634
  
--- Diff: install/installer/traf_sqgen ---
@@ -0,0 +1,96 @@
+#!/bin/bash
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+export TRAF_CONFIG=/etc/trafodion/trafodion_config
+
+source $TRAF_CONFIG
+
+STARTING_NODE=$(hostname)
+
+#==
+echo "***INFO: starting sqgen" | tee -a $INSTALL_LOG
+cd $SQ_ROOT/sql/scripts
+$SQ_ROOT/sql/scripts/sqgen
+SQGEN_RC=$?
+if [ "$SQGEN_RC" != "0" ]; then
+echo "***ERROR: sqgen failed with RC=$SQGEN_RC. Check install log file 
for details." | tee -a $INSTALL_LOG
+exit -1;
+fi
+#==
+
+if [ "$node_count" -ne "1" ]; then
--- End diff --

Should this now be all_node_count instead of node_count?

 It would have been better if node_count was assigned all_node_count  and 
MY_NODES was assigned ALL_NODES. That way changes could be kept to  minimal


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50466851
  
--- Diff: install/installer/traf_sqgen ---
@@ -0,0 +1,96 @@
+#!/bin/bash
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+export TRAF_CONFIG=/etc/trafodion/trafodion_config
+
+source $TRAF_CONFIG
+
+STARTING_NODE=$(hostname)
+
+#==
+echo "***INFO: starting sqgen" | tee -a $INSTALL_LOG
+cd $SQ_ROOT/sql/scripts
+$SQ_ROOT/sql/scripts/sqgen
+SQGEN_RC=$?
+if [ "$SQGEN_RC" != "0" ]; then
+echo "***ERROR: sqgen failed with RC=$SQGEN_RC. Check install log file 
for details." | tee -a $INSTALL_LOG
+exit -1;
+fi
+#==
+
+if [ "$node_count" -ne "1" ]; then
+echo "***INFO: copying $HOME/sqcert directory to all nodes" | tee -a 
$INSTALL_LOG
+$PDCP $ALL_NODES -x $HOSTNAME -r $HOME/sqcert $HOME
+fi
+
+#==
+
+if [ "$all_node_count" -ne "1" ]; then
--- End diff --

Is this check required ? can the pdcp step be incorporated in the previous 
conditional check itself?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50451279
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
+read answer
+ 
+if [ -z $answer ]; then
+  echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
+else
+  if [[ "${answer}" =~ ^[Yy]$ ]]; then
+ echo "export MANAGE_ENABLED=\"Y\"" >> $LOCAL_TRAF_CONFIG
+ #List of Management Nodes
+ echo -n "Enter list management nodes (blank separated), default 
[$MANAGE_NODES]: "
+ read answer
+ if [[ -z "$answer" ]]; then
+if [ -z "$MANAGE_NODES" ]; then
+   echo "***ERROR: Must enter list of management nodes."
--- End diff --

Can we update the message as "Management nodes must be specified."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50449380
  
--- Diff: install/installer/traf_config_setup ---
@@ -211,7 +215,7 @@ fi
 #==
 # List of Nodes
 
-echo -n "Enter list of nodes (blank separated), default [$NODE_LIST]: "
+echo -n "Enter list of Trafodion nodes (blank separated), default 
[$NODE_LIST]: "
--- End diff --

Do we want to call this Trafodion nodes or data nodes: ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50449749
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
--- End diff --

Should this question be "Do you have a set of management nodes (Y/N), 
default is N:"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50451389
  
--- Diff: install/installer/traf_config_setup ---
@@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
 node_count=$(echo $NODE_LIST | wc -w)
 
 #==
+echo -n "Are management nodes enabled (Y/N), default is N: "
+read answer
+ 
+if [ -z $answer ]; then
+  echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
+else
+  if [[ "${answer}" =~ ^[Yy]$ ]]; then
+ echo "export MANAGE_ENABLED=\"Y\"" >> $LOCAL_TRAF_CONFIG
+ #List of Management Nodes
+ echo -n "Enter list management nodes (blank separated), default 
[$MANAGE_NODES]: "
+ read answer
+ if [[ -z "$answer" ]]; then
+if [ -z "$MANAGE_NODES" ]; then
+   echo "***ERROR: Must enter list of management nodes."
+   exit -1
+fi
+ else
+MANAGE_NODES="$answer"
+ fi
+
+ echo "export MANAGE_NODES=\"$MANAGE_NODES\"" >> $LOCAL_TRAF_CONFIG
+  else
+ echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
--- End diff --

can be removed if default value is initialized


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50452962
  
--- Diff: install/installer/traf_config_setup ---
@@ -544,9 +574,9 @@ fi
 echo "export ENABLE_HA=\"$ENABLE_HA\"" >> $LOCAL_TRAF_CONFIG
 
 #==
-#Get the floating IP address, interface name and the list of backup nodes 
to be used 
--- End diff --

can you put back this comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/274#discussion_r50453726
  
--- Diff: install/installer/traf_getHadoopNodes ---
@@ -31,20 +29,22 @@ echo "***INFO: Getting list of all $HADOOP_TYPE nodes"
 
 curlRC=0
 if [[ $HADOOP_TYPE == "cloudera" ]]; then
-   curl -su $ADMIN:$PASSWORD http://$URL/api/v6/cm/deployment > tempFile
+   curl -k -su $ADMIN:$PASSWORD $URL/api/v10/hosts > tempFile
curlRC=$?
--- End diff --

Looks like curlRC is not being used here, can be removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Many bug fixes for Installer. Al...

[amandamoran]

GitHub user amandamoran opened a pull request:

https://github.com/apache/incubator-trafodion/pull/274

Many bug fixes for Installer. All JIRA's listed.

TRAFODION-1545 Adding Management nodes
TRAFODION-1691 Smaller subscripts
Trafodion-1681 need full HADOOP path for hdfs
Trafodion-1689 DCS HA
Trafodion-1756 kernel.pid_max persistent on reboot
Trafodion-1694 kernel.pid_max full path
Trafodion-1693 CLUSTERNAME being set
Trafodion-1574 increasing maintainability of scripts
Trafodion-1711 curl commands should accept http/https
Trafodion-1478 Create /hbase/archive/data/default

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/amandamoran/incubator-trafodion 
installbugfixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #274


commit ee4c25397f647805c112ffdec55bd9c24a30a432
Author: Amanda Moran 
Date:   2016-01-20T23:54:05Z

Many bug fixes. All JIRAs listed below.

TRAFODION-1545 Adding Management nodes
TRAFODION-1691 Smaller subscripts
Trafodion-1681 Need full HADOOP path for hdfs
Trafodion-1689 DCS HA
Trafodion-1756 kernel.pid_max persistent on reboot
Trafodion-1694 kernel.pid_max full path
Trafodion-1693 CLUSTERNAME being set
Trafodion-1574 Increasing maintainability of scripts
Trafodion-1711 curl commands should accept http/https
Trafodion-1478 Create /hbase/archive/data/default




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---