[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/418#discussion_r60111097
  
--- Diff: core/sqf/sqenvcom.sh ---
@@ -505,23 +505,6 @@ EOF
   APACHE_HIVE_HOME=$HIVE_HOME
   export HIVE_CNF_DIR=$HIVE_HOME/conf
 
--- End diff --

Agree. It is good to remove this code, it proved not to be useful. I had 
the idea at some time to figure out the install directories for Hadoop, HBase 
etc. by examining the CLASSPATH, but that method caused more trouble than good. 
(in part because of the use of symbolic links, I think).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[svarnau]

Github user svarnau commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/418#discussion_r59634999
  
--- Diff: core/sqf/sqenvcom.sh ---
@@ -505,23 +505,6 @@ EOF
   APACHE_HIVE_HOME=$HIVE_HOME
   export HIVE_CNF_DIR=$HIVE_HOME/conf
 
--- End diff --

I think not, since the local_hadoop case is the first case in this far 
above (line262).  The else case seems to be for vanilla hadoop or the 
build-only case when there is no distro at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/418#discussion_r59632384
  
--- Diff: core/sqf/sqenvcom.sh ---
@@ -505,23 +505,6 @@ EOF
   APACHE_HIVE_HOME=$HIVE_HOME
   export HIVE_CNF_DIR=$HIVE_HOME/conf
 
--- End diff --

@zellerh 

Hans- Could you comment on removing this bit of code? I just want to make 
sure it isn't something thats needed for install_local_hadoop. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mkby]

Github user mkby commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/418#discussion_r58813434
  
--- Diff: install/installer/traf_config_setup ---
@@ -407,57 +412,131 @@ else
 fi
 
 #==
-#Hadoop user name
-
-echo -n "Enter Hadoop admin username, default is [$ADMIN]: "
+#HADOOP_TYPE
+echo -n "Enter installed hadoop type: cloudera, hortonworks, vanilla, 
default is [$HADOOP_TYPE]: "
--- End diff --

suggest to ask user only Y or N , select Y if they want to install 
trafodion on vanilla hadoop


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mashengchen]

GitHub user mashengchen opened a pull request:

https://github.com/apache/incubator-trafodion/pull/418

TRAFODION-1706

now user can use "trafodion_install" to install trafodion who had installed 
vanilla apache hadoop and hbase.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mashengchen/incubator-trafodion master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #418


commit 0dbf1d1bc8718990850b4cff6e5f955a213209ae
Author: mashengchen 
Date:   2016-04-05T03:03:48Z

Trafodion building troubles

commit c0b3136c6e29afc97d299cfc3407df7093a20060
Author: mashengchen 
Date:   2016-04-05T03:07:20Z

Merge branch 'master' of github.com:mashengchen/incubator-trafodion

commit 897ea4b4013e55c691ffabb84fef804c7a623bf8
Author: mashengchen 
Date:   2016-04-05T03:09:01Z

Merge pull request #13 from apache/master

update head

commit 674f1cf54052fc5abba37eb3f65a4462c860f607
Author: root 
Date:   2016-04-06T09:52:14Z

support vanilla apache

commit c505fcea152db153d8197df22253a6914f21a4fd
Author: mashengchen 
Date:   2016-04-06T09:58:08Z

Update install_local_hadoop

commit 509fa69f3428926482b2c95c334d4530d3ca3148
Author: mashengchen 
Date:   2016-04-06T09:58:46Z

Merge pull request #14 from apache/master

update head




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1706] Update executor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/411


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1706] Update executor...

[DaveBirdsall]

GitHub user DaveBirdsall opened a pull request:

https://github.com/apache/incubator-trafodion/pull/411

[TRAFODION-1706] Update executor/TEST020 expected results

I noticed that the regression test executor/TEST020 was failing this 
morning. It might have been due to last night's merge of #367 but this is not 
certain. In any case, this will fix it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaveBirdsall/incubator-trafodion 
FixRegressions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/411.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #411


commit ff76b2a686ae3087165976dee0ab6ff7853f6ffa
Author: Dave Birdsall 
Date:   2016-04-01T20:24:13Z

[TRAFODION-1706] Update executor/TEST020 expected results




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/367


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mkby]

Github user mkby commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/367#discussion_r55384539
  
--- Diff: core/sqf/sqenvcom.sh ---
@@ -140,18 +139,41 @@ fi
 export MY_SQROOT=$PWD
 export SQ_HOME=$PWD
 
+# set common version to be consistent between shared lib and maven 
dependencies
+export HBASE_DEP_VER_CDH=1.0.0-cdh5.4.4
+export HIVE_DEP_VER_CDH=1.1.0-cdh5.4.4
+export HBASE_DEP_VER_HDP=1.1.2.2.3.2.0-2950
+export HIVE_DEP_VER_HDP=1.2.1.2.3.2.0-2950
+export HBASE_DEP_VER_APACHE=1.0.2
+export HIVE_DEP_VER_APACHE=1.1.0
+export THRIFT_DEP_VER=0.9.0
+export HBASE_TRX_ID_CDH=hbase-trx-cdh5_4
+export HBASE_TRX_ID_APACHE=hbase-trx-apache1_0_2
+export HBASE_TRX_ID_HDP=hbase-trx-hdp2_3
+
 # general Hadoop & TRX dependencies - not distro specific, choose one to 
build against
 export HBASE_TRXDIR=$MY_SQROOT/export/lib
-export HBASE_TRX_ID=hbase-trx-cdh5_3
-export HBASE_DEP_VER=0.98.6-cdh5.3.0
-export HBASE_TRX_JAR=${HBASE_TRX_ID}-${TRAFODION_VER}.jar
-export UTIL_JAR=trafodion-utility-${TRAFODION_VER}.jar
-if [[ "$SQ_HBASE_DISTRO" = "HDP" ]]; then
-export HBASE_TRX_JAR=hbase-trx-hdp2_2-${TRAFODION_VER}.jar
+export HBASE_TRX_JAR=${HBASE_TRX_ID_CDH}-${TRAFODION_VER}.jar
+if [[ "$HBASE_DISTRO" = "HDP" ]]; then
+export HBASE_TRX_JAR=${HBASE_TRX_ID_HDP}-${TRAFODION_VER}.jar
 fi
-# set common version to be consistent between shared lib and maven 
dependencies
-export THRIFT_DEP_VER=0.9.0
-export HIVE_DEP_VER=0.13.1
+if [[ "$HBASE_DISTRO" = "APACHE" ]]; then
+export HBASE_TRX_JAR=${HBASE_TRX_ID_APACHE}-${TRAFODION_VER}.jar
--- End diff --

If using Apache Hadoop, the script will detect the system as an Apache 
Hadoop environment, so it will jump to line 487, and check line 618, the script 
will ``export HBASE_TRX_JAR=hbase-trx-hbase_98_4-${TRAFODION_VER}.jar``, will 
this overwrite the ``HBASE_TRX_JAR`` you set here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[amandamoran]

Github user amandamoran commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54935909
  
--- Diff: core/sqf/sqenvcom.sh ---
@@ -284,6 +297,8 @@ elif [[ -d /opt/cloudera/parcels/CDH ]]; then
   export CURL_INC_DIR=/usr/include
   export CURL_LIB_DIR=/usr/lib64
 
+  lv_hbase_cp=`hbase classpath`
--- End diff --

This will need to be set for Cloudera packages install as well. 

Add lv_hbase_cp=`hbase classpath` after elif [[ -n "$(ls 
/usr/lib/hadoop/hadoop-*cdh*.jar 2>/dev/null)" ]]; then
(around line 340). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mashengchen]

Github user mashengchen commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54833403
  
--- Diff: core/sql/pom.xml.apache ---
@@ -0,0 +1,131 @@
+
--- End diff --

no idea to use one pom.xml, we have to make 3 version (vanilla,cdh,hdp), so 
have to use three pom.xml


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mashengchen]

Github user mashengchen commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54833294
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/TrxTransactionState.java.tmpl
 ---
@@ -77,96 +94,29 @@
  * Holds the state of a transaction. This includes a buffer of all writes, 
a record of all reads / scans, and
  * information about which other transactions we need to check against.
  */
-public class TrxTransactionState  extends TransactionState{
-
-static boolean sb_sqm_98_1 = false;
-static boolean sb_sqm_98_4 = false;
-static boolean sb_sqm_98_9 = false;
-static java.lang.reflect.Constructor c98_1 = null;
-static java.lang.reflect.Constructor c98_4 = null;
-static java.lang.reflect.Constructor c98_9 = null;
+public class TrxTransactionState extends TransactionState {
 
-static Class keepDeletedCellsClazz = null;
-static Class scaninfoClazz = null;
-static Constructor scaninfoConstructor = null;
-static Object[] scaninfoArgs = null;
+static java.lang.reflect.Constructor c1_0 = null;
 
 static {
 String version = VersionInfo.getVersion();// the hbase version 
string, eg. "0.6.3-dev"
 LOG.info("Got info of Class ScanQueryMatcher for HBase version :" 
+ version);
-
--- End diff --

i don't think there will happen this rid.. cause we have a 1.3 branch to 
support backward version(hbase 0.98)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[selvaganesang]

Github user selvaganesang commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54829734
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/TrxTransactionState.java.tmpl
 ---
@@ -77,96 +94,29 @@
  * Holds the state of a transaction. This includes a buffer of all writes, 
a record of all reads / scans, and
  * information about which other transactions we need to check against.
  */
-public class TrxTransactionState  extends TransactionState{
-
-static boolean sb_sqm_98_1 = false;
-static boolean sb_sqm_98_4 = false;
-static boolean sb_sqm_98_9 = false;
-static java.lang.reflect.Constructor c98_1 = null;
-static java.lang.reflect.Constructor c98_4 = null;
-static java.lang.reflect.Constructor c98_9 = null;
+public class TrxTransactionState extends TransactionState {
 
-static Class keepDeletedCellsClazz = null;
-static Class scaninfoClazz = null;
-static Constructor scaninfoConstructor = null;
-static Object[] scaninfoArgs = null;
+static java.lang.reflect.Constructor c1_0 = null;
 
 static {
 String version = VersionInfo.getVersion();// the hbase version 
string, eg. "0.6.3-dev"
 LOG.info("Got info of Class ScanQueryMatcher for HBase version :" 
+ version);
-
--- End diff --

Are we getting rid of the backward compatibility here by removing this code.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54829297
  
--- Diff: core/sql/pom.xml.apache ---
@@ -0,0 +1,131 @@
+
--- End diff --

Rather than having multiple pom.xml files, could we use profiles in a 
single pom.xml? Just asking, I can imagine very well that it won't work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54828709
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/TrxTransactionState.java.tmpl
 ---
@@ -21,15 +21,27 @@
 * @@@ END COPYRIGHT @@@
 **/
 
+/**
--- End diff --

...and here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54828604
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/MemoryUsageChore.java.tmpl
 ---
@@ -21,6 +21,16 @@
 * @@@ END COPYRIGHT @@@
 **/
 
+/**
--- End diff --

Same here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54828151
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -579,17 +591,15 @@ fi
 #
 
 # See JIRA TRAFODION-1512 that will eliminate this check
-if [ -d $MY_LOCAL_SW_DIST ]; then
   
-  HADOOP_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
-  HADOOP_TAR=hadoop-2.5.0-cdh5.3.0.tar.gz
-else
-  
HADOOP_MIRROR_URL=http://download.nextag.com/apache/hadoop/common/hadoop-2.5.2
-  HADOOP_TAR=hadoop-2.5.2.tar.gz
-fi
+HADOOP_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
+HADOOP_TAR=hadoop-2.6.0-cdh5.4.4.tar.gz
 
-if [[ "$SQ_HBASE_DISTRO" = "HDP" ]]; then
-HADOOP_TAR=hadoop-2.6.0.2.2.0.0-2041.tar.gz
+if [[ "$HBASE_DISTRO" = "HDP" ]]; then
+HADOOP_TAR=hadoop-2.7.1.2.3.2.0-2950.tar.gz
--- End diff --

Yes, but this is optional. It also should work without MY_LOCAL_SW_DIST, 
where it downloads the files from the web.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54828073
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -391,7 +391,19 @@ else
 MY_START_PORT=`expr 24000 + $MY_START_PORT '*' 200`
   elif [ $MY_START_PORT == "rand" ]; then
 # pick a random number between 12000 and 24000 that is divisible by 200
-MY_START_PORT=`expr $RANDOM '%' 60 '*' 200 + 12000`
+lv_number=0   #initialize
--- End diff --

Thanks, from what you told me off-line it looks that this may be a merge 
conflict from another branch and changing it back is the right conflict 
resolution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54819549
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/SsccTransactionalScanner.java.tmpl
 ---
@@ -21,6 +21,26 @@
 * @@@ END COPYRIGHT @@@
 **/
 
+// @@@ START COPYRIGHT @@@
--- End diff --

Probably need to remove one of the two copyright notices?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mashengchen]

Github user mashengchen commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54819507
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -579,17 +591,15 @@ fi
 #
 
 # See JIRA TRAFODION-1512 that will eliminate this check
-if [ -d $MY_LOCAL_SW_DIST ]; then
   
-  HADOOP_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
-  HADOOP_TAR=hadoop-2.5.0-cdh5.3.0.tar.gz
-else
-  
HADOOP_MIRROR_URL=http://download.nextag.com/apache/hadoop/common/hadoop-2.5.2
-  HADOOP_TAR=hadoop-2.5.2.tar.gz
-fi
+HADOOP_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
+HADOOP_TAR=hadoop-2.6.0-cdh5.4.4.tar.gz
 
-if [[ "$SQ_HBASE_DISTRO" = "HDP" ]]; then
-HADOOP_TAR=hadoop-2.6.0.2.2.0.0-2041.tar.gz
+if [[ "$HBASE_DISTRO" = "HDP" ]]; then
--- End diff --

it's just for someone why want to install hbase version beside CDH. they 
can config it by do 'export HBASE_DISTRO=APACHE/HDP'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54819019
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -602,15 +612,24 @@ MYSQL_TAR=mysql-5.6.10-linux-glibc2.5-x86_64.tar.gz
 MYSQL_JDBC_URL=http://cdn.mysql.com/archives/mysql-connector-java-5.1
 MYSQL_JDBC_TAR=mysql-connector-java-5.1.23.tar.gz
 
-HIVE_MIRROR_URL=https://archive.apache.org/dist/hive/hive-0.13.1
-HIVE_PREFIX=apache-hive-0.13.1-bin
+HIVE_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
+HIVE_PREFIX=hive-1.1.0-cdh5.4.4
 HIVE_TAR=${HIVE_PREFIX}.tar.gz
 
+if [[ "$HBASE_DISTRO" = "APACHE" ]]; then
+HIVE_PREFIX=apache-hive-1.2.0-bin
+HIVE_TAR=${HIVE_PREFIX}.tar.gz
+fi
+
+
 HBASE_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
+HBASE_TAR=hbase-1.0.0-cdh5.4.4.tar.gz
 
-HBASE_TAR=hbase-0.98.6-cdh5.3.0.tar.gz
-if [[ "$SQ_HBASE_DISTRO" = "HDP" ]]; then
-HBASE_TAR=hbase-0.98.4.2.2.0.0-2041-hadoop2.tar.gz
+if [[ "$HBASE_DISTRO" = "HDP" ]]; then
+HBASE_TAR=hbase-1.1.2.2.3.2.0-2950.tar.gz
--- End diff --

Same here, also set HBASE_MIRROR_URL? You may not see this as a problem if 
you are using cached objects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54818214
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -391,7 +391,19 @@ else
 MY_START_PORT=`expr 24000 + $MY_START_PORT '*' 200`
   elif [ $MY_START_PORT == "rand" ]; then
 # pick a random number between 12000 and 24000 that is divisible by 200
-MY_START_PORT=`expr $RANDOM '%' 60 '*' 200 + 12000`
+lv_number=0   #initialize
--- End diff --

Sorry, I don't quite understand the reason for this change. Isn't the new 
code doing what the old code did, just more complicated? Also, it extends the 
range up to 31200. We wanted to keep the range fro 24000 to 32000 reserved for 
installations that use the -p fromDisplay option. Please don't change this 
algorithm unless there is a very good reason for doing so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54816839
  
--- Diff: 
core/sqf/hbase_utilities/src/main/java/org/trafodion/utility/backuprestore/TrafExportSnapshot.java
 ---
@@ -114,7 +119,10 @@
   private static final String INPUT_FOLDER_PREFIX = "export-files.";
 
   // Export Map-Reduce Counters, to keep track of the progress
-  public enum Counter { MISSING_FILES, COPY_FAILED, BYTES_EXPECTED, 
BYTES_COPIED, FILES_COPIED };
+  public enum Counter {
--- End diff --

Should this use some enum imported from another class? 
org.apache.hadoop.hbase.snapshot.ExportSnapshot.Counter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mashengchen]

GitHub user mashengchen opened a pull request:

https://github.com/apache/incubator-trafodion/pull/348

TRAFODION-1706

support vanilla hbase1.0 & cdh 1.0.0-cdh5.4.4

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mashengchen/incubator-trafodion master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #348


commit 4ed6be8ceabeb10418ee7101081fe6fd1c02a12c
Author: mashengchen 
Date:   2016-02-25T03:33:39Z

TRAFODION-1706

commit 451df06d92f46bdf1fda61c080df05c272a5b56d
Author: mashengchen 
Date:   2016-02-25T06:14:06Z

Update Makefile

commit d5a4882287a25e0f73674fe6029c503c601a6a58
Author: mashengchen 
Date:   2016-02-25T06:32:16Z

remove some echo

commit f547a6095b9d8c157a0273a9e9605b386fa6f440
Author: mashengchen 
Date:   2016-02-25T07:03:02Z

update install_local_hadoop

commit 2a842bcf3eea4984ed20cfef8f6d77c7a81d00ea
Author: mashengchen 
Date:   2016-02-29T03:04:16Z

update hbase_utilities & add hdp support




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---