[GitHub] incubator-trafodion pull request #1260: [TRAFODION-2768] Make Trafodion code...

2017-10-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/1260


---


[GitHub] incubator-trafodion pull request #1260: [TRAFODION-2768] Make Trafodion code...

2017-10-10 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1260#discussion_r143764664
  
--- Diff: core/sqf/src/tm/tm.cpp ---
@@ -460,9 +460,13 @@ void tm_process_req_requestregioninfo(CTmTxMessage * 
pp_msg)
TM_Txid_legacy lv_transid;
} u;
 
-   char tname[2000], ername[50], rname[100], offline[20], regid[200], 
hostname[200], port[100];
+   char tname[2000];
+   tname[299] = '\0';
--- End diff --

Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see 
that this is the way it was before.


---