[GitHub] incubator-trafodion pull request #1272: [TRAFODION-2773] When the timeout is...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/1272


---

[GitHub] incubator-trafodion pull request #1272: [TRAFODION-2773] When the timeout is...

[SuJinpei]

Github user SuJinpei commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1272#discussion_r146433587
  
--- Diff: core/conn/odb/src/odb.c ---
@@ -4156,18 +4156,17 @@ static void sigcatch(int sig)
 exit ( EX_SIGNAL );
 #else 
 if ( tn == 1 ) { /* single threaded */
-tclean( 0 );
 gclean();
-exit( EX_SIGNAL );
 } else {
 for ( i = 0 ; i < tn ; i++ ) {
-if ( !pthread_kill(thid[i], 0) ) {  /* If this thread is 
alive... */
+if ( pthread_kill(thid[i], 0) ) {  /* If this thread is 
alive... */
--- End diff --

Yes, I misunderstood it.


---

[GitHub] incubator-trafodion pull request #1272: [TRAFODION-2773] When the timeout is...

[selvaganesang]

Github user selvaganesang commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1272#discussion_r146286486
  
--- Diff: core/conn/odb/src/odb.c ---
@@ -4156,18 +4156,17 @@ static void sigcatch(int sig)
 exit ( EX_SIGNAL );
 #else 
 if ( tn == 1 ) { /* single threaded */
-tclean( 0 );
 gclean();
-exit( EX_SIGNAL );
 } else {
 for ( i = 0 ; i < tn ; i++ ) {
-if ( !pthread_kill(thid[i], 0) ) {  /* If this thread is 
alive... */
+if ( pthread_kill(thid[i], 0) ) {  /* If this thread is 
alive... */
--- End diff --

pthread_kill returns 0 when the thread exists. So, earlier code ( ! 
pthread_kill ...) is a valid one


---

[GitHub] incubator-trafodion pull request #1272: [TRAFODION-2773] When the timeout is...

[SuJinpei]

GitHub user SuJinpei opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1272

[TRAFODION-2773] When the timeout is set, odb is still hang

we needn't call other function which may cause odb hang again when 
receiving a signal, we just want to exit.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SuJinpei/incubator-trafodion TRAFODION-2773

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1272


commit 9f93e7d55357c543c035328ca21e9b70959184b6
Author: SuJinpei <873118...@qq.com>
Date:   2017-10-19T07:54:38Z

fix TRAFODION-2773




---