[GitHub] incubator-trafodion pull request #810: [TRAFODION-2293] remove minor version...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/810


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #810: [TRAFODION-2293] remove minor version...

[traflm]

Github user traflm commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/810#discussion_r86275214
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -1554,7 +1554,7 @@ echo "$MY_LOCAL_SW_DIST/${HBASE_TAR}"
   org.apache.hadoop.hbase.security.visibility.VisibilityController"
   fi
 
-  if [[ "$HBASE_DISTRO" != "APACHE1.2" || "$HBASE_DISTRO" != "CDH5.7"]]; 
then 
+  if [[ "$HBASE_DISTRO" != "APACHE1.2" && "$HBASE_DISTRO" != "CDH5.7"]]; 
then 
--- End diff --

not able to determine if this work correctly or not, @mashengchen , please 
describe the UT you did after this change.
Since this only change '||' to '&&', but from what others reported, there 
are other issues like 'space' and the local_hadoop directory. So it is a must 
to run it yourself before I can approve this. 
So please describe how you did the UT.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #810: [TRAFODION-2293] remove minor version...

[mashengchen]

GitHub user mashengchen opened a pull request:

https://github.com/apache/incubator-trafodion/pull/810

[TRAFODION-2293] remove minor version for the hbase-trx-apache_*.jar



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mashengchen/incubator-trafodion trafodion-2293

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #810


commit 8c38f482b8085f6f9676a0d6d93834e65e17795a
Author: mashengchen 
Date:   2016-11-02T02:58:21Z

Update install_local_hadoop




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---