[GitHub] [airflow] wittfabian commented on issue #5659: [AIRFLOW-5033] Switched to snakebite-py3

[GitBox]

wittfabian commented on issue #5659: [AIRFLOW-5033] Switched to snakebite-py3
URL: https://github.com/apache/airflow/pull/5659#issuecomment-613833088
 
 
   Is it still planned to switch to PyArrow in the future? We only encounter 
problems with snakebite in our projects.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

[GitBox]

zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task 
state meanwhile
URL: https://github.com/apache/airflow/pull/7683#issuecomment-613830825
 
 
   Ok, I will try to
   * Remove "DAG" button in Task Instance dialog in Graph view
   * Add task instances in dag run dialog in Tree view
   
   But I insist on add function `_set_dag_run_state_according_ti` in 
`mark_tasks.py` and use `include_dag=True` as default value in `view.py`, that 
mean mark dagrun success if all task instance success as default behavior
   ```diff
   return self._mark_task_instance_state(dag_id, task_id, origin, 
execution_date,
 confirmed, upstream, 
downstream,
 future, past, State.FAILED)
   - future, past, State.FAILED)
   + future, past, 
include_dag=True, State.FAILED)
   ```
   Cause I think It's a missing function in Task Instance Modal dialog, I have 
some situation about this dialog. For example
   ```py
   task1 >> [task2, task3]
   ```
   * **CASE ONE**: task2 and task3 failed, and task3 **not need** to re-run(not 
related about time and next scheduler task work fine), but task2 **have to be 
rerun**. I just mark task3 success and clear task2 include downstream. every 
thing work fine and dagrun mark as success after finish task2.
   * **CASE TWO**: task2 and task3 failed and both of them **not need to 
rerun**, I just click task1 and mark task instance success include downstream, 
but dagrun still with failed status. I have to go to dag run page to correct 
dag run state.  Yeah we could go to tree view mark dagrun success after I add 
optional button beside 'mark success/failed' button, but it's mean I have to 
move from graph to tree view, which meaningless step.
   
   So I think change dagrun state in Task Instance Modal dialog if possible 
make sense, and I want to keep it this function. And remove the "DAG" button in 
Task Instance Modal dialog to avoid misleading to user. WDYT @feluelle @kaxil 
@potiuk 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

[GitBox]

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state 
meanwhile
URL: https://github.com/apache/airflow/pull/7683#issuecomment-613831990
 
 
   And BTW, I alway check DAG view at first, because in big dag with many 
tasks, I think it's more straightforward about the relationship in dag view 
instead of tree view.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

[GitBox]

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state 
meanwhile
URL: https://github.com/apache/airflow/pull/7683#issuecomment-613830825
 
 
   Ok, I will try to
   * Remove "DAG" button in Task Instance dialog in Graph view
   * Add task instances in dag run dialog in Tree view
   
   But I insist on add function `_set_dag_run_state_according_ti` in 
`mark_tasks.py` and use `include_dag=True` as default value in `view.py`, that 
mean mark dagrun success if all task instance success as default behavior
   ```diff
   return self._mark_task_instance_state(dag_id, task_id, origin, 
execution_date,
 confirmed, upstream, 
downstream,
 future, past, State.FAILED)
   - future, past, State.FAILED)
   + future, past, 
include_dag=True, State.FAILED)
   ```
   Cause I think It's a missing function in Task Instance Modal dialog, I have 
some situation about this dialog. For example
   ```py
   task1 >> [task2, task3]
   ```
   * **CASE ONE**: task2 and task3 failed, and task3 **not need** to re-run(not 
related about time and next scheduler task work fine), but task2 **have to be 
rerun**. I just mark task3 success and clear task2 include downstream. every 
thing work fine and dagrun mark as success after finish task2.
   * **CASE TWO**: task2 and task3 failed and both of them **not need to 
rerun**, I just click task1 and mark task instance success include downstream, 
but dagrun still with failed status. Yeah we could go to tree view mark dagrun 
success after I add optional button beside 'mark success/failed' button, but 
it's mean I have to move from graph to tree view, which meaningless step.
   
   So I think change dagrun state in Task Instance Modal dialog if possible 
make sense, and I want to keep it this function. And remove the "DAG" button in 
Task Instance Modal dialog to avoid misleading to user. WDYT @feluelle @kaxil 
@potiuk 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk opened a new pull request #8314: Production image is now built automatically in Dockerhub

[GitBox]

potiuk opened a new pull request #8314: Production image is now built 
automatically in Dockerhub
URL: https://github.com/apache/airflow/pull/8314
 
 
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #8184: Upgrade Azure storage blob and Azure file share

[GitBox]

potiuk commented on issue #8184: Upgrade Azure storage blob and Azure file  
share
URL: https://github.com/apache/airflow/pull/8184#issuecomment-613824447
 
 
   Untortunately not (yet). We have been toying with a possibility of adding 
extra wheel package or adding separate requirements.txt per DAG or even per 
task but it has not been done yet. I will create a an issue describing proposed 
solution and (re) raise discussion for that in devlist soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ramkrishnan8994 edited a comment on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

[GitBox]

ramkrishnan8994 edited a comment on issue #6337: [AIRFLOW-5659] - Add support 
for ephemeral storage on KubernetesPodOp…
URL: https://github.com/apache/airflow/pull/6337#issuecomment-613823396
 
 
   > > > > When will this be added to apache-airflow 1.10.10 pip package. Need 
this ephemeral storage support in one of the projects.
   > > > 
   > > > 
   > > > In 1.10.11
   > > 
   > > 
   > > When is this release planned?
   > 
   > In 1-2 months
   
   If I had to integrate this change into my pip setup, how would you suggest i 
do it. I have 1.10.9 running now. This is kind of urgent


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #8304: [Airflow-5565] Add extra_args param to s3hook

[GitBox]

potiuk commented on a change in pull request #8304: [Airflow-5565] Add 
extra_args param to s3hook
URL: https://github.com/apache/airflow/pull/8304#discussion_r408587530
 
 

 ##
 File path: airflow/providers/amazon/aws/hooks/s3.py
 ##
 @@ -576,19 +578,21 @@ def load_file_obj(self,
 object to be uploaded
 :type acl_policy: str
 """
-self._upload_file_obj(file_obj, key, bucket_name, replace, encrypt, 
acl_policy)
+self._upload_file_obj(file_obj, key, bucket_name, replace, encrypt, 
acl_policy, extra_args)
 
 def _upload_file_obj(self,
  file_obj,
  key,
  bucket_name=None,
  replace=False,
  encrypt=False,
- acl_policy=None):
+ acl_policy=None,
+ extra_args=None):
 if not replace and self.check_for_key(key, bucket_name):
 raise ValueError("The key {key} already exists.".format(key=key))
 
-extra_args = {}
+if not extra_args:
 
 Review comment:
   You should make a deepcopy of the extra_args otherwise you can mutate 
external args with the next line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ramkrishnan8994 commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

[GitBox]

ramkrishnan8994 commented on issue #6337: [AIRFLOW-5659] - Add support for 
ephemeral storage on KubernetesPodOp…
URL: https://github.com/apache/airflow/pull/6337#issuecomment-613823396
 
 
   > > > > When will this be added to apache-airflow 1.10.10 pip package. Need 
this ephemeral storage support in one of the projects.
   > > > 
   > > > 
   > > > In 1.10.11
   > > 
   > > 
   > > When is this release planned?
   > 
   > In 1-2 months
   
   If I had to integrate this change into my pip setup, how would you suggest i 
do it. I have 1.10.9 running now


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman commented on issue #8219: Add migration waiting script and log cleaner

[GitBox]

dimberman commented on issue #8219: Add migration waiting script and log cleaner
URL: https://github.com/apache/airflow/pull/8219#issuecomment-613813496
 
 
   @ashb changing that "and v" in the argument parsing broke a lot of things in 
non-trivial ways. I think if we want to fix how we parse commands that should 
be its own ticket.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #8313: Simplify handling of downloaded files in Dataflow

[GitBox]

mik-laj commented on a change in pull request #8313: Simplify handling of 
downloaded files in Dataflow
URL: https://github.com/apache/airflow/pull/8313#discussion_r408575682
 
 

 ##
 File path: airflow/providers/google/cloud/operators/dataflow.py
 ##
 @@ -471,85 +473,42 @@ def __init__(  # pylint: disable=too-many-arguments
 
 def execute(self, context):
 """Execute the python dataflow job."""
-bucket_helper = GoogleCloudBucketHelper(
-self.gcp_conn_id, self.delegate_to)
-self.py_file = bucket_helper.google_cloud_to_local(self.py_file)
-self.hook = DataflowHook(
-gcp_conn_id=self.gcp_conn_id,
-delegate_to=self.delegate_to,
-poll_sleep=self.poll_sleep
-)
-dataflow_options = self.dataflow_default_options.copy()
-dataflow_options.update(self.options)
-# Convert argument names from lowerCamelCase to snake case.
-camel_to_snake = lambda name: re.sub(
-r'[A-Z]', lambda x: '_' + x.group(0).lower(), name)
-formatted_options = {camel_to_snake(key): dataflow_options[key]
- for key in dataflow_options}
+with ExitStack() as exit_stack:
+if self.py_file.lower().startswith('gs://'):
+gcs_hook = GCSHook(self.gcp_conn_id, self.delegate_to)
+tmp_gcs_file = exit_stack.enter_context(  # pylint: 
disable=no-member
+gcs_hook.provide_file(object_url=self.py_file)
+)
+self.py_file = tmp_gcs_file.name
+
+self.hook = DataflowHook(
+gcp_conn_id=self.gcp_conn_id,
+delegate_to=self.delegate_to,
+poll_sleep=self.poll_sleep
+)
+dataflow_options = self.dataflow_default_options.copy()
+dataflow_options.update(self.options)
+# Convert argument names from lowerCamelCase to snake case.
+camel_to_snake = lambda name: re.sub(r'[A-Z]', lambda x: '_' + 
x.group(0).lower(), name)
+formatted_options = {camel_to_snake(key): dataflow_options[key]
+ for key in dataflow_options}
 
-def set_current_job_id(job_id):
-self.job_id = job_id
+def set_current_job_id(job_id):
+self.job_id = job_id
 
-self.hook.start_python_dataflow(
-job_name=self.job_name,
-variables=formatted_options,
-dataflow=self.py_file,
-py_options=self.py_options,
-py_interpreter=self.py_interpreter,
-py_requirements=self.py_requirements,
-py_system_site_packages=self.py_system_site_packages,
-on_new_job_id_callback=set_current_job_id,
-project_id=self.project_id,
-)
+self.hook.start_python_dataflow(
+job_name=self.job_name,
+variables=formatted_options,
+dataflow=self.py_file,
+py_options=self.py_options,
+py_interpreter=self.py_interpreter,
+py_requirements=self.py_requirements,
+py_system_site_packages=self.py_system_site_packages,
+on_new_job_id_callback=set_current_job_id,
+project_id=self.project_id,
+)
 
 def on_kill(self) -> None:
 self.log.info("On kill.")
 if self.job_id:
 self.hook.cancel_job(job_id=self.job_id, 
project_id=self.project_id)
-
-
-class GoogleCloudBucketHelper:
-"""GoogleCloudStorageHook helper class to download GCS object."""
-GCS_PREFIX_LENGTH = 5
-
-def __init__(self,
- gcp_conn_id: str = 'google_cloud_default',
- delegate_to: Optional[str] = None) -> None:
-self._gcs_hook = GCSHook(gcp_conn_id, delegate_to)
-
-def google_cloud_to_local(self, file_name: str) -> str:
-"""
-Checks whether the file specified by file_name is stored in Google 
Cloud
-Storage (GCS), if so, downloads the file and saves it locally. The full
-path of the saved file will be returned. Otherwise the local file_name
-will be returned immediately.
-
-:param file_name: The full path of input file.
-:type file_name: str
-:return: The full path of local file.
-:rtype: str
-"""
-if not file_name.startswith('gs://'):
-return file_name
-
-# Extracts bucket_id and object_id by first removing 'gs://' prefix and
-# then split the remaining by path delimiter '/'.
-path_components = file_name[self.GCS_PREFIX_LENGTH:].split('/')
-if len(path_components) < 2:
-raise Exception(
-'Invalid Google Cloud Storage (GCS) object path: {}'
-.format(file_name))
-
-bucket_id = path_components[0]
-object_id = '/'.join(path_components[1:])
-

[GitHub] [airflow] mik-laj opened a new pull request #8313: Simplify handling of downloaded files in Dataflow

[GitBox]

mik-laj opened a new pull request #8313: Simplify handling of downloaded files 
in Dataflow
URL: https://github.com/apache/airflow/pull/8313
 
 
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

zhongjiajie edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with 
common used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613794873
 
 
   Looking forward your public blog, BTW, code LGTM, except TESTING.rst 
what you mention above


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

zhongjiajie edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with 
common used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613794873
 
 
   Looking forward your public blog, BTW, code LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common 
used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613794873
 
 
   Looking forward your public blog, BTW, code LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used 
decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613784971
 
 
   I saw this article, but I'm afraid we should check and update it first. I 
started to write internal materials for my company. I started to write internal 
materials for my company. I hope that some excerpts can be published on the 
company blog sometime.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used 
decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613780821
 
 
   I will add a short note in the file TESTING.rst.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common 
used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613780352
 
 
   BTW, I find out we have some scheduler doc only in confluence 
https://cwiki.apache.org/confluence/display/AIRFLOW/Scheduler+Basics, should we 
add this page to airflow document too


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #8312: Change delete-on-success to delete-on-failure

[GitBox]

codecov-io commented on issue #8312: Change delete-on-success to 
delete-on-failure
URL: https://github.com/apache/airflow/pull/8312#issuecomment-613780382
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8312?src=pr=h1) 
Report
   > Merging 
[#8312](https://codecov.io/gh/apache/airflow/pull/8312?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/eee4ebaeeb1991480ee178ddb600bc69b2a88764=desc)
 will **decrease** coverage by `27.68%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/8312/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8312?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#8312   +/-   ##
   ===
   - Coverage   88.43%   60.74%   -27.69% 
   ===
 Files 940  940   
 Lines   4535345354+1 
   ===
   - Hits4010827551-12557 
   - Misses   524517803+12558 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/8312?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `57.11% <100.00%> (ø)` | |
   | 
[airflow/providers/exasol/operators/exasol.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZXhhc29sL29wZXJhdG9ycy9leGFzb2wucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/hooks/kinesis.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9raW5lc2lzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/providers/apache/livy/sensors/livy.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2xpdnkvc2Vuc29ycy9saXZ5LnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/sensors/redshift.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL3JlZHNoaWZ0LnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/providers/mysql/operators/s3\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL3MzX3RvX215c3FsLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/providers/microsoft/azure/operators/adx.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL29wZXJhdG9ycy9hZHgucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[...irflow/providers/amazon/aws/hooks/batch\_waiters.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9iYXRjaF93YWl0ZXJzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[...ow/providers/amazon/aws/secrets/secrets\_manager.py](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZWNyZXRzL3NlY3JldHNfbWFuYWdlci5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [324 
more](https://codecov.io/gh/apache/airflow/pull/8312/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/8312?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/8312?src=pr=footer). 
Last update 
[eee4eba...36f27ba](https://codecov.io/gh/apache/airflow/pull/8312?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common 
used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613779057
 
 
   > In my opinion, the CONTRIBUTOR Guide should contain the most important 
information for beginners.
   
   Make sence, but I still think we should add doc somewhere else, not only in 
python docsting


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on a change in pull request #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

zhongjiajie commented on a change in pull request #7650: [AIRFLOW-7008] Add 
perf kit with common used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#discussion_r408540897
 
 

 ##
 File path: scripts/perf/perf_kit/__init__.py
 ##
 @@ -0,0 +1,119 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+Perf-kit
+
+
+Useful decorators and context managers used when testing the performance of 
various Airflow components.
+
+To use this package, you must add the parent directory to the ``PYTHONPATH`` 
environment variable. If the
+repository root directory is ``/opt/airflow/``, then you need to run the 
following command:
+
+.. code-block:: bash
+export PYTHONPATH=/opt/airflow/script/perf
+
+Content
+===
+The following decorators and context managers are included.
+
+.. autofunction:: perf_kit.memory.trace_memory
+
+.. autofunction:: perf_kit.python.pyspy
+
+.. autofunction:: perf_kit.python.profiled
+
+.. autofunction:: perf_kit.repeat_and_time.timing
+
+.. autofunction:: perf_kit.repeat_and_time.repeat
+
+.. autofunction:: perf_kit.repeat_and_time.timeout
+
+.. autofunction:: perf_kit.sqlalchemy.trace_queries
+
+.. autofunction:: perf_kit.sqlalchemy.count_queries
+
+Documentation for each function is provided in the function docstrings. Each 
module also has an example in
+the main section of the module.
+
+Examples
+
+
+If you want to run an all example for ``perf_kit.sqlalchemy``, you can run the 
following command.
+
+.. code-block:: bash
+python -m perf_kit.sqlalchemy
+
+If you want to know how to use these functions, it is worth to familiarize 
yourself with these examples.
+
+Use in tests
+
+
+If you need it, you can easily test only one test using context manager.
+
+Suppose we have the following fragment of the file with tests.
+
+.. code-block:: python
+
+prev = dag.previous_schedule(_next)
+prev_local = local_tz.convert(prev)
+
+self.assertEqual(prev_local.isoformat(), "2018-03-24T03:00:00+01:00")
+self.assertEqual(prev.isoformat(), "2018-03-24T02:00:00+00:00")
+
+def test_bulk_sync_to_db(self):
+clear_db_dags()
+dags = [
+DAG(f'dag-bulk-sync-{i}', start_date=DEFAULT_DATE, 
tags=["test-dag"]) for i in range(0, 4)
+]
+
+with assert_queries_count(3):
+DAG.bulk_sync_to_db(dags)
+
+You can add a code snippet before the method definition, and then perform only 
one test and count the
+queries in it.
+
+.. code-block:: python
 
 Review comment:
   I will use type `diff` in some change document in my company, for more easy 
to trace what change we did, do you think we should use diff here? And I don't 
know whether rst file work with `diff`
   
   ```diff
   prev = dag.previous_schedule(_next)
   prev_local = local_tz.convert(prev)
   
   self.assertEqual(prev_local.isoformat(), "2018-03-24T03:00:00+01:00")
   self.assertEqual(prev.isoformat(), "2018-03-24T02:00:00+00:00")
   
   +   from perf_kit.sqlalchemy.sqlalchemy import trace_queries
   
   +   @trace_queries
   def test_bulk_sync_to_db(self):
   clear_db_dags()
   dags = [
   DAG(f'dag-bulk-sync-{i}', start_date=DEFAULT_DATE, 
tags=["test-dag"]) for i in range(0, 4)
   ]
   with assert_queries_count(3):
   DAG.bulk_sync_to_db(dags)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used 
decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613775703
 
 
   @zhongjiajie  I am afraid that this file will be too long if we add any 
information.  In my opinion, the CONTRIBUTOR Guide should contain the most 
important information for beginners. Scheduler optimization is not a key task 
for these people. I would like to see a guidebook that describes more advanced 
information on the model of a contributor's guide, but advanced people are 
already quite familiar with the structure of the project. WDYT?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

zhongjiajie commented on issue #7650: [AIRFLOW-7008] Add perf kit with common 
used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613769496
 
 
   Should we add some document to `CONTRIBUTING.rst` too?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman opened a new pull request #8312: Change delete-on-success to delete-on-failure

[GitBox]

dimberman opened a new pull request #8312: Change delete-on-success to 
delete-on-failure
URL: https://github.com/apache/airflow/pull/8312
 
 
   It makes more sense to by-default not delete failed pods
   Users should explicitly state they want these pods deleted.
   
   This feature has not yet been released so ethis will not be a breaking
   change
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] davinchia commented on issue #8129: API Endpoints - CRUD - DAG Runs

[GitBox]

davinchia commented on issue #8129: API Endpoints - CRUD - DAG Runs
URL: https://github.com/apache/airflow/issues/8129#issuecomment-613763951
 
 
   +1. we currently use the experimental api to start dag runs, and have to 
jump through lots of hoops to get the status of a current dag run. allowing 
someone to do this easily will be awesome


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8311: Task Duration Missing from the Graph View Tool-tip for Running Tasks

[GitBox]

boring-cyborg[bot] commented on issue #8311: Task Duration Missing from the 
Graph View Tool-tip for Running Tasks
URL: https://github.com/apache/airflow/issues/8311#issuecomment-613760976
 
 
   Thanks for opening your first issue here! Be sure to follow the issue 
template!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] shane-graham opened a new issue #8311: Task Duration Missing from the Graph View Tool-tip for Running Tasks

[GitBox]

shane-graham opened a new issue #8311: Task Duration Missing from the Graph 
View Tool-tip for Running Tasks
URL: https://github.com/apache/airflow/issues/8311
 
 
   **Apache Airflow version**: 1.10.10
   
   **Environment**:
   
   - **Cloud provider or hardware configuration**:  AWS EC2 m5.2xlarge
   - **OS** (e.g. from /etc/os-release): Ubuntu 18.04.4 LTS
   - **Kernel** (e.g. `uname -a`): Linux 4.15.0-1063-aws #67-Ubuntu SMP Mon Mar 
2 07:24:29 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
   - **Install tools**: Python 3.7.7/Pip in a virtual environment
   - **Others**:  **RBAC UI**, on a standalone server with the LocalExecutor 
running a PostgreSQL repository
   
   **What happened**:  The Graph View tool-tip does not display the duration of 
running tasks while the Tree View does.  In addition, the Graph View shows 
"Invalid Date" for the "Ended:" field while the Tree View displaces the current 
datetime.
   
   **What you expected to happen**:  The Graph View should show the same date 
and duration information as the Tree View for running tasks.
   
   **How to reproduce it**:  While a DAG is executing, examine the tool-tips in 
both the Tree View and Graph View pages.
   
   
![image](https://user-images.githubusercontent.com/46032116/79288560-12de3200-7e95-11ea-8bc9-88de94f07e74.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #8287: [AIRFLOW-4363] Fix JSON encoding error

[GitBox]

codecov-io edited a comment on issue #8287: [AIRFLOW-4363] Fix JSON encoding 
error
URL: https://github.com/apache/airflow/pull/8287#issuecomment-613752847
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=h1) 
Report
   > Merging 
[#8287](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/45c8983306ab1c54abdacd8f870e790fad25cb37=desc)
 will **decrease** coverage by `0.58%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/8287/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#8287  +/-   ##
   ==
   - Coverage   88.45%   87.86%   -0.59% 
   ==
 Files 937  940   +3 
 Lines   4523445350 +116 
   ==
   - Hits4001139849 -162 
   - Misses   5223 5501 +278 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/docker/operators/docker.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZG9ja2VyL29wZXJhdG9ycy9kb2NrZXIucHk=)
 | `96.90% <100.00%> (ø)` | |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
   | 
[airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5)
 | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
   | 
[...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==)
 | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
   | ... and [11 
more](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=footer). 
Last update 
[45c8983...9c2a2e5](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error

[GitBox]

codecov-io commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error
URL: https://github.com/apache/airflow/pull/8287#issuecomment-613752847
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=h1) 
Report
   > Merging 
[#8287](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/45c8983306ab1c54abdacd8f870e790fad25cb37=desc)
 will **decrease** coverage by `0.58%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/8287/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#8287  +/-   ##
   ==
   - Coverage   88.45%   87.86%   -0.59% 
   ==
 Files 937  940   +3 
 Lines   4523445350 +116 
   ==
   - Hits4001139849 -162 
   - Misses   5223 5501 +278 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/docker/operators/docker.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZG9ja2VyL29wZXJhdG9ycy9kb2NrZXIucHk=)
 | `96.90% <100.00%> (ø)` | |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
   | 
[airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5)
 | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
   | 
[...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==)
 | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
   | ... and [11 
more](https://codecov.io/gh/apache/airflow/pull/8287/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=footer). 
Last update 
[45c8983...9c2a2e5](https://codecov.io/gh/apache/airflow/pull/8287?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jloehel commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

[GitBox]

jloehel commented on a change in pull request #8256: updated _write_args on 
PythonVirtualenvOperator
URL: https://github.com/apache/airflow/pull/8256#discussion_r408517234
 
 

 ##
 File path: airflow/operators/python_operator.py
 ##
 @@ -330,13 +330,28 @@ def _write_string_args(self, filename):
 
 def _write_args(self, input_filename):
 # serialize args to file
+if self.use_dill:
+serializer = dill
+else:
+serializer = pickle
+# some args from context can't be loaded in virtual env
+invalid_args = set(['dag', 'task', 'ti'])
 
 Review comment:
   Maybe I am using it wrong but I don't get the idea why it is an anti-pattern 
to exchange data between tasks. I am using this feature really often. I will 
make the changes on my side but I would love to see your PR merged soon. Thanks 
a lot for your work :-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6295) Create guide for BigQuery service operator

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083710#comment-17083710
 ] 

ASF GitHub Bot commented on AIRFLOW-6295:
-

mik-laj commented on pull request #8276: [AIRFLOW-6295] Create guide for 
BigQuery operators
URL: https://github.com/apache/airflow/pull/8276
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create guide for BigQuery service operator
> --
>
> Key: AIRFLOW-6295
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6295
> Project: Apache Airflow
>  Issue Type: New Feature
>  Components: documentation, gcp
>Affects Versions: 1.10.6
>Reporter: Kamil Bregula
>Assignee: Alexandra Abbas
>Priority: Minor
>  Labels: GoodForNewContributors
>
> Hello,
> A guide that describes how to use BigQuery service operators would be useful.
> Other guides are available:
> https://airflow.readthedocs.io/en/latest/howto/operator/gcp/index.html
> If anyone is interested in this task, I am willing to provide all the 
> necessary tips and information.
> Best regards,
> Kamil



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

[GitBox]

boring-cyborg[bot] commented on issue #8276: [AIRFLOW-6295] Create guide for 
BigQuery operators
URL: https://github.com/apache/airflow/pull/8276#issuecomment-613745467
 
 
   Awesome work, congrats on your first merged pull request!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj closed issue #8200: Create guide for BigQuery operators

[GitBox]

mik-laj closed issue #8200: Create guide for BigQuery operators
URL: https://github.com/apache/airflow/issues/8200
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #8276: [AIRFLOW-6295] Create guide for BigQuery operators

[GitBox]

mik-laj merged pull request #8276: [AIRFLOW-6295] Create guide for BigQuery 
operators
URL: https://github.com/apache/airflow/pull/8276
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8279: Protect /rendered page from invalid DAG ids (#8171)

[GitBox]

mik-laj commented on issue #8279: Protect /rendered page from invalid DAG ids 
(#8171)
URL: https://github.com/apache/airflow/pull/8279#issuecomment-613742808
 
 
   We have not previously validated data (we have only validation provided by 
FAB) and we have to come up with good practises. You may have the impression 
that the scope of work has changed, but if we just don't start working, we 
don't know how to do something fully. Now I am convinced that this is an 
important task and we definitely should do it. Go ahead and ask if you have 
questions. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

[GitBox]

kaxil commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral 
storage on KubernetesPodOp…
URL: https://github.com/apache/airflow/pull/6337#issuecomment-613740389
 
 
   > > > When will this be added to apache-airflow 1.10.10 pip package. Need 
this ephemeral storage support in one of the projects.
   > > 
   > > 
   > > In 1.10.11
   > 
   > When is this release planned?
   
   In 1-2 months


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error

[GitBox]

kaxil commented on issue #8287: [AIRFLOW-4363] Fix JSON encoding error
URL: https://github.com/apache/airflow/pull/8287#issuecomment-613738323
 
 
   Can you please add new unit tests too


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

[GitBox]

kaxil commented on issue #7683: [AIRFLOW-7033] Change dag and task state 
meanwhile
URL: https://github.com/apache/airflow/pull/7683#issuecomment-613737841
 
 
   > Yes that’s the window I meant.
   > 
   > Don‘t you think it would make more sense to add an optional button "task 
instances" next to mark success/fail button? instead of "dag" on the task 
instance dialog window?
   
   I agree with @feluelle , I think it would make more sense to not have this 
on Task Instance Modal dialog and instead on a specific DAG.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #8184: Upgrade Azure storage blob and Azure file share

[GitBox]

kaxil commented on issue #8184: Upgrade Azure storage blob and Azure file  share
URL: https://github.com/apache/airflow/pull/8184#issuecomment-613737260
 
 
   Ya it is a bummer. @potiuk Can we handle different versions of the package 
in the current providers model?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7626: [AIRFLOW-5575] Cannot use the mark future success/failure feature in the UI

[GitBox]

kaxil commented on issue #7626: [AIRFLOW-5575] Cannot use the mark future 
success/failure feature in the UI
URL: https://github.com/apache/airflow/pull/7626#issuecomment-613736364
 
 
   > @crhyatt I have no idea why it's doing that... can you rebase again? I'm 
not too worried about codecov here. @kaxil maybe you've seent this before?
   
   CodeCov basically tells you what part of the code is not covered by tests 
but ignore it as it has been unstable off-late. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj edited a comment on issue #8279: Protect /rendered page from invalid DAG ids (#8171)

[GitBox]

mik-laj edited a comment on issue #8279: Protect /rendered page from invalid 
DAG ids (#8171)
URL: https://github.com/apache/airflow/pull/8279#issuecomment-613732733
 
 
   I open following page:
   ```
   
http://localhost:28080/rendered?dag_id=example_bash_operator_id=runme_0_date=2020-04-13T00%3A00%3A00%2B00%3A00
   ```
   I see the correct view.
   I add one letter to the task ID.
   ```
   
http://localhost:28080/rendered?dag_id=example_bash_operator_id=runme_0D_date=2020-04-13T00%3A00%3A00%2B00%3A00
   ```
   ![Screenshot 2020-04-15 at 01 26 
50](https://user-images.githubusercontent.com/12058428/79283461-38c8fe00-7eb8-11ea-8fe0-0f142641c8e0.png)
   I see a mushroom. This should not happen in a mature application. A clear 
error message should appear.
   
   When I open following address:
   ```
   
http://localhost:28080/rendered?dag_id=example_bash_operator_id=runme_0_date=2020-04-13T00%3A00%3A00%2B00%3A00
   ```
   I also see mushroom.
   ![Screenshot 2020-04-15 at 01 29 
02](https://user-images.githubusercontent.com/12058428/79283552-86de0180-7eb8-11ea-9f9c-e835869d20f0.png)
   This is a user-experience problem, but it is also a security problem.  If we 
see similar messages, it means that we haven't verified enough input data. Data 
validation is the basic method of protecting against other serious attacks from 
the "Injection" family e.g. SQL Injection. Input validation should happen as 
early as possible in the data flow, preferably as soon as the data is received 
from the client.  However, we do not have any validation for many parameters.
   
![image](https://user-images.githubusercontent.com/12058428/79283676-d58b9b80-7eb8-11ea-8514-c3abd89e3416.png)
   
   More information:
   
https://cheatsheetseries.owasp.org/cheatsheets/Input_Validation_Cheat_Sheet.html
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj closed issue #8301: Support Duration in AwsHook when using assume role

[GitBox]

mik-laj closed issue #8301: Support Duration in AwsHook when using assume role
URL: https://github.com/apache/airflow/issues/8301
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8301: Support Duration in AwsHook when using assume role

[GitBox]

mik-laj commented on issue #8301: Support Duration in AwsHook when using assume 
role
URL: https://github.com/apache/airflow/issues/8301#issuecomment-613735539
 
 
   We don't cheery pick new changes related to operators to Airflow 1.10, but 
we want to release operators from Ariflow 2.0 as a pip package.
   More information: 
https://github.com/apache/airflow/blob/master/README.md#using-hooks-and-operators-from-master-in-airflow-110


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4235) home page dags table: highlight rows on mouse hover

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083692#comment-17083692
 ] 

ASF subversion and git services commented on AIRFLOW-4235:
--

Commit 324954c7d37acd12b9593958fdf4b424f8c5d11d in airflow's branch 
refs/heads/v1-10-test from Nando Quintana
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=324954c ]

[AIRFLOW-4235] Add table-hover css class to DAGs table (#5033)


> home page dags table: highlight rows on mouse hover
> ---
>
> Key: AIRFLOW-4235
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4235
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: ui
>Affects Versions: 1.10.2
>Reporter: Nando Quintana
>Assignee: Fokko Driesprong
>Priority: Trivial
>  Labels: easyfix, newbie
> Fix For: 1.10.11
>
> Attachments: table_dags_table_hover.png
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> In wide screens, home page dags table becomes too wide. There is too much 
> distance between "DAG" and "Links" columns and it is difficult to appreciate 
> which is the icon you should click.
> It would be very useful to highlight row on mouse hover.
> This could be fixed very quickly, adding 'table-hover' css class to 
> table#dags.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6320) Add quarterly to crontab presets

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083697#comment-17083697
 ] 

ASF subversion and git services commented on AIRFLOW-6320:
--

Commit 5d1aaa90bc9bc2b7ee6b620888f0a146a5a15e63 in airflow's branch 
refs/heads/v1-10-test from Jiajie Zhong
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=5d1aaa9 ]

[AIRFLOW-6320] Add quarterly to crontab presets (#6873)


> Add quarterly to crontab presets
> 
>
> Key: AIRFLOW-6320
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6320
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: utils
>Affects Versions: 1.10.6
>Reporter: Jiajie Zhong
>Assignee: Jiajie Zhong
>Priority: Minor
> Fix For: 1.10.11
>
>
> Add quarterly to crontab presets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-7019) Add visual indication of failure to pause/unpause a dag

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083693#comment-17083693
 ] 

ASF subversion and git services commented on AIRFLOW-7019:
--

Commit a99520180868584b5c9e3bb4dc8065faac2e0bcd in airflow's branch 
refs/heads/v1-10-test from Joshua Carp
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=a995201 ]

[AIRFLOW-7019] Show un/pause errors in dags view. (#7669)

Pausing and unpausing dags in the dags view is asynchronous, and there
is currently no indication to the user if the operation fails. This
patch updates the paused input and highlights it in red when pausing or
unpausing fails

(cherry-picked from d4661485a27f7b4aae70358b09b249005b784098)


> Add visual indication of failure to pause/unpause a dag
> ---
>
> Key: AIRFLOW-7019
> URL: https://issues.apache.org/jira/browse/AIRFLOW-7019
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: webserver
>Affects Versions: 1.10.9
>Reporter: Joshua Carp
>Assignee: Joshua Carp
>Priority: Minor
>
> Pausing and unpausing dags from the dag list view is asynchronous, and if the 
> request fails for any reason, there's no indication to the user that the dag 
> hasn't actually changed status. I noticed this recently when cloud composer 
> pushed an update that broke all dag pausing and unpausing, but there are 
> other reasons this could fail. A failed un/pause request should show an 
> indication that the operation failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6697) Base date and Search in Graph view don't dim when modal activate

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083691#comment-17083691
 ] 

ASF subversion and git services commented on AIRFLOW-6697:
--

Commit 4066447f737012ac592f44a7d2e16ed11548f791 in airflow's branch 
refs/heads/v1-10-test from JCoder01
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4066447 ]

[AIRFLOW-6697] fix modal_backdrop z-index (#7313)


> Base date and Search in Graph view don't dim when modal activate
> 
>
> Key: AIRFLOW-6697
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6697
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.7
>Reporter: James Coder
>Assignee: James Coder
>Priority: Minor
> Fix For: 1.10.11
>
> Attachments: image-2020-01-31-13-46-57-069.png
>
>
> !image-2020-01-31-13-46-57-069.png|width=972,height=431!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6351) security - ui - Add Cross Site Scripting defence

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083695#comment-17083695
 ] 

ASF subversion and git services commented on AIRFLOW-6351:
--

Commit afa4b11fddfdbadb048f742cf66d5c21c675a5c8 in airflow's branch 
refs/heads/v1-10-test from tooptoop4
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=afa4b11 ]

[AIRFLOW-6351] security - ui - Add Cross Site Scripting defence (#6913)


> security - ui - Add Cross Site Scripting defence
> 
>
> Key: AIRFLOW-6351
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6351
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.6, 1.10.7
>Reporter: t oo
>Assignee: t oo
>Priority: Major
> Fix For: 1.10.11
>
>
> *escape search -->*
>  
> *BEFORE*
> return self.render(
> 'airflow/dags.html',
> webserver_dags=webserver_dags_filtered,
> orm_dags=orm_dags,
> hide_paused=hide_paused,
> current_page=current_page,
> search_query=arg_search_query if arg_search_query else '',
> page_size=dags_per_page,
> num_of_pages=num_of_pages,
> num_dag_from=start + 1,
> num_dag_to=min(end, num_of_all_dags),
> num_of_all_dags=num_of_all_dags,
> paging=wwwutils.generate_pages(current_page, num_of_pages,
> {color:#FF}search=arg_search_query,{color}
> showPaused=not hide_paused),
> dag_ids_in_page=page_dag_ids,
> auto_complete_data=auto_complete_data)
>  
> *AFTER*
> return self.render(
> 'airflow/dags.html',
> webserver_dags=webserver_dags_filtered,
> orm_dags=orm_dags,
> hide_paused=hide_paused,
> current_page=current_page,
> search_query=arg_search_query if arg_search_query else '',
> page_size=dags_per_page,
> num_of_pages=num_of_pages,
> num_dag_from=start + 1,
> num_dag_to=min(end, num_of_all_dags),
> num_of_all_dags=num_of_all_dags,
> paging=wwwutils.generate_pages(current_page, num_of_pages,
> {color:#FF}search=escape(arg_search_query) if arg_search_query else 
> None,{color}
> showPaused=not hide_paused),
> dag_ids_in_page=page_dag_ids,
> auto_complete_data=auto_complete_data)
>  
> [https://github.com/apache/airflow/blob/v1-10-stable/airflow/www/views.py#L2278]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-4038) Remove DagBag from /home

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083694#comment-17083694
 ] 

ASF subversion and git services commented on AIRFLOW-4038:
--

Commit 63260c9955d12a60d8c143a932432013dd05eebb in airflow's branch 
refs/heads/v1-10-test from Peter van 't Hof
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=63260c9 ]

[AIRFLOW-4038] Restructure database queries on /home (#4872)


> Remove DagBag from /home
> 
>
> Key: AIRFLOW-4038
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4038
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: webserver
>Reporter: Peter van 't Hof
>Assignee: Peter van 't Hof
>Priority: Major
> Fix For: 1.10.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-7049) Make show_paused persistent across navigation

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083696#comment-17083696
 ] 

ASF subversion and git services commented on AIRFLOW-7049:
--

Commit 830987fd759abe1a1bcb2412b0889c6201a5a9ec in airflow's branch 
refs/heads/v1-10-test from Ryan Hamilton
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=830987f ]

[AIRFLOW-7049] Persistent display/filtering of DAG status (#8106)


> Make show_paused persistent across navigation
> -
>
> Key: AIRFLOW-7049
> URL: https://issues.apache.org/jira/browse/AIRFLOW-7049
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: webserver
>Affects Versions: 1.10.9
>Reporter: Ash Berlin-Taylor
>Priority: Minor
>  Labels: gsoc
>
> The "Show/hide paused DAGs" toggle controls the setting for a page, but if 
> you navigate to a different page and then click on the "home" link the 
> setting will be lost.
> We should persist this on a per-user setting.
> A cookie might work for this -- we could also possibly store the "current" 
> value in the session.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] maganaluis commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

[GitBox]

maganaluis commented on a change in pull request #8256: updated _write_args on 
PythonVirtualenvOperator
URL: https://github.com/apache/airflow/pull/8256#discussion_r408498490
 
 

 ##
 File path: airflow/operators/python_operator.py
 ##
 @@ -330,13 +330,28 @@ def _write_string_args(self, filename):
 
 def _write_args(self, input_filename):
 # serialize args to file
+if self.use_dill:
+serializer = dill
+else:
+serializer = pickle
+# some args from context can't be loaded in virtual env
+invalid_args = set(['dag', 'task', 'ti'])
 
 Review comment:
   @jloehel We have not encountered any cases where to use Xcom, so I'm not 
familiar with it. Let me know if you want me to make any modification to this 
code, or you'll be making changes on your side. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] snazzyfox commented on issue #8301: Support Duration in AwsHook when using assume role

[GitBox]

snazzyfox commented on issue #8301: Support Duration in AwsHook when using 
assume role
URL: https://github.com/apache/airflow/issues/8301#issuecomment-613734429
 
 
   After digging a little into the code, it appears that #7619 introduced the 
ability to set arbitrary kwargs for the assume role function call. That solves 
this issue, but the change is only on master. Any chance we can backport it to 
1.10?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8171: Handle missing object in webserver

[GitBox]

mik-laj commented on issue #8171: Handle missing object in webserver
URL: https://github.com/apache/airflow/issues/8171#issuecomment-613733028
 
 
   This is a user experience problem, but it is also a security problem.  If we 
see similar messages, it means that we haven't verified enough input data. Data 
validation is the basic method of protecting against other serious attacks from 
the "Injection" family e.g. SQL Injection. Input validation should happen as 
early as possible in the data flow, preferably as soon as the data is received 
from the client.  However, we do not have any validation for many parameters.
   
![image](https://user-images.githubusercontent.com/12058428/79283676-d58b9b80-7eb8-11ea-8514-c3abd89e3416.png)
   More information:
   
https://cheatsheetseries.owasp.org/cheatsheets/Input_Validation_Cheat_Sheet.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8279: Protect /rendered page from invalid DAG ids (#8171)

[GitBox]

mik-laj commented on issue #8279: Protect /rendered page from invalid DAG ids 
(#8171)
URL: https://github.com/apache/airflow/pull/8279#issuecomment-613732733
 
 
   I open following page:
   ```
   
http://localhost:28080/rendered?dag_id=example_bash_operator_id=runme_0_date=2020-04-13T00%3A00%3A00%2B00%3A00
   ```
   I see the correct view.
   I add one letter to the task ID.
   ```
   
http://localhost:28080/rendered?dag_id=example_bash_operator_id=runme_0D_date=2020-04-13T00%3A00%3A00%2B00%3A00
   ```
   ![Screenshot 2020-04-15 at 01 26 
50](https://user-images.githubusercontent.com/12058428/79283461-38c8fe00-7eb8-11ea-8fe0-0f142641c8e0.png)
   I see a mushroom. This should not happen in a mature application. A clear 
error message should appear.
   
   When I open following address:
   ```
   
http://localhost:28080/rendered?dag_id=example_bash_operator_id=runme_0_date=2020-04-13T00%3A00%3A00%2B00%3A00
   ```
   I also see mushroom.
   ![Screenshot 2020-04-15 at 01 29 
02](https://user-images.githubusercontent.com/12058428/79283552-86de0180-7eb8-11ea-9f9c-e835869d20f0.png)
   This is a visual problem, but it is also a security problem.  If we see 
similar messages, it means that we haven't verified enough input data. Data 
validation is the basic method of protecting against other serious attacks from 
the "Injection" family e.g. SQL Injection. Input validation should happen as 
early as possible in the data flow, preferably as soon as the data is received 
from the client.  However, we do not have any validation for many parameters.
   
![image](https://user-images.githubusercontent.com/12058428/79283676-d58b9b80-7eb8-11ea-8514-c3abd89e3416.png)
   
   More information:
   
https://cheatsheetseries.owasp.org/cheatsheets/Input_Validation_Cheat_Sheet.html
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil opened a new pull request #8310: Remove unused Scheduler "authenticate" config

[GitBox]

kaxil opened a new pull request #8310: Remove unused Scheduler "authenticate" 
config
URL: https://github.com/apache/airflow/pull/8310
 
 
   I can't find any usage of this config. I checked some commits 3 years ago 
but couldn't find one.
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #8309: Remove deprecated `secure_model` config

[GitBox]

kaxil commented on issue #8309: Remove deprecated `secure_model` config
URL: https://github.com/apache/airflow/pull/8309#issuecomment-613726668
 
 
   > Should we also remove this option from airflow/unittests.cfg and 
airflow/config_templates/default_test.cfg?
   
   Oh yes, updated


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8309: Remove deprecated `secure_model` config

[GitBox]

mik-laj commented on issue #8309: Remove deprecated `secure_model` config
URL: https://github.com/apache/airflow/pull/8309#issuecomment-613725449
 
 
   Should we also remove this option from airflow/unittests.cfg and 
airflow/config_templates/default_test.cfg?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil opened a new pull request #8309: Remove deprecated `secure_model` config

[GitBox]

kaxil opened a new pull request #8309: Remove deprecated `secure_model` config
URL: https://github.com/apache/airflow/pull/8309
 
 
   `secure_mode` config was only available for Flask-admin UI
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #8304: [Airflow-5565] Add extra_args param to s3hook

[GitBox]

codecov-io edited a comment on issue #8304: [Airflow-5565] Add extra_args param 
to s3hook
URL: https://github.com/apache/airflow/pull/8304#issuecomment-613717834
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=h1) 
Report
   > Merging 
[#8304](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a143629ef992dd22aaa5ad16ef888a27bedbe98e=desc)
 will **decrease** coverage by `0.78%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/8304/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#8304  +/-   ##
   ==
   - Coverage   88.47%   87.68%   -0.79% 
   ==
 Files 940  940  
 Lines   4535545356   +1 
   ==
   - Hits4012739771 -356 
   - Misses   5228 5585 +357 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==)
 | `96.52% <100.00%> (+0.01%)` | :arrow_up: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=)
 | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5)
 | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
   | ... and [11 
more](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=footer). 
Last update 
[a143629...393f022](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil edited a comment on issue #8308: Fix Extra Links in Gannt View

[GitBox]

kaxil edited a comment on issue #8308: Fix Extra Links in Gannt View
URL: https://github.com/apache/airflow/pull/8308#issuecomment-613717782
 
 
   > Should we add tests to avoid regression?
   
   Was just typing that  :D . We don't have any tests for Modal or at least I 
don't know, so any pointers would be helpful.
   
   
![image](https://user-images.githubusercontent.com/8811558/79281282-5727fd00-7eaa-11ea-8c4d-5e7bf1d65505.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #8304: [Airflow-5565] Add extra_args param to s3hook

[GitBox]

codecov-io commented on issue #8304: [Airflow-5565] Add extra_args param to 
s3hook
URL: https://github.com/apache/airflow/pull/8304#issuecomment-613717834
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=h1) 
Report
   > Merging 
[#8304](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a143629ef992dd22aaa5ad16ef888a27bedbe98e=desc)
 will **decrease** coverage by `0.78%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/8304/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#8304  +/-   ##
   ==
   - Coverage   88.47%   87.68%   -0.79% 
   ==
 Files 940  940  
 Lines   4535545356   +1 
   ==
   - Hits4012739771 -356 
   - Misses   5228 5585 +357 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==)
 | `96.52% <100.00%> (+0.01%)` | :arrow_up: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=)
 | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5)
 | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
   | ... and [11 
more](https://codecov.io/gh/apache/airflow/pull/8304/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=footer). 
Last update 
[a143629...393f022](https://codecov.io/gh/apache/airflow/pull/8304?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #8308: Fix Extra Links in Gannt View

[GitBox]

kaxil commented on issue #8308: Fix Extra Links in Gannt View
URL: https://github.com/apache/airflow/pull/8308#issuecomment-613717782
 
 
   > Should we add tests to avoid regression?
   
   Was just typing that  :D 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with 
common used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-596778149
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=h1) 
Report
   > Merging 
[#7650](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/45c8983306ab1c54abdacd8f870e790fad25cb37=desc)
 will **decrease** coverage by `0.76%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7650/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7650  +/-   ##
   ==
   - Coverage   88.45%   87.68%   -0.77% 
   ==
 Files 937  940   +3 
 Lines   4523445355 +121 
   ==
   - Hits4001139770 -241 
   - Misses   5223 5585 +362 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=)
 | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5)
 | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
   | ... and [16 
more](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=footer). 
Last update 
[45c8983...82205bc](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with 
common used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-596778149
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=h1) 
Report
   > Merging 
[#7650](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/45c8983306ab1c54abdacd8f870e790fad25cb37=desc)
 will **decrease** coverage by `0.76%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7650/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7650  +/-   ##
   ==
   - Coverage   88.45%   87.68%   -0.77% 
   ==
 Files 937  940   +3 
 Lines   4523445355 +121 
   ==
   - Hits4001139770 -241 
   - Misses   5223 5585 +362 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=)
 | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5)
 | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
   | ... and [16 
more](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=footer). 
Last update 
[45c8983...82205bc](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #8308: Fix Extra Links in Gannt View

[GitBox]

kaxil commented on issue #8308: Fix Extra Links in Gannt View
URL: https://github.com/apache/airflow/pull/8308#issuecomment-613716622
 
 
   I am not sure how to add a test for this. Any suggestions @ashb ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

codecov-io edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with 
common used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-596778149
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=h1) 
Report
   > Merging 
[#7650](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/45c8983306ab1c54abdacd8f870e790fad25cb37=desc)
 will **decrease** coverage by `0.76%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7650/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7650  +/-   ##
   ==
   - Coverage   88.45%   87.68%   -0.77% 
   ==
 Files 937  940   +3 
 Lines   4523445355 +121 
   ==
   - Hits4001139770 -241 
   - Misses   5223 5585 +362 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=)
 | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5)
 | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
   | ... and [16 
more](https://codecov.io/gh/apache/airflow/pull/7650/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=footer). 
Last update 
[45c8983...82205bc](https://codecov.io/gh/apache/airflow/pull/7650?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8308: Fix Extra Links in Gannt View

[GitBox]

mik-laj commented on issue #8308: Fix Extra Links in Gannt View
URL: https://github.com/apache/airflow/pull/8308#issuecomment-613716227
 
 
   Should we add tests to avoid regression?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil opened a new pull request #8308: Fix Extra Links in Gannt View

[GitBox]

kaxil opened a new pull request #8308: Fix Extra Links in Gannt View
URL: https://github.com/apache/airflow/pull/8308
 
 
   Extra link didn't appear after changes in  
https://github.com/apache/airflow/pull/8220 for Gantt View
   
   
   **Before**:
   
![image](https://user-images.githubusercontent.com/8811558/79279575-3a89c600-7ea6-11ea-898b-e39130e50960.png)
   
   **After**:
   
![image](https://user-images.githubusercontent.com/8811558/79279605-4b3a3c00-7ea6-11ea-8246-ed351c98d3ea.png)
   
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #8302: Remove unused code from Gannt View

[GitBox]

kaxil merged pull request #8302: Remove unused code from Gannt View
URL: https://github.com/apache/airflow/pull/8302
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #8302: Remove unused code from Gannt View

[GitBox]

kaxil commented on issue #8302: Remove unused code from Gannt View
URL: https://github.com/apache/airflow/pull/8302#issuecomment-613715343
 
 
   > Is extra links still working on Gantt view?
   
   No, it doesn't work. Fixing it a separate PR
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6320) Add quarterly to crontab presets

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083642#comment-17083642
 ] 

ASF subversion and git services commented on AIRFLOW-6320:
--

Commit b67a04f7e68f61f20fffda32355174f41ca63774 in airflow's branch 
refs/heads/v1-10-test from Jiajie Zhong
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b67a04f ]

[AIRFLOW-6320] Add quarterly to crontab presets (#6873)


> Add quarterly to crontab presets
> 
>
> Key: AIRFLOW-6320
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6320
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: utils
>Affects Versions: 1.10.6
>Reporter: Jiajie Zhong
>Assignee: Jiajie Zhong
>Priority: Minor
> Fix For: 1.10.11
>
>
> Add quarterly to crontab presets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (AIRFLOW-6320) Add quarterly to crontab presets

[Kaxil Naik (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaxil Naik updated AIRFLOW-6320:

Fix Version/s: (was: 2.0.0)
   1.10.11

> Add quarterly to crontab presets
> 
>
> Key: AIRFLOW-6320
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6320
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: utils
>Affects Versions: 1.10.6
>Reporter: Jiajie Zhong
>Assignee: Jiajie Zhong
>Priority: Minor
> Fix For: 1.10.11
>
>
> Add quarterly to crontab presets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj edited a comment on issue #8303: BingAds to Google storage

[GitBox]

mik-laj edited a comment on issue #8303: BingAds to Google storage
URL: https://github.com/apache/airflow/issues/8303#issuecomment-613706066
 
 
   If you are looking for Airflow experts who can write ETL/integration/etc and 
help with Airflow, I can recommend my company. 
   @turbaszek, @potiuk and me are most active Airflow contributors last time
   https://github.com/apache/airflow/graphs/contributors
   
   If you have questions, feel free to contact kamil.breg...@polidea.com.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8303: BingAds to Google storage

[GitBox]

mik-laj commented on issue #8303: BingAds to Google storage
URL: https://github.com/apache/airflow/issues/8303#issuecomment-613706066
 
 
   If you are looking for Airflow experts who can write integration and help 
with Airflow, I can recommend my company. 
   @turbaszek, @potiuk and me are most active Airflow contributors last time
   https://github.com/apache/airflow/graphs/contributors
   
   If you have questions, feel free to contact kamil.breg...@polidea.com.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7724: [AIRFLOW-1536] Inherit umask from parent process in daemon mode

[GitBox]

mik-laj commented on issue #7724: [AIRFLOW-1536] Inherit umask from parent 
process in daemon mode
URL: https://github.com/apache/airflow/pull/7724#issuecomment-613703252
 
 
   @potiuk @ivorynoise What is the progress of this PR?  I see a rich 
discussion and acceptance of the change, but can I merge these changes? Is this 
change waiting for something?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

[GitBox]

mik-laj commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery 
operators
URL: https://github.com/apache/airflow/pull/8276#issuecomment-613701658
 
 
   Airflow has a very active GCP user community.  For sure you won't run out of 
tasks.  I will try to regularly create new tickets with the ["provider: GCP" 
label](https://github.com/apache/airflow/issues?q=is%3Aissue+is%3Aopen+label%3Aprovider%3AGCP)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] alexandraabbas commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

[GitBox]

alexandraabbas commented on issue #8276: [AIRFLOW-6295] Create guide for 
BigQuery operators
URL: https://github.com/apache/airflow/pull/8276#issuecomment-613699282
 
 
   Yay! I work a lot with Airflow on GCP so I'll probably contribute more 
around that :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jloehel commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

[GitBox]

jloehel commented on a change in pull request #8256: updated _write_args on 
PythonVirtualenvOperator
URL: https://github.com/apache/airflow/pull/8256#discussion_r408456448
 
 

 ##
 File path: airflow/operators/python_operator.py
 ##
 @@ -330,13 +330,28 @@ def _write_string_args(self, filename):
 
 def _write_args(self, input_filename):
 # serialize args to file
+if self.use_dill:
+serializer = dill
+else:
+serializer = pickle
+# some args from context can't be loaded in virtual env
+invalid_args = set(['dag', 'task', 'ti'])
 
 Review comment:
   I see, it's tricky. Thanks for the detailed answers. I'll try to retrieve 
the TaskInstance or Xcom directly as a workaround.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] rcjsuen opened a new pull request #8307: Add simple tests for SqliteOperator

[GitBox]

rcjsuen opened a new pull request #8307: Add simple tests for SqliteOperator
URL: https://github.com/apache/airflow/pull/8307
 
 
   Improve code coverage by adding a few simple tests for the SqliteOperator.
   
   This was created to address one of the files mentioned by #8278.
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] alexandraabbas commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

[GitBox]

alexandraabbas commented on issue #8276: [AIRFLOW-6295] Create guide for 
BigQuery operators
URL: https://github.com/apache/airflow/pull/8276#issuecomment-613697383
 
 
   I added the bigquery howto to `operators-and-hooks-ref.rst`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj edited a comment on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

[GitBox]

mik-laj edited a comment on issue #8276: [AIRFLOW-6295] Create guide for 
BigQuery operators
URL: https://github.com/apache/airflow/pull/8276#issuecomment-613694828
 
 
   One more thing. Can you add this guide to the operators reference?
   
https://github.com/apache/airflow/blob/master/docs/operators-and-hooks-ref.rst
   https://airflow.readthedocs.io/en/latest/operators-and-hooks-ref.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery operators

[GitBox]

mik-laj commented on issue #8276: [AIRFLOW-6295] Create guide for BigQuery 
operators
URL: https://github.com/apache/airflow/pull/8276#issuecomment-613694828
 
 
   One more thing. Can you add this guide to the operators refence list?
   
https://github.com/apache/airflow/blob/master/docs/operators-and-hooks-ref.rst
   https://airflow.readthedocs.io/en/latest/operators-and-hooks-ref.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with a binary tree, grid, star

[GitBox]

mik-laj commented on issue #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with 
a binary tree, grid, star
URL: https://github.com/apache/airflow/pull/8277#issuecomment-613693536
 
 
   Thank you very much for working on this change. I need this very much in my 
upcoming works.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] KevinKobi commented on issue #8303: BingAds to Google storage

[GitBox]

KevinKobi commented on issue #8303: BingAds to Google storage
URL: https://github.com/apache/airflow/issues/8303#issuecomment-613693272
 
 
   Sadly I don't have the time. We are even paying to a company to bring the 
data for us due to lack of time to work on the ETLs from scratch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with a binary tree, grid, star

[GitBox]

mik-laj commented on issue #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with 
a binary tree, grid, star
URL: https://github.com/apache/airflow/pull/8277#issuecomment-613693089
 
 
   DAGs looks perfect. 
   
![star](https://user-images.githubusercontent.com/12058428/79276514-79b91680-7ea8-11ea-8bb7-af4b0a9bf2cb.png)
   
![tree](https://user-images.githubusercontent.com/12058428/79276524-7de53400-7ea8-11ea-9386-7e703baa6aee.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] alexandraabbas commented on a change in pull request #8276: [AIRFLOW-6295] Create guide for BigQuery operators

[GitBox]

alexandraabbas commented on a change in pull request #8276: [AIRFLOW-6295] 
Create guide for BigQuery operators
URL: https://github.com/apache/airflow/pull/8276#discussion_r408449738
 
 

 ##
 File path: docs/howto/operator/gcp/bigquery.rst
 ##
 @@ -0,0 +1,334 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+ ..   http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+Google Cloud BigQuery Operators
+===
+
+`BigQuery `__ is Google's fully managed, 
petabyte
+scale, low cost analytics data warehouse. It is a serverless Software as a 
Service
+(SaaS) that doesn't need a database administrator. It allows users to focus on
+analyzing data to find meaningful insights using familiar SQL.
+
+Airflow provides operators to manage datasets and tables, run queries and 
validate
+data.
+
+.. contents::
+  :depth: 1
+  :local:
+
+Prerequisite Tasks
+^^
+
+.. include:: _partials/prerequisite_tasks.rst
+
+.. _howto/operator:BigQueryCreateEmptyDatasetOperator:
+.. _howto/operator:BigQueryGetDatasetOperator:
+.. _howto/operator:BigQueryGetDatasetTablesOperator:
+.. _howto/operator:BigQueryPatchDatasetOperator:
+.. _howto/operator:BigQueryUpdateDatasetOperator:
+.. _howto/operator:BigQueryDeleteDatasetOperator:
 
 Review comment:
   Sure, no worries. I moved each label above the section it belongs to. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #8277: WIP : [AIRFLOW-8187] Extend elastic DAG with a binary tree, grid, star

[GitBox]

mik-laj commented on a change in pull request #8277: WIP : [AIRFLOW-8187] 
Extend elastic DAG with a binary tree, grid, star
URL: https://github.com/apache/airflow/pull/8277#discussion_r408448901
 
 

 ##
 File path: airflow/models/baseoperator.py
 ##
 @@ -1239,6 +1239,36 @@ def chain(*tasks: Union[BaseOperator, 
List[BaseOperator]]):
 up_t.set_downstream(down_t)
 
 
+def chain_as_binary_tree(*tasks: BaseOperator):
 
 Review comment:
   Can you move it to elastic_dag.py? We don't want other users to use this 
method because it is only useful for testing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] KevinKobi opened a new issue #8306: Ability to see subdags tasks within parent dag

[GitBox]

KevinKobi opened a new issue #8306: Ability to see subdags tasks within parent 
dag
URL: https://github.com/apache/airflow/issues/8306
 
 
   
   **Description**
   Ability to see subdags task within parent dag.
   The idea is to add button or something similar that will convert all subdags 
to regular view like subdag doesn't exist.
   
   **Use case / motivation**
   
   It's possible to see the tasks within subdag by zoom in  but it's not 
possible to see all the tasks from parent + all subdags in one place. This can 
become handy.
   
   
   **Related Issues**
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

[GitBox]

mik-laj commented on a change in pull request #8256: updated _write_args on 
PythonVirtualenvOperator
URL: https://github.com/apache/airflow/pull/8256#discussion_r408441020
 
 

 ##
 File path: airflow/operators/python_operator.py
 ##
 @@ -330,13 +330,28 @@ def _write_string_args(self, filename):
 
 def _write_args(self, input_filename):
 # serialize args to file
+if self.use_dill:
+serializer = dill
+else:
+serializer = pickle
+# some args from context can't be loaded in virtual env
+invalid_args = set(['dag', 'task', 'ti'])
 
 Review comment:
   This is slightly problematic. Technically this is possible, but you would 
have to create the TaskInstance object from scratch. This can be a simple code 
that will only retrieve the object using ``session.query(TaskInstance)``
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

mik-laj edited a comment on issue #7650: [AIRFLOW-7008] Add perf kit with 
common used decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613682797
 
 
   I added documentation. Does someone want to look at these changes?  That 
would be helpful. 
   CC: @zhongjiajie 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used decorators/contexts

[GitBox]

mik-laj commented on issue #7650: [AIRFLOW-7008] Add perf kit with common used 
decorators/contexts
URL: https://github.com/apache/airflow/pull/7650#issuecomment-613682797
 
 
   I added documentation. Do you want someone to look at these changes?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #8276: [Airflow-6295] Create guide for BigQuery operators

[GitBox]

mik-laj commented on a change in pull request #8276: [Airflow-6295] Create 
guide for BigQuery operators
URL: https://github.com/apache/airflow/pull/8276#discussion_r408434837
 
 

 ##
 File path: docs/howto/operator/gcp/bigquery.rst
 ##
 @@ -0,0 +1,334 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+ ..   http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+Google Cloud BigQuery Operators
+===
+
+`BigQuery `__ is Google's fully managed, 
petabyte
+scale, low cost analytics data warehouse. It is a serverless Software as a 
Service
+(SaaS) that doesn't need a database administrator. It allows users to focus on
+analyzing data to find meaningful insights using familiar SQL.
+
+Airflow provides operators to manage datasets and tables, run queries and 
validate
+data.
+
+.. contents::
+  :depth: 1
+  :local:
+
+Prerequisite Tasks
+^^
+
+.. include:: _partials/prerequisite_tasks.rst
+
+.. _howto/operator:BigQueryCreateEmptyDatasetOperator:
+.. _howto/operator:BigQueryGetDatasetOperator:
+.. _howto/operator:BigQueryGetDatasetTablesOperator:
+.. _howto/operator:BigQueryPatchDatasetOperator:
+.. _howto/operator:BigQueryUpdateDatasetOperator:
+.. _howto/operator:BigQueryDeleteDatasetOperator:
 
 Review comment:
   Can you move these labels closer to the corresponding sections, please?  
This is the last request because the rest looks good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jloehel commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

[GitBox]

jloehel commented on a change in pull request #8256: updated _write_args on 
PythonVirtualenvOperator
URL: https://github.com/apache/airflow/pull/8256#discussion_r408434493
 
 

 ##
 File path: airflow/operators/python_operator.py
 ##
 @@ -330,13 +330,28 @@ def _write_string_args(self, filename):
 
 def _write_args(self, input_filename):
 # serialize args to file
+if self.use_dill:
+serializer = dill
+else:
+serializer = pickle
+# some args from context can't be loaded in virtual env
+invalid_args = set(['dag', 'task', 'ti'])
 
 Review comment:
   Thanks mik-laj. This means that xcoms are still not working for 
PythonVirtualenvOperators, right? Can I inject the system site-packages into 
the virtualenv to get it working?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] KevinKobi commented on issue #5281: WIP: [AIRFLOW-4506] Make GIT_SYNC_DEPTH and GIT_SYNC_REV configurable

[GitBox]

KevinKobi commented on issue #5281: WIP: [AIRFLOW-4506] Make GIT_SYNC_DEPTH and 
GIT_SYNC_REV configurable
URL: https://github.com/apache/airflow/pull/5281#issuecomment-613680856
 
 
   `GIT_SYNC_REV` was added https://github.com/apache/airflow/pull/6350 but not 
`GIT_SYNC_DEPTH` :( 
   are there plans to add it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #8256: updated _write_args on PythonVirtualenvOperator

[GitBox]

mik-laj commented on a change in pull request #8256: updated _write_args on 
PythonVirtualenvOperator
URL: https://github.com/apache/airflow/pull/8256#discussion_r408432209
 
 

 ##
 File path: airflow/operators/python_operator.py
 ##
 @@ -330,13 +330,28 @@ def _write_string_args(self, filename):
 
 def _write_args(self, input_filename):
 # serialize args to file
+if self.use_dill:
+serializer = dill
+else:
+serializer = pickle
+# some args from context can't be loaded in virtual env
+invalid_args = set(['dag', 'task', 'ti'])
 
 Review comment:
   TI is a SQL Alchemy model. It is very likely that it contains references to 
another object through the`task` attribute.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8303: BingAds to Google storage

[GitBox]

mik-laj commented on issue #8303: BingAds to Google storage
URL: https://github.com/apache/airflow/issues/8303#issuecomment-613678253
 
 
   Would you like to work on this issue? Apache Airflow is an open-source 
project without paid technical support. Each code is contributed by community 
members - other Airflow users. If this issue is important to you, it is best to 
take action yourself.
   If you are interested, I invite you to read the following guides:
   Contributor Guide: 
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst
   Development Environment Guide: 
https://github.com/apache/airflow/blob/master/BREEZE.rst
   Testing Guide: https://github.com/apache/airflow/blob/master/TESTING.rst
   
   I hope this information will be helpful for you and I look forward to your 
PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj edited a comment on issue #8301: Support Duration in AwsHook when using assume role

[GitBox]

mik-laj edited a comment on issue #8301: Support Duration in AwsHook when using 
assume role
URL: https://github.com/apache/airflow/issues/8301#issuecomment-613676708
 
 
   Would you like to work on this issue?  Apache Airflow is an open-source 
project without paid technical support. Each problem is solved by community 
members - other Airflow users. If this issue is important to you, it is best to 
take action yourself.
   If you are interested, I invite you to read the following guides:
   Contributor Guide: 
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst
   Development Environment Guide: 
https://github.com/apache/airflow/blob/master/BREEZE.rst
   Testing Guide: https://github.com/apache/airflow/blob/master/TESTING.rst
   
   I hope this information will be helpful for you and I look forward to your 
PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #8301: Support Duration in AwsHook when using assume role

[GitBox]

mik-laj commented on issue #8301: Support Duration in AwsHook when using assume 
role
URL: https://github.com/apache/airflow/issues/8301#issuecomment-613676708
 
 
   Would you like to work on this issue?  Apache Airflow is an open-source 
project without paid technical support. Each problem is solved by community 
members - other Airflow users. If this issue is important to you, it is best to 
take action yourself.
   If you are interested, I invite you to read:
   Contributor Guide: 
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst
   Development Environment Guide: 
https://github.com/apache/airflow/blob/master/BREEZE.rst
   Testing Guide: https://github.com/apache/airflow/blob/master/TESTING.rst
   
   I hope this information will be helpful for you and I look forward to your 
PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success

[GitBox]

kaxil commented on a change in pull request #8299: Clarify docs for on 
delete_worker_pods_on_success
URL: https://github.com/apache/airflow/pull/8299#discussion_r408429470
 
 

 ##
 File path: airflow/config_templates/config.yml
 ##
 @@ -1754,7 +1754,9 @@
   default: "True"
 - name: delete_worker_pods_on_success
   description: |
-If True (default), worker pods will be deleted only on task success
+If True (default), worker pods will be deleted only on task success.
+Note that this feature overrides `delete_worker_pods`, so failed pods
 
 Review comment:
   ```suggestion
   Note that this feature overrides ``delete_worker_pods``, so failed 
pods
   ```
   
   As it will be rendered in an RST


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success

[GitBox]

kaxil commented on a change in pull request #8299: Clarify docs for on 
delete_worker_pods_on_success
URL: https://github.com/apache/airflow/pull/8299#discussion_r408429552
 
 

 ##
 File path: airflow/config_templates/default_airflow.cfg
 ##
 @@ -815,7 +815,9 @@ worker_container_image_pull_policy = IfNotPresent
 # If True, all worker pods will be deleted upon termination
 delete_worker_pods = True
 
-# If True (default), worker pods will be deleted only on task success
+# If True (default), worker pods will be deleted only on task success.
+# Note that this feature overrides `delete_worker_pods`, so failed pods
 
 Review comment:
   ```suggestion
   # Note that this feature overrides ``delete_worker_pods``, so failed pods
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services