[jira] [Updated] (AIRFLOW-5223) Use kind for Kubernetes in CI

2019-08-21 Thread Gerardo Curiel (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gerardo Curiel updated AIRFLOW-5223:

Description: 
This PR reimplements Kubernetes integration testing using kind, a tool for 
running local Kubernetes clusters using Docker container "nodes". The "nodes" 
are deployed inside the main airflow-testing container, so I needed to also 
install docker, hence, this particular implementation relies on 
docker-in-docker.

For completeness sake, I considered mounting the host's /var/run/docker.sock 
socket so that we could rely on the host's Docker daemon instead of running 
docker-in-docker, but I felt docker-in-docker, being a more self-contained 
implementation, offers the least amount of friction when using it locally for 
development purposes.

> Use kind for Kubernetes in CI
> -
>
> Key: AIRFLOW-5223
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5223
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: ci
>Affects Versions: 1.10.4
>Reporter: Gerardo Curiel
>Priority: Minor
> Fix For: 2.0.0
>
>
> This PR reimplements Kubernetes integration testing using kind, a tool for 
> running local Kubernetes clusters using Docker container "nodes". The "nodes" 
> are deployed inside the main airflow-testing container, so I needed to also 
> install docker, hence, this particular implementation relies on 
> docker-in-docker.
> For completeness sake, I considered mounting the host's /var/run/docker.sock 
> socket so that we could rely on the host's Docker daemon instead of running 
> docker-in-docker, but I felt docker-in-docker, being a more self-contained 
> implementation, offers the least amount of friction when using it locally for 
> development purposes.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (AIRFLOW-5223) Use kind for Kubernetes in CI

2019-08-15 Thread Gerardo Curiel (JIRA)
Gerardo Curiel created AIRFLOW-5223:
---

 Summary: Use kind for Kubernetes in CI
 Key: AIRFLOW-5223
 URL: https://issues.apache.org/jira/browse/AIRFLOW-5223
 Project: Apache Airflow
  Issue Type: Improvement
  Components: ci
Affects Versions: 1.10.4
Reporter: Gerardo Curiel
 Fix For: 2.0.0






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (AIRFLOW-4298) Stop Scheduler warning repeatedly about "connection invalidated"

2019-05-12 Thread Gerardo Curiel (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838267#comment-16838267
 ] 

Gerardo Curiel commented on AIRFLOW-4298:
-

[~ash]
According to some reports in the Slack group (and my own experience), the 
message is showing up every 11 seconds. Here's the source: 
https://github.com/apache/airflow/blob/master/airflow/utils/sqlalchemy.py#L76.

It's coming from Airflow itself, not sqlalchemy.

> Stop Scheduler warning repeatedly about "connection invalidated"
> 
>
> Key: AIRFLOW-4298
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4298
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: scheduler
>Affects Versions: 1.10.3
> Environment: Main host with airflow services: Cent-OS 7, Python 3.6.1.
> DB - official Docker image with Postgresql 11.2-alpine
>Reporter: Anton Cherkasov
>Priority: Minor
>
> I have some strange issue with scheduler after upgrade to 1.10.3 from 1.10.2. 
> DAG tasks runs only once. After that scheduler logs looks like this:
> {noformat}
> Apr 11 09:21:33 airflow.infra airflow[32739]: [2019-04-11 09:21:33,094] 
> {{sqlalchemy.py:81}} WARNING - DB connection invalidated. Reconnecting...
> Apr 11 09:21:44 airflow.infra airflow[32739]: [2019-04-11 09:21:44,105] 
> {{sqlalchemy.py:81}} WARNING - DB connection invalidated. Reconnecting...
> Apr 11 09:21:55 airflow.infra airflow[32739]: [2019-04-11 09:21:55,114] 
> {{sqlalchemy.py:81}} WARNING - DB connection invalidated. Reconnecting...
> Apr 11 09:22:06 airflow.infra airflow[32739]: [2019-04-11 09:22:06,123] 
> {{sqlalchemy.py:81}} WARNING - DB connection invalidated. Reconnecting...
> Apr 11 09:22:17 airflow.infra airflow[32739]: [2019-04-11 09:22:17,131] 
> {{sqlalchemy.py:81}} WARNING - DB connection invalidated. Reconnecting...
> Apr 11 09:22:28 airflow.infra airflow[32739]: [2019-04-11 09:22:28,143] 
> {{sqlalchemy.py:81}} WARNING - DB connection invalidated. Reconnecting...
> {noformat}
> Logs from Scheduler with *DEBUG* level:
> {noformat}
> Apr 11 09:00:47 airflow.infra airflow[17403]: [2019-04-11 09:00:47,720] 
> {{settings.py:154}} DEBUG - Setting up DB connection pool (PID 17447)
> Apr 11 09:00:47 airflow.infra airflow[17403]: [2019-04-11 09:00:47,720] 
> {{settings.py:182}} INFO - settings.configure_orm(): Using pool settings. 
> pool_size=100, pool_recycle=3600, pid=17447
> Apr 11 09:00:48 airflow.infra airflow[17403]: [2019-04-11 09:00:48,450] 
> {{settings.py:206}} DEBUG - Disposing DB connection pool (PID 17449)
> Apr 11 09:00:48 airflow.infra airflow[17403]: [2019-04-11 09:00:48,535] 
> {{settings.py:206}} DEBUG - Disposing DB connection pool (PID 17448)
> Apr 11 09:00:48 airflow.infra airflow[17403]: [2019-04-11 09:00:48,706] 
> {{jobs.py:1663}} DEBUG - Sleeping for 1.00 seconds to prevent excessive 
> logging
> . . .
> Apr 11 09:01:29 airflow.infra airflow[17403]: [2019-04-11 09:01:29,884] 
> {{settings.py:206}} DEBUG - Disposing DB connection pool (PID 21866)
> Apr 11 09:01:30 airflow.infra airflow[17403]: [2019-04-11 09:01:30,492] 
> {{settings.py:206}} DEBUG - Disposing DB connection pool (PID 21865)
> Apr 11 09:01:30 airflow.infra airflow[17403]: [2019-04-11 09:01:30,785] 
> {{jobs.py:496}} DEBUG - Waiting for  stopped)>
> Apr 11 09:01:30 airflow.infra airflow[17403]: [2019-04-11 09:01:30,786] 
> {{jobs.py:496}} DEBUG - Waiting for  stopped)>
> Apr 11 09:01:30 airflow.infra airflow[17403]: [2019-04-11 09:01:30,790] 
> {{sqlalchemy.py:81}} WARNING - DB connection invalidated. Reconnecting...
> Apr 11 09:01:31 airflow.infra airflow[17403]: [2019-04-11 09:01:31,765] 
> {{settings.py:206}} DEBUG - Disposing DB connection pool (PID 21910)
> Apr 11 09:01:31 airflow.infra airflow[17403]: [2019-04-11 09:01:31,786] 
> {{jobs.py:496}} DEBUG - Waiting for  stopped)>
> Apr 11 09:01:31 airflow.infra airflow[17403]: [2019-04-11 09:01:31,866] 
> {{settings.py:206}} DEBUG - Disposing DB connection pool (PID 21909)
> Apr 11 09:01:32 airflow.infra airflow[17403]: [2019-04-11 09:01:32,468] 
> {{settings.py:206}} DEBUG - Disposing DB connection pool (PID 21921)
> Apr 11 09:01:32 airflow.infra airflow[17403]: [2019-04-11 09:01:32,787] 
> {{jobs.py:496}} DEBUG - Waiting for  stopped)>
> Apr 11 09:01:32 airflow.infra airflow[17403]: [2019-04-11 09:01:32,787] 
> {{jobs.py:496}} DEBUG - Waiting for  stopped)>
> Apr 11 09:01:33 airflow.infra airflow[17403]: [2019-04-11 09:01:33,358] 
> {{settings.py:206}} DEBUG - Disposing DB connection pool (PID 21933)
> Apr 11 09:01:33 airflow.infra airflow[17403]: [2019-04-11 09:01:33,521] 
> {{settings.py:206}} DEBUG - Disposing DB connection pool (PID 21934)
> Apr 11 09:01:33 airflow.infra airflow[17403]: [2019-04-11 09:01:33,788] 
> {{jobs.py:496}} DEBUG - Waiting for  stopped)>
> Apr 11 09:01:33 

[jira] [Commented] (AIRFLOW-2806) test_mark_success_no_kill test breaks intermittently on CI

2019-03-19 Thread Gerardo Curiel (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796497#comment-16796497
 ] 

Gerardo Curiel commented on AIRFLOW-2806:
-

[~kaxilnaik] according to https://github.com/apache/airflow/pull/3646, the 
author wasn't able to reproduce the issue consistently. I haven't seen this 
error in recent builds either.

> test_mark_success_no_kill test breaks intermittently on CI
> --
>
> Key: AIRFLOW-2806
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2806
> Project: Apache Airflow
>  Issue Type: Bug
>Reporter: Taylor Edmiston
>Assignee: Taylor Edmiston
>Priority: Minor
>
> The test_mark_success_no_kill test is breaking intermittently on the CI for 
> some versions of Python and some databases, particularly Python 3.5 for both 
> PostgreSQL and MySQL.
> A traceback of the error is 
> ([link|https://travis-ci.org/apache/incubator-airflow/jobs/407522994#L5668-L5701]):
> {code:java}
> 10) ERROR: test_mark_success_no_kill (tests.transplant_class..C)
> --
>  Traceback (most recent call last):
>  tests/jobs.py line 1116 in test_mark_success_no_kill
>  ti.refresh_from_db()
>  airflow/utils/db.py line 74 in wrapper
>  return func(*args, **kwargs)
>  /opt/python/3.5.5/lib/python3.5/contextlib.py line 66 in __exit__
>  next(self.gen)
>  airflow/utils/db.py line 45 in create_session
>  session.commit()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/orm/session.py
>  line 927 in commit
>  self.transaction.commit()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/orm/session.py
>  line 471 in commit
>  t[1].commit()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 1632 in commit
>  self._do_commit()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 1663 in _do_commit
>  self.connection._commit_impl()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 723 in _commit_impl
>  self._handle_dbapi_exception(e, None, None, None, None)
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 1402 in _handle_dbapi_exception
>  exc_info
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/util/compat.py
>  line 203 in raise_from_cause
>  reraise(type(exception), exception, tb=exc_tb, cause=cause)
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/util/compat.py
>  line 186 in reraise
>  raise value.with_traceback(tb)
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 721 in _commit_impl
>  self.engine.dialect.do_commit(self.connection)
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/default.py
>  line 443 in do_commit
>  dbapi_connection.commit()
>  OperationalError: (psycopg2.OperationalError) server closed the connection 
> unexpectedly
>  This probably means the server terminated abnormally{code}
> It seems to be erroring out on trying to 
> [commit|http://initd.org/psycopg/docs/connection.html#connection.commit] the 
> pending transaction to the database, possibly because the connection has been 
> closed. What's weird is that this line is already in a try-except block 
> catching all exceptions, but I think it's somehow not entering the except 
> clause.
> [https://github.com/apache/incubator-airflow/blob/f3b6b60c4809afdde916e8982a300f942f26109b/airflow/utils/db.py#L36-L50]
> Note: This is a follow up to AIRFLOW-2801 ([PR 
> #3642|https://github.com/apache/incubator-airflow/pull/3642]) which provided 
> a short-term solution by skipping the flaky test.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-912) Refactor tests and build matrix

2019-03-18 Thread Gerardo Curiel (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795649#comment-16795649
 ] 

Gerardo Curiel commented on AIRFLOW-912:


[~bolke] is this ticket and its subtasks still relevant?

> Refactor tests and build matrix
> ---
>
> Key: AIRFLOW-912
> URL: https://issues.apache.org/jira/browse/AIRFLOW-912
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: ci, tests
>Affects Versions: 1.8.0rc4
>Reporter: Bolke de Bruin
>Priority: Major
> Fix For: 1.10.0
>
>
> Placeholder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-2488) Speed up the CI

2019-03-18 Thread Gerardo Curiel (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795646#comment-16795646
 ] 

Gerardo Curiel commented on AIRFLOW-2488:
-

[~Fokko] I was mentioning in https://issues.apache.org/jira/browse/AIRFLOW-2556 
that we should get more specific about how much time we aim to reduce from the 
build time.

For the record, this is how it looks like now:

[success] 7.66% tests.test_jobs.BackfillJobTest.test_backfill_examples: 
{color:#FF}121.3222s{color}
 [success] 4.62% tests.test_jobs.BackfillJobTest.test_backfill_multi_dates: 
{color:#FF}73.1436s{color}
 [success] 3.80% 
tests.contrib.sensors.test_python_sensor.PythonSensorTests.test_python_sensor_false:
 {color:#FF}60.1841s{color}
 [success] 2.75% tests.transplant_class..C.test_backfill: 
{color:#FF}43.6282s{color}
 [success] 1.90% 
tests.executors.test_celery_executor.CeleryExecutorTest.test_celery_integration_1_redis_redis_6379_0:
 {color:#FF}30.0887s{color}
 [success] 1.88% 
tests.test_impersonation.ImpersonationTest.test_impersonation_subdag: 
{color:#FF}29.7641s{color}
 [success] 1.39% 
tests.test_jobs.SchedulerJobTest.test_new_import_error_replaces_old: 
{color:#FF}22.1033s{color}
 [success] 1.33% 
tests.test_jobs.BackfillJobTest.test_run_ignores_all_dependencies: 
{color:#FF}21.1023s{color}


> Speed up the CI
> ---
>
> Key: AIRFLOW-2488
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2488
> Project: Apache Airflow
>  Issue Type: Improvement
>Reporter: Fokko Driesprong
>Priority: Major
>
> Some of the tests take far to long:
> {{[success] 14.51% tests.BackfillJobTest.test_backfill_examples: 259.7899s
> [success] 4.29% tests.hooks.test_s3_hook.TestS3Hook.test_list_keys_paged: 
> 76.7397s
> [success] 4.18% tests.hooks.test_s3_hook.TestS3Hook.test_list_prefixes_paged: 
> 74.8025s
> [success] 2.58% tests.BackfillJobTest.test_backfill_multi_dates: 46.1206s
> [success] 2.38% tests.SchedulerJobTest.test_scheduler_start_date: 42.5719s
> [success] 1.95% 
> tests.CoreTest.test_schedule_dag_no_end_date_up_to_today_only: 34.9399s
> [success] 1.71% tests.CliTests.test_backfill: 30.5825s
> [success] 1.70% tests.SchedulerJobTest.test_scheduler_multiprocessing: 
> 30.3580s
> [success] 1.68% 
> tests.contrib.hooks.test_gcp_mlengine_hook.TestMLEngineHook.test_create_mlengine_job:
>  30.0609s
> [success] 1.68% tests.SchedulerJobTest.test_new_import_error_replaces_old: 
> 29.9968s}}
> These tests should be refactored to make them faster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-2556) Reduce time spent on unit tests

2019-03-18 Thread Gerardo Curiel (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795643#comment-16795643
 ] 

Gerardo Curiel commented on AIRFLOW-2556:
-

[~ash] [~bolke] I've seen quite a few PRs addressing issues that, little by 
little, have improved build times, although it seems the times are roughly the 
same. This is how it looks right now:

*Today:* https://www.travis-ci.org/apache/airflow/builds/507993140
*10 months ago:* https://travis-ci.org/apache/airflow/builds/387401660 

There's more infrastructure now than before so we have to account for that. 
Should we close this ticket? If not, maybe we should get more specific and 
specify how much time we aim to reduce from the build time. 

Also remember, we will be able to shave some time off very easily when we 
deprecate python2.7 or split the repos in airflow-core and airflow-contrib, but 
that seems far away.

> Reduce time spent on unit tests
> ---
>
> Key: AIRFLOW-2556
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2556
> Project: Apache Airflow
>  Issue Type: Improvement
>Reporter: Bolke de Bruin
>Priority: Major
>
> Unit tests are taking up way too much time. This costs time and actually also 
> Money from the Apache Foundation. We need to reduce this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-2569) test_scheduler_run_duration is flaky

2019-03-18 Thread Gerardo Curiel (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795624#comment-16795624
 ] 

Gerardo Curiel commented on AIRFLOW-2569:
-

[~kaxilnaik] this doesn't seem to be an issue anymore. It can be closed.


> test_scheduler_run_duration is flaky
> 
>
> Key: AIRFLOW-2569
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2569
> Project: Apache Airflow
>  Issue Type: Bug
>Reporter: Chao-Han Tsai
>Assignee: Chao-Han Tsai
>Priority: Major
>
> test_scheduler_run_duration is a flaky test that need to be fixed.
> logs: [https://api.travis-ci.org/v3/job/388141915/log.txt]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-2806) test_mark_success_no_kill test breaks intermittently on CI

2019-03-18 Thread Gerardo Curiel (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795623#comment-16795623
 ] 

Gerardo Curiel commented on AIRFLOW-2806:
-

[~kaxilnaik] this can be closed

> test_mark_success_no_kill test breaks intermittently on CI
> --
>
> Key: AIRFLOW-2806
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2806
> Project: Apache Airflow
>  Issue Type: Bug
>Reporter: Taylor Edmiston
>Assignee: Taylor Edmiston
>Priority: Minor
>
> The test_mark_success_no_kill test is breaking intermittently on the CI for 
> some versions of Python and some databases, particularly Python 3.5 for both 
> PostgreSQL and MySQL.
> A traceback of the error is 
> ([link|https://travis-ci.org/apache/incubator-airflow/jobs/407522994#L5668-L5701]):
> {code:java}
> 10) ERROR: test_mark_success_no_kill (tests.transplant_class..C)
> --
>  Traceback (most recent call last):
>  tests/jobs.py line 1116 in test_mark_success_no_kill
>  ti.refresh_from_db()
>  airflow/utils/db.py line 74 in wrapper
>  return func(*args, **kwargs)
>  /opt/python/3.5.5/lib/python3.5/contextlib.py line 66 in __exit__
>  next(self.gen)
>  airflow/utils/db.py line 45 in create_session
>  session.commit()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/orm/session.py
>  line 927 in commit
>  self.transaction.commit()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/orm/session.py
>  line 471 in commit
>  t[1].commit()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 1632 in commit
>  self._do_commit()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 1663 in _do_commit
>  self.connection._commit_impl()
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 723 in _commit_impl
>  self._handle_dbapi_exception(e, None, None, None, None)
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 1402 in _handle_dbapi_exception
>  exc_info
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/util/compat.py
>  line 203 in raise_from_cause
>  reraise(type(exception), exception, tb=exc_tb, cause=cause)
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/util/compat.py
>  line 186 in reraise
>  raise value.with_traceback(tb)
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/base.py
>  line 721 in _commit_impl
>  self.engine.dialect.do_commit(self.connection)
>  
> .tox/py35-backend_postgres/lib/python3.5/site-packages/sqlalchemy/engine/default.py
>  line 443 in do_commit
>  dbapi_connection.commit()
>  OperationalError: (psycopg2.OperationalError) server closed the connection 
> unexpectedly
>  This probably means the server terminated abnormally{code}
> It seems to be erroring out on trying to 
> [commit|http://initd.org/psycopg/docs/connection.html#connection.commit] the 
> pending transaction to the database, possibly because the connection has been 
> closed. What's weird is that this line is already in a try-except block 
> catching all exceptions, but I think it's somehow not entering the except 
> clause.
> [https://github.com/apache/incubator-airflow/blob/f3b6b60c4809afdde916e8982a300f942f26109b/airflow/utils/db.py#L36-L50]
> Note: This is a follow up to AIRFLOW-2801 ([PR 
> #3642|https://github.com/apache/incubator-airflow/pull/3642]) which provided 
> a short-term solution by skipping the flaky test.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-2803) Fix all ESLint issues

2019-03-18 Thread Gerardo Curiel (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795621#comment-16795621
 ] 

Gerardo Curiel commented on AIRFLOW-2803:
-

[~tedmiston] are you still working on this?

> Fix all ESLint issues
> -
>
> Key: AIRFLOW-2803
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2803
> Project: Apache Airflow
>  Issue Type: Improvement
>Reporter: Verdan Mahmood
>Assignee: Taylor Edmiston
>Priority: Major
>
> Most of the JS code in Apache Airflow has linting issues which are 
> highlighted after the integration of ESLint. 
> Once AIRFLOW-2783 merged in master branch, please fix all the javascript 
> styling issues that we have in .js and .html files. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-1739) Cleanup naming ambiguity with TestDbApiHook test class

2019-03-18 Thread Gerardo Curiel (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795616#comment-16795616
 ] 

Gerardo Curiel commented on AIRFLOW-1739:
-

[~kaxilnaik] this can be closed


> Cleanup naming ambiguity with TestDbApiHook test class
> --
>
> Key: AIRFLOW-1739
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1739
> Project: Apache Airflow
>  Issue Type: Bug
>Reporter: Andy Hadjigeorgiou
>Assignee: Andy Hadjigeorgiou
>Priority: Trivial
>
> The TestDbApiHook class creates a class whose name is TestDBApiHook - I'm 
> proposing a simple naming change to make sure the two are distinguishable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (AIRFLOW-3611) Simplified development workflow

2019-01-01 Thread Gerardo Curiel (JIRA)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-3611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gerardo Curiel updated AIRFLOW-3611:

Description: This issue is meant to track work done to implement 
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-7+Simplified+development+workflow
  (was: This issue is meant to track work done to implement 
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-7+Simplify+development+workflow)

> Simplified development workflow
> ---
>
> Key: AIRFLOW-3611
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3611
> Project: Apache Airflow
>  Issue Type: Improvement
>Reporter: Gerardo Curiel
>Priority: Minor
>
> This issue is meant to track work done to implement 
> https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-7+Simplified+development+workflow



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (AIRFLOW-3611) Simplified development workflow

2019-01-01 Thread Gerardo Curiel (JIRA)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-3611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gerardo Curiel updated AIRFLOW-3611:

Summary: Simplified development workflow  (was: Simplify development 
workflow)

> Simplified development workflow
> ---
>
> Key: AIRFLOW-3611
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3611
> Project: Apache Airflow
>  Issue Type: Improvement
>Reporter: Gerardo Curiel
>Priority: Minor
>
> This issue is meant to track work done to implement 
> https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-7+Simplify+development+workflow



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)