This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 94153d70ac fix: try002 for provider common sql (#38800)
94153d70ac is described below
commit 94153d70ac894d7c5249d183304646995d5df3e4
Author: Sebastian Daum <dau...@mediamarktsaturn.com>
AuthorDate: Mon Apr 8 23:00:12 2024 +0200
fix: try002 for provider common sql (#38800)
---
airflow/providers/common/sql/hooks/sql.py | 10 +++++++---
pyproject.toml | 2 --
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/airflow/providers/common/sql/hooks/sql.py
b/airflow/providers/common/sql/hooks/sql.py
index 3f324e4f69..7f1536a39b 100644
--- a/airflow/providers/common/sql/hooks/sql.py
+++ b/airflow/providers/common/sql/hooks/sql.py
@@ -40,7 +40,11 @@ import sqlparse
from more_itertools import chunked
from sqlalchemy import create_engine
-from airflow.exceptions import AirflowException,
AirflowProviderDeprecationWarning
+from airflow.exceptions import (
+ AirflowException,
+ AirflowOptionalProviderFeatureException,
+ AirflowProviderDeprecationWarning,
+)
from airflow.hooks.base import BaseHook
if TYPE_CHECKING:
@@ -230,7 +234,7 @@ class DbApiHook(BaseHook):
try:
from pandas.io import sql as psql
except ImportError:
- raise Exception(
+ raise AirflowOptionalProviderFeatureException(
"pandas library not installed, run: pip install "
"'apache-airflow-providers-common-sql[pandas]'."
)
@@ -257,7 +261,7 @@ class DbApiHook(BaseHook):
try:
from pandas.io import sql as psql
except ImportError:
- raise Exception(
+ raise AirflowOptionalProviderFeatureException(
"pandas library not installed, run: pip install "
"'apache-airflow-providers-common-sql[pandas]'."
)
diff --git a/pyproject.toml b/pyproject.toml
index bac8b3126c..58d1b31c4b 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -381,8 +381,6 @@ combine-as-imports = true
# All the providers modules which do not follow TRY002 yet
# cncf.kubernetes
"airflow/providers/cncf/kubernetes/operators/pod.py" = ["TRY002"]
-# common.sql
-"airflow/providers/common/sql/hooks/sql.py" = ["TRY002"]
# google
"airflow/providers/google/cloud/hooks/bigquery.py" = ["TRY002"]
"airflow/providers/google/cloud/hooks/dataflow.py" = ["TRY002"]
