[GitHub] [airflow] MatthewRBruce commented on issue #7424: [AIRFLOW-6796] Clean up DAG serializations based on last_updated

2020-03-31 Thread GitBox
MatthewRBruce commented on issue #7424: [AIRFLOW-6796] Clean up DAG 
serializations based on last_updated
URL: https://github.com/apache/airflow/pull/7424#issuecomment-606870400
 
 
   It won't delete the DAG until the last time the scheduler processed that DAG 
has surpassed `dag_cleanup_interval`. So yes, if the the DAG file was deleted, 
it will take around `dag_cleanup_interval`s for it to be removed.  I don't 
believe the DAG being updated or tasks being added/delete will come into play.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] MatthewRBruce commented on issue #7424: [AIRFLOW-6796] Clean up DAG serializations based on last_updated

2020-03-30 Thread GitBox
MatthewRBruce commented on issue #7424: [AIRFLOW-6796] Clean up DAG 
serializations based on last_updated
URL: https://github.com/apache/airflow/pull/7424#issuecomment-606012275
 
 
   @kaxil I've rebased it now - I changed how the `DagCode` entries get cleaned 
up to be based on whether there are any DAGs in the DB with matching `fileloc`s 
instead of based on what `file_paths` were found.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] MatthewRBruce commented on issue #7424: [AIRFLOW-6796] Clean up DAG serializations based on last_updated

2020-03-27 Thread GitBox
MatthewRBruce commented on issue #7424: [AIRFLOW-6796] Clean up DAG 
serializations based on last_updated
URL: https://github.com/apache/airflow/pull/7424#issuecomment-605027141
 
 
   Sure thing, I wasn't sure if this would still be needed with all the other 
serialization changes going on


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services