[GitHub] [airflow] OmerJog commented on a change in pull request #2256: [AIRFLOW-1153] Fix issue ' params ' don't pass to HiveOperator execution context

2019-05-30 Thread GitBox 
OmerJog commented on a change in pull request #2256: [AIRFLOW-1153] Fix issue ' 
params ' don't pass to HiveOperator execution context
URL: https://github.com/apache/airflow/pull/2256#discussion_r27754
 
 

 ##
 File path: airflow/utils/operator_helpers.py
 ##
 @@ -43,7 +43,8 @@ def context_to_airflow_vars(context, 
in_env_var_format=False):
 :type in_env_var_format: bool
 :return task_instance context as dict.
 """
-params = dict()
+params = context.get('params')
 
 Review comment:
   @xianping ping :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] OmerJog commented on a change in pull request #2256: [AIRFLOW-1153] Fix issue ' params ' don't pass to HiveOperator execution context

2019-04-10 Thread GitBox 
OmerJog commented on a change in pull request #2256: [AIRFLOW-1153] Fix issue ' 
params ' don't pass to HiveOperator execution context
URL: https://github.com/apache/airflow/pull/2256#discussion_r274266250
 
 

 ##
 File path: airflow/utils/operator_helpers.py
 ##
 @@ -43,7 +43,8 @@ def context_to_airflow_vars(context, 
in_env_var_format=False):
 :type in_env_var_format: bool
 :return task_instance context as dict.
 """
-params = dict()
+params = context.get('params')
 
 Review comment:
   @xianping 
   If the code you want to test is of operator_helpers.py then the test needs 
to be in:
   
https://github.com/apache/airflow/blob/master/tests/utils/test_operator_helpers.py


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services