[GitHub] [airflow] TobKed commented on a change in pull request #6306: [AIRFLOW-5632] Rename ComputeEngine operators
TobKed commented on a change in pull request #6306: [AIRFLOW-5632] Rename ComputeEngine operators URL: https://github.com/apache/airflow/pull/6306#discussion_r334100151 ## File path: airflow/contrib/hooks/gcp_compute_hook.py ## @@ -16,14 +16,30 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -"""This module is deprecated. Please use `airflow.gcp.hooks.compute`.""" +"""This module is deprecated. Please use `airflow.gcp.hooks.compute.ComputeEngineHook`.""" Review comment: I think information here shouldn't contain specific hook name, just path to module (as it was before). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on a change in pull request #6306: [AIRFLOW-5632] Rename ComputeEngine operators
TobKed commented on a change in pull request #6306: [AIRFLOW-5632] Rename ComputeEngine operators URL: https://github.com/apache/airflow/pull/6306#discussion_r334098944 ## File path: UPDATING.md ## @@ -163,7 +163,7 @@ The following table shows changes in import paths. |airflow.contrib.hooks.datastore_hook.DatastoreHook |airflow.gcp.hooks.datastore.DatastoreHook | |airflow.contrib.hooks.gcp_bigtable_hook.BigtableHook |airflow.gcp.hooks.bigtable.BigtableHook | |airflow.contrib.hooks.gcp_cloud_build_hook.CloudBuildHook |airflow.gcp.hooks.cloud_build.CloudBuildHook | -|airflow.contrib.hooks.gcp_compute_hook.GceHook |airflow.gcp.hooks.compute.GceHook | +|airflow.contrib.hooks.gcp_compute_hook.GceHook |airflow.gcp.hooks.compute.ComputeEngineOperator | Review comment: Shouldn't be `ComputeEngineHook ` instead of `ComputeEngineOperator`? I am not sure is it allowed to change some older informations. Maybe it should be done in separate information. WDY @nuclearpinguin ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on a change in pull request #6306: [AIRFLOW-5632] Rename ComputeEngine operators
TobKed commented on a change in pull request #6306: [AIRFLOW-5632] Rename ComputeEngine operators URL: https://github.com/apache/airflow/pull/6306#discussion_r334100277 ## File path: airflow/contrib/hooks/gcp_compute_hook.py ## @@ -16,14 +16,30 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -"""This module is deprecated. Please use `airflow.gcp.hooks.compute`.""" +"""This module is deprecated. Please use `airflow.gcp.hooks.compute.ComputeEngineHook`.""" import warnings # pylint: disable=unused-import -from airflow.gcp.hooks.compute import GceHook, GceOperationStatus # noqa +from airflow.gcp.hooks.compute import ComputeEngineHook # noqa warnings.warn( -"This module is deprecated. Please use `airflow.gcp.hooks.compute`.", +"This module is deprecated. airflow.gcp.hooks.compute.ComputeEngineHook`", Review comment: Same as above. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
