[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-536537383 @potiuk I've added message validation. Now when user pass message data as a string which can be base64 decoded, an additional deprecation warning will be displayed, afterwards`PubSub` exception will be raised. I've updated tests, added tests for message validation and added additional info in `UPDATING.md`. About deprecation warning for `template_fields` I think it is possible however in my opinion it will introduce unnecessary amount of complication. I've included Information about `template_filelds` in `UPDATING.md` as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-535495342 cc @mik-laj @potiuk This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-533998153 Updated due to comments, slightly improved test, rebased on last master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-533690184 I've updated `TestPubSubPullSensor` (hook mocking). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-533570181 I've rebased but due to fact than previous commits impacted PubSub significantly I had to make some changes (remove `project` from template fields, update `PubSubPullSensor` and adjust unit and system tests). Please take a look on last `fixup`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-532984150 Rebased on the last `master`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-532193257 @mik-laj Yes, hopefully PR is done. I've applied all necessary patches. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-531795029 @mik-laj I've applied changes. Please verify is correct. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
