[GitHub] [airflow] acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request
acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347498374 ## File path: UPDATING.md ## @@ -93,6 +93,28 @@ delete this option. The TriggerDagRunOperator now takes a `conf` argument to which a dict can be provided as conf for the DagRun. As a result, the `python_callable` argument was removed. PR: https://github.com/apache/airflow/pull/6317. +### Changes in experimental API execution_date microseconds replacement + +The default behavior was to strip the microseconds (and milliseconds, etc) off of all dag runs triggered by +by the experimental REST API. The default behavior will change when an explicit execution_date is +passed in the request body. It will also now be possible to have the execution_date generated, but +keep the microseconds by sending `replace_microseconds=false` in the request body. The default +behavior can be overridden by sending `replace_microseconds=true` along with an explicit execution_date + +### Additional arguments passed to BaseOperator cause an exception Review comment: fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request
acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347497640 ## File path: UPDATING.md ## @@ -93,6 +93,28 @@ delete this option. The TriggerDagRunOperator now takes a `conf` argument to which a dict can be provided as conf for the DagRun. As a result, the `python_callable` argument was removed. PR: https://github.com/apache/airflow/pull/6317. +### Changes in experimental API execution_date microseconds replacement + +The default behavior was to strip the microseconds (and milliseconds, etc) off of all dag runs triggered by +by the experimental REST API. The default behavior will change when an explicit execution_date is +passed in the request body. It will also now be possible to have the execution_date generated, but +keep the microseconds by sending `replace_microseconds=false` in the request body. The default +behavior can be overridden by sending `replace_microseconds=true` along with an explicit execution_date + +### Additional arguments passed to BaseOperator cause an exception Review comment: hmm apparently? I guess when rebasing somehow picked up extra commits This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request
acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347428247 ## File path: UPDATING.md ## @@ -41,6 +41,14 @@ assists users migrating to a new version. ## Airflow Master +### Changes in experimental API execution_date microseconds replacement + +The default behavior was to strip the microseconds (and milliseconds, etc) off of all dag runs triggered by +by the experimental REST API. The default behavior will change when an explicit execution_date is +passed in the request body. It will also now be possible to have the execution_date generated, but +keep the microseconds by sending `replace_microseconds: false` in the request body. The default Review comment: fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request
acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347428185 ## File path: UPDATING.md ## @@ -41,6 +41,14 @@ assists users migrating to a new version. ## Airflow Master +### Changes in experimental API execution_date microseconds replacement + +The default behavior was to strip the microseconds (and milliseconds, etc) off of all dag runs triggered by +by the experimental REST API. The default behavior will change when an explicit execution_date is +passed in the request body. It will also now be possible to have the execution_date generated, but +keep the microseconds by sending `replace_microseconds: false` in the request body. The default +behavior can be overridden by sending `replace_microseconds: true` along with an explicit execution_date Review comment: fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
