[GitHub] [airflow] ashb commented on a change in pull request #6620: [AIRFLOW-6023] Remove deprecated Celery configs
ashb commented on a change in pull request #6620: [AIRFLOW-6023] Remove deprecated Celery configs URL: https://github.com/apache/airflow/pull/6620#discussion_r349228457 ## File path: airflow/configuration.py ## @@ -114,14 +112,7 @@ class AirflowConfigParser(ConfigParser): # new_name, the old_name will be checked to see if it exists. If it does a # DeprecationWarning will be issued and the old name will be used instead deprecated_options = { -'celery': { -# Remove these keys in Airflow 1.11 -'worker_concurrency': 'celeryd_concurrency', -'result_backend': 'celery_result_backend', -'broker_url': 'celery_broker_url', -'ssl_active': 'celery_ssl_active', -'ssl_cert': 'celery_ssl_cert', -'ssl_key': 'celery_ssl_key', +'elasticsearch': { Review comment: (we should do this on its commit on v1.10 too) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6620: [AIRFLOW-6023] Remove deprecated Celery configs
ashb commented on a change in pull request #6620: [AIRFLOW-6023] Remove deprecated Celery configs URL: https://github.com/apache/airflow/pull/6620#discussion_r349228056 ## File path: airflow/configuration.py ## @@ -114,14 +112,7 @@ class AirflowConfigParser(ConfigParser): # new_name, the old_name will be checked to see if it exists. If it does a # DeprecationWarning will be issued and the old name will be used instead deprecated_options = { -'celery': { -# Remove these keys in Airflow 1.11 -'worker_concurrency': 'celeryd_concurrency', -'result_backend': 'celery_result_backend', -'broker_url': 'celery_broker_url', -'ssl_active': 'celery_ssl_active', -'ssl_cert': 'celery_ssl_cert', -'ssl_key': 'celery_ssl_key', +'elasticsearch': { Review comment: Did we never fix this?! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services