[GitHub] [airflow] ashb commented on a change in pull request #8757: Fix the incorrect description of pod_mutation_hook in kubernetes.rst

2020-05-08 Thread GitBox


ashb commented on a change in pull request #8757:
URL: https://github.com/apache/airflow/pull/8757#discussion_r422377934



##
File path: docs/kubernetes.rst
##
@@ -40,11 +40,44 @@ that has the ability to mutate pod objects before sending 
them to the Kubernetes
 for scheduling. It receives a single argument as a reference to pod objects, 
and
 is expected to alter its attributes.
 
-This could be used, for instance, to add sidecar or init containers
+This could be used, for instance, to add init containers
 to every worker pod launched by KubernetesExecutor or KubernetesPodOperator.
 
 
 .. code:: python
 
 def pod_mutation_hook(pod: Pod):
   pod.annotations['airflow.apache.org/launched-by'] = 'Tests'
+
+
+The structure of 'pod' that is an argument of pod_mutation_hook are as follows.
+
+.. code:: python
+
+affinity:   {}
+annotations:  {}
+args: []
+cmds: []
+configmaps:  []
+dnspolicy:
+Noneenvs:   {}

Review comment:
   I don't thin this name is right.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow] ashb commented on a change in pull request #8757: Fix the incorrect description of pod_mutation_hook in kubernetes.rst

2020-05-08 Thread GitBox


ashb commented on a change in pull request #8757:
URL: https://github.com/apache/airflow/pull/8757#discussion_r422377856



##
File path: docs/kubernetes.rst
##
@@ -40,11 +40,44 @@ that has the ability to mutate pod objects before sending 
them to the Kubernetes
 for scheduling. It receives a single argument as a reference to pod objects, 
and
 is expected to alter its attributes.
 
-This could be used, for instance, to add sidecar or init containers
+This could be used, for instance, to add init containers

Review comment:
   It can be used for sidecar containers too can't it?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org