[GitHub] [airflow] ashb commented on issue #3719: [AIRFLOW-2874] Enables FAB's theme support
ashb commented on issue #3719: [AIRFLOW-2874] Enables FAB's theme support URL: https://github.com/apache/airflow/pull/3719#issuecomment-481651508 @holandes22 Take out of bootstrap-theme.css and put in our main.css This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #3719: [AIRFLOW-2874] Enables FAB's theme support
ashb commented on issue #3719: [AIRFLOW-2874] Enables FAB's theme support URL: https://github.com/apache/airflow/pull/3719#issuecomment-479477253 @holandes22 Yeah, that fix should probably be removed from that file (which is not loaded when using an alternate them) and put in our other css file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #3719: [AIRFLOW-2874] Enables FAB's theme support
ashb commented on issue #3719: [AIRFLOW-2874] Enables FAB's theme support URL: https://github.com/apache/airflow/pull/3719#issuecomment-473407419 Yup, not great at all. See https://github.com/dpgaspar/Flask-AppBuilder/issues/504, and if we don't fix it there in FAB we can fix something oursleves in Airflow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #3719: [AIRFLOW-2874] Enables FAB's theme support
ashb commented on issue #3719: [AIRFLOW-2874] Enables FAB's theme support URL: https://github.com/apache/airflow/pull/3719#issuecomment-473351730 The problem right now is that the APP_THEME setting (which lives in `webserver_config.py`) is hard-coded to look under `/static/appbuilder/css/themes/$APP_THEME` - i.e. to use a custom theme, you have to place it inside the installed flask_appbuilder package folder in site-packages! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
