[GitHub] [airflow] ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when appropriate to speed up task execution.

2019-12-06 Thread GitBox
ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when 
appropriate to speed up task execution.
URL: https://github.com/apache/airflow/pull/6627#issuecomment-559120739
 
 
   I need to investigate what is happening with task logging, but otherwise 
this PR is working and the code is to my satisfaction.
   
   - [x] Test S3 Log handler
   - [x] Test Elasticseach log handler
   - [ ] Test Elasticsaerch JSON format/output
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when appropriate to speed up task execution.

2019-12-06 Thread GitBox
ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when 
appropriate to speed up task execution.
URL: https://github.com/apache/airflow/pull/6627#issuecomment-559120739
 
 
   I need to investigate what is happening with task logging, but otherwise 
this PR is working and the code is to my satisfaction.
   
   - [x] Test S3 Log handler
   - [x] Test Elasticseach log handler
   - [x] Test Elasticsaerch JSON format/output
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when appropriate to speed up task execution.

2019-12-06 Thread GitBox
ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when 
appropriate to speed up task execution.
URL: https://github.com/apache/airflow/pull/6627#issuecomment-559120739
 
 
   I need to investigate what is happening with task logging, but otherwise 
this PR is working and the code is to my satisfaction.
   
   - [ ] Test S3 Log handler
   - [ ] Test Elasticseach log handler
   - [ ] Test Elasticsaerch JSON format/output
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when appropriate to speed up task execution.

2019-12-06 Thread GitBox
ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when 
appropriate to speed up task execution.
URL: https://github.com/apache/airflow/pull/6627#issuecomment-559120739
 
 
   I need to investigate what is happening with task logging, but otherwise 
this PR is working and the code is to my satisfaction.
   
   - [x] Test S3 Log handler
   - [ ] Test Elasticseach log handler
   - [ ] Test Elasticsaerch JSON format/output
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when appropriate to speed up task execution.

2019-11-25 Thread GitBox
ashb edited a comment on issue #6627: [AIRFLOW-5931] Use os.fork when 
appropriate to speed up task execution.
URL: https://github.com/apache/airflow/pull/6627#issuecomment-558218275
 
 
   Right this should now pass it's tests (I had problems with the logging 
causing an infinite loop, decided the fix for that was to just re-configure the 
logging in the subprocess.)
   
   ✅ on my fork: https://travis-ci.com/ashb/airflow/builds/138072561


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services