[GitHub] [airflow] csm10495 commented on pull request #28808: Allow setting the name for the base container within K8s Pod Operator
csm10495 commented on PR #28808: URL: https://github.com/apache/airflow/pull/28808#issuecomment-1399136793 Also does that change it just for the instance or for the class if done that way? .. I'd have to check to know for sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] csm10495 commented on pull request #28808: Allow setting the name for the base container within K8s Pod Operator
csm10495 commented on PR #28808: URL: https://github.com/apache/airflow/pull/28808#issuecomment-1399135597 It doesn't really match how params are normally passed through. Also it would look kind of weird in a taskflow dag. I think the PR as is makes a bit more sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] csm10495 commented on pull request #28808: Allow setting the name for the base container within K8s Pod Operator
csm10495 commented on PR #28808: URL: https://github.com/apache/airflow/pull/28808#issuecomment-1384319670 @eladkal can you check again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] csm10495 commented on pull request #28808: Allow setting the name for the base container within K8s Pod Operator
csm10495 commented on PR #28808: URL: https://github.com/apache/airflow/pull/28808#issuecomment-1381019209 @jedcunningham check again when you can. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
