[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers

2023-03-03 Thread via GitHub


eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1124408556


##
airflow/providers/amazon/CHANGELOG.rst:
##
@@ -24,6 +24,35 @@
 Changelog
 -
 
+7.3.0
+.
+
+Features
+
+
+* ``add num rows affected to Redshift Data API hook (#29797)``
+* ``Add 'wait_for_completion' param in 'RedshiftCreateClusterOperator' 
(#29657)``
+* ``Add Amazon Redshift-data to S3<>RS Transfer Operators (#27947)``
+* ``Allow to specify which connection, variable or config are being looked up 
in the backend using *_lookup_pattern parameters (#29580)``
+* ``Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity 
(#29623)``
+* ``Implement custom boto waiters for some EMR operators (#29822)``
+
+Bug Fixes
+~
+
+* ``fix code checking job names in sagemaker (#29245)``
+* ``Avoid emitting fallback message for S3TaskHandler if streaming logs 
(#29708)``
+* ``Fix Amazon ECS Enums (#29871)``
+
+Misc
+
+
+* ``Impovements for RedshiftDataOperator: better error reporting and an 
ability to return SQL results (#29434)``
+* ``Use waiters in ECS Operators instead of inner sensors (#29761)``

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers

2023-03-03 Thread via GitHub


eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1124394857


##
airflow/providers/amazon/CHANGELOG.rst:
##
@@ -24,6 +24,35 @@
 Changelog
 -
 
+7.3.0
+.
+
+Features
+
+
+* ``add num rows affected to Redshift Data API hook (#29797)``
+* ``Add 'wait_for_completion' param in 'RedshiftCreateClusterOperator' 
(#29657)``
+* ``Add Amazon Redshift-data to S3<>RS Transfer Operators (#27947)``
+* ``Allow to specify which connection, variable or config are being looked up 
in the backend using *_lookup_pattern parameters (#29580)``
+* ``Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity 
(#29623)``
+* ``Implement custom boto waiters for some EMR operators (#29822)``
+
+Bug Fixes
+~
+
+* ``fix code checking job names in sagemaker (#29245)``
+* ``Avoid emitting fallback message for S3TaskHandler if streaming logs 
(#29708)``
+* ``Fix Amazon ECS Enums (#29871)``
+
+Misc
+
+
+* ``Impovements for RedshiftDataOperator: better error reporting and an 
ability to return SQL results (#29434)``
+* ``Use waiters in ECS Operators instead of inner sensors (#29761)``

Review Comment:
   see 
https://github.com/apache/airflow/pull/29878/commits/759962e06a4fef20c8754cd9a6b1508b1cc5edd6



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers

2023-03-03 Thread via GitHub


eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1124392745


##
airflow/providers/amazon/CHANGELOG.rst:
##
@@ -24,6 +24,35 @@
 Changelog
 -
 
+7.3.0
+.
+
+Features
+
+
+* ``add num rows affected to Redshift Data API hook (#29797)``
+* ``Add 'wait_for_completion' param in 'RedshiftCreateClusterOperator' 
(#29657)``
+* ``Add Amazon Redshift-data to S3<>RS Transfer Operators (#27947)``
+* ``Allow to specify which connection, variable or config are being looked up 
in the backend using *_lookup_pattern parameters (#29580)``
+* ``Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity 
(#29623)``
+* ``Implement custom boto waiters for some EMR operators (#29822)``
+
+Bug Fixes
+~
+
+* ``fix code checking job names in sagemaker (#29245)``
+* ``Avoid emitting fallback message for S3TaskHandler if streaming logs 
(#29708)``
+* ``Fix Amazon ECS Enums (#29871)``
+
+Misc
+
+
+* ``Impovements for RedshiftDataOperator: better error reporting and an 
ability to return SQL results (#29434)``
+* ``Use waiters in ECS Operators instead of inner sensors (#29761)``

Review Comment:
   I can hide entries from the change log if needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers

2023-03-02 Thread via GitHub


eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1123572510


##
airflow/providers/mysql/CHANGELOG.rst:
##
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
 Changelog
 -
 
+4.0.2
+.
+
+Misc
+
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend 
(#29519)``

Review Comment:
   We know we want to move to newsfragment... just no one had the time to make 
it happen yet



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers

2023-03-02 Thread via GitHub


eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1123452723


##
airflow/providers/mysql/CHANGELOG.rst:
##
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
 Changelog
 -
 
+4.0.2
+.
+
+Misc
+
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend 
(#29519)``

Review Comment:
   We can not
   The proccess of release look for exact match between commit title and 
changelog. this is also why we can not manually fix typos :(
   
   What we can do if you feel we need better description here is to add more 
free text above this line (like we do for breaking changes). Do you have 
something in mind?



##
airflow/providers/mysql/CHANGELOG.rst:
##
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
 Changelog
 -
 
+4.0.2
+.
+
+Misc
+
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend 
(#29519)``

Review Comment:
   We can not
   The process of release look for exact match between commit title and 
changelog. this is also why we can not manually fix typos :(
   
   What we can do if you feel we need better description here is to add more 
free text above this line (like we do for breaking changes). Do you have 
something in mind?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers

2023-03-02 Thread via GitHub


eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1123452723


##
airflow/providers/mysql/CHANGELOG.rst:
##
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
 Changelog
 -
 
+4.0.2
+.
+
+Misc
+
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend 
(#29519)``

Review Comment:
   We can not :(
   The mechanisem of release look for exact match between commit title and 
changelog. this is also why we can not manually fix typos :(
   
   What we can do if you feel we need better description here is to add more 
free text above this line (like we do for breaking changes). Do you have 
something in mind?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org