[GitHub] [airflow] feluelle commented on issue #5994: [AIRFLOW-5395] Fix unloading with column names containing a dot in RedshiftToS3Operator
feluelle commented on issue #5994: [AIRFLOW-5395] Fix unloading with column names containing a dot in RedshiftToS3Operator URL: https://github.com/apache/airflow/pull/5994#issuecomment-541087863 Closed in favor of #6309 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] feluelle commented on issue #5994: [AIRFLOW-5395] Fix unloading with column names containing a dot in RedshiftToS3Operator
feluelle commented on issue #5994: [AIRFLOW-5395] Fix unloading with column names containing a dot in RedshiftToS3Operator URL: https://github.com/apache/airflow/pull/5994#issuecomment-538339594 > @feluelle Thought if you want to "take-over" the other PR that might be better - open a new PR, fix the issues and annotate the commit with `Co-authored-by:`? https://github.blog/2018-01-29-commit-together-with-co-authors/ Will do that - on monday when I am back at a "good" computer This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] feluelle commented on issue #5994: [AIRFLOW-5395] Fix unloading with column names containing a dot in RedshiftToS3Operator
feluelle commented on issue #5994: [AIRFLOW-5395] Fix unloading with column names containing a dot in RedshiftToS3Operator URL: https://github.com/apache/airflow/pull/5994#issuecomment-536299589 @OmerJog that's true, but if the other one gets merged this change is superfluous. I resolved conflicts. Can you review it since you were also interested in the other one ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] feluelle commented on issue #5994: [AIRFLOW-5395] Fix unloading with column names containing a dot in RedshiftToS3Operator
feluelle commented on issue #5994: [AIRFLOW-5395] Fix unloading with column names containing a dot in RedshiftToS3Operator URL: https://github.com/apache/airflow/pull/5994#issuecomment-527566459 I just saw there is a PR #4610 which adds the new `HEADER` argument and apparently the author stopped working on it. So should I implement that here instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
