[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins

[GitBox]

j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-653715178


   > @j-y-matsubara would you mind a rebase? The k8s tests should be fixed now
   
   Sure.
   
   All tests were passed!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins

[GitBox]

j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-653371144


   The same k8s error that has nothing to do with this PR as last time.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins

[GitBox]

j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-652898769


    I think the two failure of k8s tests doesn't seem to have anything to 
do with this PR. The same error occurs in other PRs. :(



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins

[GitBox]

j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-652534766


   There was an error.
   I will fix it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins

[GitBox]

j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-651678532


   I think the one failure of tests doesn't seem to have anything to do with 
this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins

[GitBox]

j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-651621009


   I think the one failure of tests doesn't seem to have anything to do with 
this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins : .pluginingore

[GitBox]

j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-650793451


   Many errors will be fixed at a later date.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins : .pluginingore

[GitBox]

j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-650781887


   > Could you add some tests? For plugin managers testing, 
tests.test_utils.mock_plugins.mock_plugin_manager may be helpful. A perfect 
test can create the required files in a temporary directory 
(NamedTemporaryFile) and then check if the plugins have been loaded.
   
   Thank you for your advice.
   I added a test.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org