[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins : .pluginingore

2020-06-28 Thread GitBox


j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-650793451


   Many errors will be fixed at a later date.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins : .pluginingore

2020-06-28 Thread GitBox


j-y-matsubara commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-650781887


   > Could you add some tests? For plugin managers testing, 
tests.test_utils.mock_plugins.mock_plugin_manager may be helpful. A perfect 
test can create the required files in a temporary directory 
(NamedTemporaryFile) and then check if the plugins have been loaded.
   
   Thank you for your advice.
   I added a test.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org