[GitHub] [airflow] jaketf commented on issue #5166: [AIRFLOW-4397] Add GCSUploadSessionCompleteSensor

2019-04-28 Thread GitBox 
jaketf commented on issue #5166: [AIRFLOW-4397] Add 
GCSUploadSessionCompleteSensor
URL: https://github.com/apache/airflow/pull/5166#issuecomment-487412971
 
 
   @potiuk @OmerJog Sure I'll add a PR for adding the docs for the GCS sensors. 
It looks like I inherited the lack of docs from the the other GCS sensors too :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jaketf commented on issue #5166: [AIRFLOW-4397] Add GCSUploadSessionCompleteSensor

2019-04-25 Thread GitBox 
jaketf commented on issue #5166: [AIRFLOW-4397] Add 
GCSUploadSessionCompleteSensor
URL: https://github.com/apache/airflow/pull/5166#issuecomment-486863582
 
 
   @potiuk this is ready for review again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jaketf commented on issue #5166: [AIRFLOW-4397] Add GCSUploadSessionCompleteSensor

2019-04-24 Thread GitBox 
jaketf commented on issue #5166: [AIRFLOW-4397] Add 
GCSUploadSessionCompleteSensor
URL: https://github.com/apache/airflow/pull/5166#issuecomment-486449084
 
 
   @potiuk Thanks for the suggestions in your initial review. I've changed the 
logic to use the system time and update the unittests. 
   
   @OmerJog I've updated the `previous_num_files` doc string to be more clear.
   
   If either of you have any further feedback or a suggestion for a shorter 
name than `GoogleCloudStorageUploadSessionCompleteSensor` please let me know. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services