[GitHub] [airflow] mik-laj commented on a change in pull request #6045: [AIRFLOW-5433] Add script to check external links in docs

2019-09-07 Thread GitBox
mik-laj commented on a change in pull request #6045: [AIRFLOW-5433] Add script 
to check external links in docs
URL: https://github.com/apache/airflow/pull/6045#discussion_r321981940
 
 

 ##
 File path: Dockerfile
 ##
 @@ -62,7 +62,6 @@ RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - \
 && apt-get install -y --no-install-recommends \
apt-utils \
build-essential \
-   curl \
 
 Review comment:
   It's installed in line 52. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj commented on a change in pull request #6045: [AIRFLOW-5433] Add script to check external links in docs

2019-09-07 Thread GitBox
mik-laj commented on a change in pull request #6045: [AIRFLOW-5433] Add script 
to check external links in docs
URL: https://github.com/apache/airflow/pull/6045#discussion_r321976157
 
 

 ##
 File path: .pre-commit-config.yaml
 ##
 @@ -167,7 +167,7 @@ repos:
 language: docker_image
 entry: koalaman/shellcheck:stable -x -a
 types: [shell]
-files: ^breeze$|^breeze-complete$
 
 Review comment:
   I don't know why my file was not detected and I had to make these changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services