[GitHub] [airflow] mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common URL: https://github.com/apache/airflow/pull/8011#discussion_r400562737 ## File path: airflow/providers/google/cloud/hooks/automl.py ## @@ -29,10 +29,10 @@ ImageObjectDetectionModelDeploymentMetadata, InputConfig, Model, Operation, PredictResponse, TableSpec, ) -from airflow.providers.google.cloud.hooks.base import CloudBaseHook +from airflow.providers.google.common.hooks.base import GoogleBaseHook Review comment: ```suggestion from airflow.providers.google.common.hooks.base_google import GoogleBaseHook ``` We agreed to such a convention in the case of AWS. In the case of Google, we should also use it. I will add a commit to this branch, which corrects it. In next step, I will start new PR starting from this branch, which will correct other errors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common URL: https://github.com/apache/airflow/pull/8011#discussion_r400562737 ## File path: airflow/providers/google/cloud/hooks/automl.py ## @@ -29,10 +29,10 @@ ImageObjectDetectionModelDeploymentMetadata, InputConfig, Model, Operation, PredictResponse, TableSpec, ) -from airflow.providers.google.cloud.hooks.base import CloudBaseHook +from airflow.providers.google.common.hooks.base import GoogleBaseHook Review comment: ```suggestion from airflow.providers.google.common.hooks.base_google import GoogleBaseHook ``` We agreed to such a convention in the case of AWS. In the case of Google, we should also use it. I will add a commit to this branch, which corrects it, and then from this branch I will start new PR, which will correct other errors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common URL: https://github.com/apache/airflow/pull/8011#discussion_r400558577 ## File path: airflow/providers/google/cloud/hooks/discovery_api.py ## @@ -23,10 +23,10 @@ from googleapiclient.discovery import Resource, build -from airflow.providers.google.cloud.hooks.base import CloudBaseHook +from airflow.providers.google.common.hooks.base import GoogleBaseHook Review comment: Thanks for doing this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common URL: https://github.com/apache/airflow/pull/8011#discussion_r400558131 ## File path: airflow/providers/google/cloud/hooks/discovery_api.py ## @@ -23,10 +23,10 @@ from googleapiclient.discovery import Resource, build -from airflow.providers.google.cloud.hooks.base import CloudBaseHook +from airflow.providers.google.common.hooks.base import GoogleBaseHook Review comment: I will do it in a separate PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common URL: https://github.com/apache/airflow/pull/8011#discussion_r400558131 ## File path: airflow/providers/google/cloud/hooks/discovery_api.py ## @@ -23,10 +23,10 @@ from googleapiclient.discovery import Resource, build -from airflow.providers.google.cloud.hooks.base import CloudBaseHook +from airflow.providers.google.common.hooks.base import GoogleBaseHook Review comment: I will do it in a separate PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common URL: https://github.com/apache/airflow/pull/8011#discussion_r400187606 ## File path: airflow/providers/google/cloud/hooks/discovery_api.py ## @@ -23,10 +23,10 @@ from googleapiclient.discovery import Resource, build -from airflow.providers.google.cloud.hooks.base import CloudBaseHook +from airflow.providers.google.common.hooks.base import GoogleBaseHook Review comment: Should we move this hook to common package? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
