[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400410795 ## File path: tests/test_core_to_contrib.py ## @@ -1389,6 +1389,51 @@ 'airflow.providers.mysql.operators.presto_to_mysql.PrestoToMySqlTransfer', 'airflow.operators.presto_to_mysql.PrestoToMySqlTransfer', ), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLBaseOperator', +'airflow.contrib.operators.gcp_sql_operator.CloudSqlBaseOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLCreateInstanceDatabaseOperator', + 'airflow.contrib.operators.gcp_sql_operator.CloudSqlInstanceDatabaseCreateOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLCreateInstanceOperator', + 'airflow.contrib.operators.gcp_sql_operator.CloudSqlInstanceCreateOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLDeleteInstanceDatabaseOperator', + 'airflow.contrib.operators.gcp_sql_operator.CloudSqlInstanceDatabaseDeleteOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLDeleteInstanceOperator', + 'airflow.contrib.operators.gcp_sql_operator.CloudSqlInstanceDeleteOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLExecuteQueryOperator', +'airflow.contrib.operators.gcp_sql_operator.CloudSqlQueryOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLExportInstanceOperator', + 'airflow.contrib.operators.gcp_sql_operator.CloudSqlInstanceExportOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLImportInstanceOperator', + 'airflow.contrib.operators.gcp_sql_operator.CloudSqlInstanceImportOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLInstancePatchOperator', + 'airflow.contrib.operators.gcp_sql_operator.CloudSqlInstancePatchOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLPatchInstanceDatabaseOperator', + 'airflow.contrib.operators.gcp_sql_operator.CloudSqlInstanceDatabasePatchOperator' +), +( + 'airflow.providers.google.cloud.operators.cloud_storage_transfer_service' +'.CloudDataTransferServiceS3ToGCSOperator', + 'airflow.contrib.operators.s3_to_gcs_transfer_operator.CloudDataTransferServiceS3ToGCSOperator' +), Review comment: We could move it to another PR, but I had to do it to generate a table for README.md. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400378518 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,362 @@ + + +## Changelog + +### v2020.XX.XX Review comment: The PIP project applies a similar convention. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400378191 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,362 @@ + + +## Changelog + +### v2020.XX.XX Review comment: ```suggestion ### v20.XX.XX ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400375700 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,362 @@ + + +## Changelog + +### v2020.XX.XX + +This is the first released version of the package. + +**Limitations** + +The following operators have not been released: + + * All operators for BigQuery service. + * GKEStartPodOperator for Kubernetes Engine service. + +We recommend staying with the old versions yet. These operators will be released as soon as possible. + +**New integration**: Review comment: ```suggestion **New operators**: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400365941 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,362 @@ + + +## Changelog + +### v2020.XX.XX Review comment: @potiuk Can you look at it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400272215 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,26 @@ + + +## Backport Google Package limitations: + +* Kubernetes Pod operators are imported directly from airflow.contrib. +* BigQuery operators are removed until it is refactored. This is going to happen + soon and we recommend to use the 1.10 BigQuery operators from the airflow.contrib + package. +* GKEStartPodOperator is removed as it uses functionality only available in 2.0. Review comment: What do you think about something similar to the following text? > The following operators have not been released: > * All operators for BigQuery service. > * GKEStartPodOperator for Kubernetes Engine service. > > We recommend staying with the old versions yet. These operators will be released as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400275289 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,26 @@ + + +## Backport Google Package limitations: Review comment: If you want, I can prepare these tables for you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400272215 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,26 @@ + + +## Backport Google Package limitations: + +* Kubernetes Pod operators are imported directly from airflow.contrib. +* BigQuery operators are removed until it is refactored. This is going to happen + soon and we recommend to use the 1.10 BigQuery operators from the airflow.contrib + package. +* GKEStartPodOperator is removed as it uses functionality only available in 2.0. Review comment: What do you think about something similar to the following text? > The following operators have not been made available: > * All operators for BigQuery service. > * GKEStartPodOperator for Kubernetes Engine service. > > We recommend staying with the old versions yet. These operators will be released as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400272215 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,26 @@ + + +## Backport Google Package limitations: + +* Kubernetes Pod operators are imported directly from airflow.contrib. +* BigQuery operators are removed until it is refactored. This is going to happen + soon and we recommend to use the 1.10 BigQuery operators from the airflow.contrib + package. +* GKEStartPodOperator is removed as it uses functionality only available in 2.0. Review comment: What do you think about something similar to the following text? > The following operators have not been made available: > * All operators for BigQuery service. > * GKEStartPodOperator. > > We recommend staying with the old versions yet. These operators will be released as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400272215 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,26 @@ + + +## Backport Google Package limitations: + +* Kubernetes Pod operators are imported directly from airflow.contrib. +* BigQuery operators are removed until it is refactored. This is going to happen + soon and we recommend to use the 1.10 BigQuery operators from the airflow.contrib + package. +* GKEStartPodOperator is removed as it uses functionality only available in 2.0. Review comment: The following operators have not been made available: * All operators for BigQuery service. * GKEStartPodOperator. We recommend staying with the old versions yet. These operators will be released as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400270654 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,26 @@ + + +## Backport Google Package limitations: Review comment: Can you add tables that compare Airflow 1.10 and Airflow 2? It's best if it was a few tables - one table that describes new operators, the other with moved operators. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400269444 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,26 @@ + + +## Backport Google Package limitations: + +* Kubernetes Pod operators are imported directly from airflow.contrib. Review comment: ```suggestion ``` This is not true. We use GKEPodOperator. We never use KubernetesPodOperator. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400172833 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,24 @@ + + +## Backport Google Package limitations: + +* Kubernetes Pod operators imports are refactored to contrib.kubernetes +* BigQuery operator is removed until it is refactored. Review comment: This is the expected result. I think it is worth adding information that we recommend using airflow.contrib operators and that new ones will be released soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8012: Individual package READMEs
mik-laj commented on a change in pull request #8012: Individual package READMEs URL: https://github.com/apache/airflow/pull/8012#discussion_r400167480 ## File path: airflow/providers/google/BACKPORT_README.md ## @@ -0,0 +1,24 @@ + + +## Backport Google Package limitations: + +* Kubernetes Pod operators imports are refactored to contrib.kubernetes Review comment: I don't understand that. Can you tell more about it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
