[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#discussion_r326501769 ## File path: scripts/ci/kubernetes/kube/templates/configmaps.template.yaml ## @@ -54,6 +54,9 @@ data: statsd_port = 8125 statsd_prefix = airflow +# optional comma-separated prefix whitelist (e.g: scheduler,executor,dagrun) +statsd_whitelist = Review comment: Ok, I'm going to remove it for reducing the PR scope. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#discussion_r325946986 ## File path: scripts/ci/kubernetes/kube/templates/configmaps.template.yaml ## @@ -54,6 +54,9 @@ data: statsd_port = 8125 statsd_prefix = airflow +# optional comma-separated prefix whitelist (e.g: scheduler,executor,dagrun) +statsd_whitelist = Review comment: But isn't a good idea to keep the configmap.yaml templates aligned with the default `.cfg` template? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#discussion_r325946586 ## File path: docs/metrics.rst ## @@ -41,6 +41,13 @@ Add the following lines to your configuration file e.g. ``airflow.cfg`` statsd_port = 8125 statsd_prefix = airflow +If you want to avoid send all the available metrics to StatsD, you can configure a whitelist of prefixes to send only +the metrics that start with the elements of the list: + +.. code-block:: bash Review comment: Oh now makes sense! I'll do it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#discussion_r325452768 ## File path: docs/metrics.rst ## @@ -41,6 +41,13 @@ Add the following lines to your configuration file e.g. ``airflow.cfg`` statsd_port = 8125 statsd_prefix = airflow +If you want to avoid send all the available metrics to StatsD, you can configure a whitelist of prefixes to send only +the metrics that start with the elements of the list: + +.. code-block:: bash + Review comment: This config is under `[scheduler]`. I'll add that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#discussion_r325452402 ## File path: docs/metrics.rst ## @@ -41,6 +41,13 @@ Add the following lines to your configuration file e.g. ``airflow.cfg`` statsd_port = 8125 statsd_prefix = airflow +If you want to avoid send all the available metrics to StatsD, you can configure a whitelist of prefixes to send only +the metrics that start with the elements of the list: + +.. code-block:: bash Review comment: Hi @mik-laj, I just checked and currently, there is no `.. code-block:: init` in the codebase. Do you think it's a good idea to start that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
