[GitHub] [airflow] o-nikolas commented on pull request #29772: Support deleting the local log files when using remote logging

2023-03-07 Thread via GitHub


o-nikolas commented on PR #29772:
URL: https://github.com/apache/airflow/pull/29772#issuecomment-1458467107

   > > Ehh, ya, but I think it's possible. We've done this with executors and 
they will soon live in entirely different provider packages. But either way, 
not a blocker for this PR
   > 
   > Can you open a followup issue and describe the task?
   
   Sure, will do :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] o-nikolas commented on pull request #29772: Support deleting the local log files when using remote logging

2023-03-06 Thread via GitHub


o-nikolas commented on PR #29772:
URL: https://github.com/apache/airflow/pull/29772#issuecomment-1457168516

   > > We should really create a nice base class/interface for that stuff
   > 
   > I think it's difficult with the decoupling policy we have for providers.
   
   Ehh, ya, but I think it's possible. We've done this with executors and they 
will soon live in entirely different provider packages. But either way, not a 
blocker for this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] o-nikolas commented on pull request #29772: Support deleting the local log files when using remote logging

2023-03-02 Thread via GitHub


o-nikolas commented on PR #29772:
URL: https://github.com/apache/airflow/pull/29772#issuecomment-1452510296

   Looks like there are still some failing tests @hussein-awala 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org