[GitHub] [airflow] potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible
potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible URL: https://github.com/apache/airflow/pull/5362#discussion_r291827624 ## File path: airflow/dag/base_dag.py ## @@ -17,6 +17,8 @@ # specific language governing permissions and limitations # under the License. +"""Base classes for DAG and DagBag.""" Review comment: I am good with that - one liner is ok. PEP is always right. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible
potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible URL: https://github.com/apache/airflow/pull/5362#discussion_r291827624 ## File path: airflow/dag/base_dag.py ## @@ -17,6 +17,8 @@ # specific language governing permissions and limitations # under the License. +"""Base classes for DAG and DagBag.""" Review comment: I am good with that. PEP is always right. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible
potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible URL: https://github.com/apache/airflow/pull/5362#discussion_r289659649 ## File path: airflow/dag/base_dag.py ## @@ -17,6 +17,8 @@ # specific language governing permissions and limitations # under the License. +"""Base classes for DAG and DagBag.""" Review comment: @andriisoldatenko -> do you mean just changing it to be three-liner instead of one ? It does look neater so @BasPH maybe you can change it here before merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
