[GitHub] [airflow] potiuk commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
potiuk commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow URL: https://github.com/apache/airflow/pull/7730#discussion_r396077467 ## File path: INSTALL ## @@ -11,12 +24,31 @@ java -jar apache-rat.jar -E ./.rat-excludes -d . # to connect to other services. You might want to test or run Airflow # from a virtual env to make sure those dependencies are separated # from your system wide versions -python -m my_env -source my_env/bin/activate -# [required] building and installing -# by pip (preferred) +python3 -m venv PATH_TO_YOUR_VENV +source PATH_TO_YOUR_VENV/bin/activate + +# [required] building and installing by pip (preferred) pip install . # or directly python setup.py install + +# You can also install recommended version of the dependencies by using requirements.txt +# as constraint file + +pip install . --constraint requirements.txt Review comment: You do not have to - it's the recommended version of dependencies. This is just a hint that you can do it. I proposed to have "apache-airflow-pinned" package release separately. with clear purpose in mind "to have repeatable installation" I agreed having the --constraint and having to know which version to install might be confusing - that was my point in the discussion - but there are different opinions. For now I just want to merge requirements.txt and it's maintenance mechanism so that we avoid further breakage. But the discussion continues here how to approach it: https://lists.apache.org/thread.html/rf8b0ea9a7b93482734ae9e10e7d87f3c31679edb5eaf88496e733aa5%40%3Cdev.airflow.apache.org%3E I invite you to take part in the discussion and propose some solutions/approach. I would really love to have yours (and others) opinions in the thread there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
potiuk commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow URL: https://github.com/apache/airflow/pull/7730#discussion_r392691267 ## File path: INSTALL ## @@ -1,22 +1,5 @@ # INSTALL / BUILD instructions for Apache Airflow -# [required] fetch the tarball and untar the source -# change into the directory that was untarred. - -# [optional] run Apache RAT (release audit tool) to validate license headers -# RAT docs here: https://creadur.apache.org/rat/. Requires Java and Apache Rat -java -jar apache-rat.jar -E ./.rat-excludes -d . - -# [optional] Airflow pulls in quite a lot of dependencies in order -# to connect to other services. You might want to test or run Airflow -# from a virtual env to make sure those dependencies are separated -# from your system wide versions -python -m my_env -source my_env/bin/activate - -# [required] building and installing -# by pip (preferred) -pip install . - -# or directly -python setup.py install +We used to have generic instructions for local installation for development here +However it's much easier to install and develop Airflow via Breeze development Review comment: Yep. I updated the description now and made even more valid with additional information and generated extras list This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
potiuk commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow URL: https://github.com/apache/airflow/pull/7730#discussion_r392682021 ## File path: INSTALL ## @@ -1,22 +1,5 @@ # INSTALL / BUILD instructions for Apache Airflow -# [required] fetch the tarball and untar the source -# change into the directory that was untarred. - -# [optional] run Apache RAT (release audit tool) to validate license headers -# RAT docs here: https://creadur.apache.org/rat/. Requires Java and Apache Rat -java -jar apache-rat.jar -E ./.rat-excludes -d . - -# [optional] Airflow pulls in quite a lot of dependencies in order -# to connect to other services. You might want to test or run Airflow -# from a virtual env to make sure those dependencies are separated -# from your system wide versions -python -m my_env -source my_env/bin/activate - -# [required] building and installing -# by pip (preferred) -pip install . - -# or directly -python setup.py install +We used to have generic instructions for local installation for development here +However it's much easier to install and develop Airflow via Breeze development Review comment: It was recommending to install -e . :). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
