[GitHub] [airflow] potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM
potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-599458182 Will be the fastest merged AIP ever (-3 days). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM
potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-599451105 Yeah. Happy to make the pitch @dstandish -> understand you are not convinced. I think it would be great to start voting on the currently merged scope - even if it is merged now. We can always revert it :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM
potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-599447024 I think we discussed (in the thread on the devlist) that this change did not need voting - especially that it is fully backwards compatible, has literally no change to the current behaviour and has no "generic" secret implementation. But yes I think it was a bit rushed (my fault, sorry for that) - I think we might want to vote on it retroactively including the option of adding a general secret backend and possibly backporting this to 1.10 ?) (@dstandish ? ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM
potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-599050292 Coool! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM
potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-599022574 All good. I will fix the problem with docker image and pulling (there is a general problem that I am fixing now) and we are good to go I think! I don't think we need vote on it :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM
potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-598596576 @kaxil -> can you also take a look if it looks good. I think actually it's a good candidate to cherry-pick to 1.10.10 :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM
potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-598208489 I like this approach better. Have you thought about adding generic "get secret" implementation ?I am not sure if this has been rejected so far or at all :)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
