[GitHub] [airflow] potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions
potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions URL: https://github.com/apache/airflow/pull/7433#issuecomment-587970268 > Looks good other than one small tidy up. Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions
potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions URL: https://github.com/apache/airflow/pull/7433#issuecomment-587814433 Hey @ashb. Are you ok with how it is ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions
potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions URL: https://github.com/apache/airflow/pull/7433#issuecomment-587228520 > We should make sure this works for pyenv, but at a code level this LGTM Confirmed it works fr both pyenv and virtualenv. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions
potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions URL: https://github.com/apache/airflow/pull/7433#issuecomment-587074147 > I'm a little bit lost in two-in-one refactor in this PR (moving things to functions, and also renaming some env vars) but looks okay from what I can tell I could not resist the temptation to rename some of the variables and make them shorter. Since they are all internal and done automatically I think doing it while separating out functions might be a good idea. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions
potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions URL: https://github.com/apache/airflow/pull/7433#issuecomment-586743769 And @ashb -> that's the next step to make the breeze scripts simpler/better testable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions
potiuk commented on issue #7433: [AIRFLOW-6820] split breeze into functions URL: https://github.com/apache/airflow/pull/7433#issuecomment-586732529 Hey @dimberman -> this is part of the #6500 -> I split it into smaller pieces as you suggested. First was #7430 - already approved by Ash. Now this one which introduces functions to breeze and makes it much easier to read. The next one will be to move the build logic from ./hooks/build script to _utils.sh and that will be it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
