[GitHub] [airflow] potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter
potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter URL: https://github.com/apache/airflow/pull/7726#issuecomment-599448496 Right @feluelle ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter
potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter URL: https://github.com/apache/airflow/pull/7726#issuecomment-599264373 Somehow I can't re-open it :(. Likely you need to reopen it yourself @OmairK or create a new one with new branch name This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter
potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter URL: https://github.com/apache/airflow/pull/7726#issuecomment-599264312 And BTW - both @OmairK and @retornam can be co-authors of the change https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors - we've done that multiple times and this is true open-source spirit ... - so why don't you add @retornam co-author line to the change :)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter
potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter URL: https://github.com/apache/airflow/pull/7726#issuecomment-599254110 @OmairK -> I think you will have to rebase and push the branch again so that we can re-open it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter
potiuk commented on issue #7726: [AIRFLOW-4175] S3Hook load_file should support ACL policy parameter URL: https://github.com/apache/airflow/pull/7726#issuecomment-599254033 I think we can combine the two.. There are more tests in this one - so I think we should use it :). @retornam - how about you review this one instead of merging yours :)? Let's join forces. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
