[GitHub] [airflow] potiuk commented on issue #7832: Add production image support
potiuk commented on issue #7832: Add production image support URL: https://github.com/apache/airflow/pull/7832#issuecomment-608021302 > @feluelle works! had to run `./breeze setup-autocomplete` and then restart shell. Might be worth mentioning in the docs or UPDATING.md? I think it really depend on your setup. simply '. ./breeze-complete' should do. Did you have another directory with airflow somewhere? Tejh setup-autocomplete sets up a symbolic link to breeze-complete and only one can be active at the same time ... It's a bit tricky to get it right if you have more than one breeze command... The command itself will work though (it will use correct definition). I keep the master v1_10_test in sync so most of the auto-complete is good for both (some values like python version are not) and eventually you will get it right next time you get into the shell... Not sure if UPDATING.md is for those dev tools though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7832: Add production image support
potiuk commented on issue #7832: Add production image support URL: https://github.com/apache/airflow/pull/7832#issuecomment-607936924 :tada: :tada: ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7832: Add production image support
potiuk commented on issue #7832: Add production image support URL: https://github.com/apache/airflow/pull/7832#issuecomment-607739577 Hey @ashb @kaxil - I want to merge it to 1.10.10 before we release, Is there anything else you want to comment on? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7832: Add production image support
potiuk commented on issue #7832: Add production image support URL: https://github.com/apache/airflow/pull/7832#issuecomment-607582286 All corrected - please take another look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7832: Add production image support
potiuk commented on issue #7832: Add production image support URL: https://github.com/apache/airflow/pull/7832#issuecomment-606808500 @ashb - are you OK with the explanations? I'd love to merge it and do some follow-ups (and cherry-pick it to 1.10.10). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7832: Add production image support
potiuk commented on issue #7832: Add production image support URL: https://github.com/apache/airflow/pull/7832#issuecomment-606709575 All corrections made! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7832: Add production image support
potiuk commented on issue #7832: Add production image support
URL: https://github.com/apache/airflow/pull/7832#issuecomment-605688716
This is heavily improved version of the prod image:
- I can run it from either local sources or using releases from github
- added a lot of documentation in IMAGES.rst
- added yarn steps to have optimized javascript code (still need to test it)
- Breeze is updated so that you should be able now build, run, exec either
CI or prod image using the same command ('breeze, breeze exec, breeze
build-image [--production-image]).
I think it's almost ready to be merged as "alpha quality" image. I will make
some more tests, but I would love more review comments.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
