[GitHub] [airflow] potiuk commented on pull request #28255: Revert "Unquarantine background webserver test (#28249)"

2022-12-09 Thread GitBox


potiuk commented on PR #28255:
URL: https://github.com/apache/airflow/pull/28255#issuecomment-1344864039

   Fingers crossed but seems that https://github.com/apache/airflow/pull/28252 
fixed the problem. 爛 
   
   3 full "green" main/canary builds since it was merged - all of them fully 
green.  Closing. 
   
   Thanks @Taragolis for the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #28255: Revert "Unquarantine background webserver test (#28249)"

2022-12-09 Thread GitBox


potiuk commented on PR #28255:
URL: https://github.com/apache/airflow/pull/28255#issuecomment-1344222351

   Unfortunately - the only way to REALLY check if flaky tests like that are 
fixed is to run it for a number of PRs that people will raise :(.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #28255: Revert "Unquarantine background webserver test (#28249)"

2022-12-09 Thread GitBox


potiuk commented on PR #28255:
URL: https://github.com/apache/airflow/pull/28255#issuecomment-1344221206

   I rebased on top of #28582 and changed this so let's keep that one ready to 
merge if we find that the timeout is not enough


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #28255: Revert "Unquarantine background webserver test (#28249)"

2022-12-09 Thread GitBox


potiuk commented on PR #28255:
URL: https://github.com/apache/airflow/pull/28255#issuecomment-1344216663

   Just merged #28252  from @Taragolis and let's see - maybe that will help. I 
am willing to take some chances on it :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #28255: Revert "Unquarantine background webserver test (#28249)"

2022-12-09 Thread GitBox


potiuk commented on PR #28255:
URL: https://github.com/apache/airflow/pull/28255#issuecomment-1344163096

   Hmm. even with the fix, the test is still not stable - for example 
https://github.com/apache/airflow/actions/runs/3656433350/jobs/6179155045
   
   Reverting


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org