[GitHub] [airflow] ratb3rt commented on a change in pull request #6609: [AIRFLOW-5950] AIP-21 Change import paths for "apache/cassandra" modules
ratb3rt commented on a change in pull request #6609: [AIRFLOW-5950] AIP-21 Change import paths for "apache/cassandra" modules URL: https://github.com/apache/airflow/pull/6609#discussion_r349019087 ## File path: scripts/ci/pylint_todo.txt ## @@ -1,4 +1,5 @@ ./airflow/configuration.py +./airflow/configuration.py:1:0: Review comment: pylint script ticketed, fixed, PRed and merged :) This instance has been corrected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ratb3rt commented on a change in pull request #6609: [AIRFLOW-5950] AIP-21 Change import paths for "apache/cassandra" modules
ratb3rt commented on a change in pull request #6609: [AIRFLOW-5950] AIP-21 Change import paths for "apache/cassandra" modules URL: https://github.com/apache/airflow/pull/6609#discussion_r348480788 ## File path: scripts/ci/pylint_todo.txt ## @@ -1,4 +1,5 @@ ./airflow/configuration.py +./airflow/configuration.py:1:0: Review comment: I'll take a look, and open a ticket This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ratb3rt commented on a change in pull request #6609: [AIRFLOW-5950] AIP-21 Change import paths for "apache/cassandra" modules
ratb3rt commented on a change in pull request #6609: [AIRFLOW-5950] AIP-21 Change import paths for "apache/cassandra" modules URL: https://github.com/apache/airflow/pull/6609#discussion_r348348796 ## File path: scripts/ci/pylint_todo.txt ## @@ -1,4 +1,5 @@ ./airflow/configuration.py +./airflow/configuration.py:1:0: Review comment: Odd that I didn't spot that - I ran the pylint todo refresh script, to make sure I hadn't missed anything that might get picked up in Travis, and didn't see any of hat it had added that line :/ my bad, I'll remove it and repush. Looks like I failed the docs build too - I always forget to add these new provider dirs into the doc list :/ A note: the operators/hooks page is going to get really full with all of the new dirs that will need to be added to it... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ratb3rt commented on a change in pull request #6609: [AIRFLOW-5950] AIP-21 Change import paths for "apache/cassandra" modules
ratb3rt commented on a change in pull request #6609: [AIRFLOW-5950] AIP-21 Change import paths for "apache/cassandra" modules URL: https://github.com/apache/airflow/pull/6609#discussion_r348348796 ## File path: scripts/ci/pylint_todo.txt ## @@ -1,4 +1,5 @@ ./airflow/configuration.py +./airflow/configuration.py:1:0: Review comment: Odd that I didn't spot that - I ran the pylint todo refresh script, to make sure I hadn't missed anything that might get picked up in Travis, and didn't see any of hat it had added that line :/ my bad, I'll remove it and repush This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
