[GitHub] [airflow] serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class properties
serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class properties URL: https://github.com/apache/airflow/pull/5557#issuecomment-532877001 @ashb It's good to go This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class properties
serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class properties URL: https://github.com/apache/airflow/pull/5557#issuecomment-524633452 @ashb Fixed your comments and rebased. Please take another look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class properties
serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class properties URL: https://github.com/apache/airflow/pull/5557#issuecomment-511096329 @ashb I don't have a benchmark. The default arguments are evaluated in parsing, but still we don't need to evaluate multiple times. Also, two changes are in functions' bodies which is executed multiple times. (One is in a loop for every task). Configuration doesn't store the values (in that case it would be "same" cost to retrieve it from there), but instead it is only storing the plaintext and it's evaluating and "parsing" each variable on each call - I'm not 100% sure but that's what I got from skimming through the code. Let me know if you think this doesn't provide any value and will close it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
