[GitHub] [airflow] shahar1 commented on pull request #27797: Add tests to PythonOperator

2022-12-25 Thread GitBox


shahar1 commented on PR #27797:
URL: https://github.com/apache/airflow/pull/27797#issuecomment-1364649670

   @uranusjr Hey, could you please help me finalize this PR? I'm having some 
trouble with the unit tests, probably due to the `raise ... from None` 
statement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] shahar1 commented on pull request #27797: Add tests to PythonOperator

2022-12-09 Thread GitBox


shahar1 commented on PR #27797:
URL: https://github.com/apache/airflow/pull/27797#issuecomment-1345175705

   > Still fixes needed :(
   
   I think the tests haven't passed until now because of other tests in the 
`main` branch.
   In that case, do we have to wait until the other tests are ok?
   @uranusjr Thank you for the fixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] shahar1 commented on pull request #27797: Add tests to PythonOperator

2022-12-09 Thread GitBox


shahar1 commented on PR #27797:
URL: https://github.com/apache/airflow/pull/27797#issuecomment-1345175665

   > Still fixes needed :(
   
   I think the tests haven't passed until now because of other tests in the 
`main` branch.
   In that case, to merge this PR, do we have to wait until the other tests are 
ok along with this one?
   @uranusjr Thank you for the kind help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] shahar1 commented on pull request #27797: Add tests to PythonOperator

2022-11-25 Thread GitBox


shahar1 commented on PR #27797:
URL: https://github.com/apache/airflow/pull/27797#issuecomment-1327987556

   > Tests need fixing
   
   Thank you for the pushing, is there anything else required?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org