[GitHub] [airflow] zhongjiajie commented on issue #7729: [AIRFLOW-7066] Use sphinx syntax in concepts.rst
zhongjiajie commented on issue #7729: [AIRFLOW-7066] Use sphinx syntax in concepts.rst URL: https://github.com/apache/airflow/pull/7729#issuecomment-599305130 > > BTW, I have some question could not understand, in my PR #7709, raise pylint error three time, but `airflow/www/views.py` is in `pylint_todo.txt`, which mean will not test by pylint, also test folder will not test by pylint. should where the pylint error? (I only change two files) > > I test in breeze using `pylint airflow/www/views.py` and `pylint test/www/views.py` only `airflow/www/views.py` have some error hint(but it in pylint_todo.txt) > > @exploy > > It is the test/ that is failing. We have two separate pre-commits - pylint and pylint-test . The test one is failing in the other build and should be fixed there. Ok, will take a look to the test, BTW, thanks for merging This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #7729: [AIRFLOW-7066] Use sphinx syntax in concepts.rst
zhongjiajie commented on issue #7729: [AIRFLOW-7066] Use sphinx syntax in concepts.rst URL: https://github.com/apache/airflow/pull/7729#issuecomment-599189560 BTW, I have some question could not understand, in my PR https://github.com/apache/airflow/pull/7709, raise pylint error three time, but `airflow/www/views.py` is in `pylint_todo.txt`, which mean will not test by pylint, also test folder will not test by pylint. should where the pylint error? (I only change two files) I test in breeze using `pylint airflow/www/views.py` and `pylint test/www/views.py` only `airflow/www/views.py` have some error hint(but it in pylint_todo.txt) @exploy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #7729: [AIRFLOW-7066] Use sphinx syntax in concepts.rst
zhongjiajie commented on issue #7729: [AIRFLOW-7066] Use sphinx syntax in concepts.rst URL: https://github.com/apache/airflow/pull/7729#issuecomment-599188735 Seem CI failed with unrelated error, https://travis-ci.org/github/apache/airflow/jobs/662646733?utm_medium=notification_source=github_status This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
