[GitHub] XD-DENG commented on a change in pull request #4415: [AIRFLOW-3606] Fix Flake8 test & fix the Flake8 errors introduced since Flake8 test was broken

2019-01-01 Thread GitBox 
XD-DENG commented on a change in pull request #4415: [AIRFLOW-3606] Fix Flake8 
test & fix the Flake8 errors introduced since Flake8 test was broken
URL: https://github.com/apache/incubator-airflow/pull/4415#discussion_r244669014
 
 

 ##
 File path: airflow/bin/cli.py
 ##
 @@ -69,7 +69,6 @@
 from airflow.www_rbac.app import create_app as create_app_rbac
 from airflow.www_rbac.app import cached_appbuilder
 
-from sqlalchemy import func
 
 Review comment:
   Exactly. The func usage was removed in 
https://github.com/apache/incubator-airflow/commit/53e707428826d603f43aebb73e18fe077881c4b3#diff-1c2404a3a60f829127232842250ff406
 which was merged three days ago.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] XD-DENG commented on a change in pull request #4415: [AIRFLOW-3606] Fix Flake8 test & fix the Flake8 errors introduced since Flake8 test was broken

2018-12-31 Thread GitBox 
XD-DENG commented on a change in pull request #4415: [AIRFLOW-3606] Fix Flake8 
test & fix the Flake8 errors introduced since Flake8 test was broken
URL: https://github.com/apache/incubator-airflow/pull/4415#discussion_r244628797
 
 

 ##
 File path: .flake8
 ##
 @@ -1,4 +1,3 @@
 [flake8]
 max-line-length = 110
 ignore = E731
-exclude = .git, env, venv, .venv, VENV, .tox, .eggs, .*
 
 Review comment:
   I'm not completely sure, but I believe it's the `.*`.
   
   But before we trouble-shoot thoroughly, I would suggest to revert the whole 
line to ensure that Travis CI works as expected.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services